From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 9996BA00C4;
	Fri, 28 Jan 2022 23:52:02 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 370A142857;
	Fri, 28 Jan 2022 23:52:02 +0100 (CET)
Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com
 [209.85.215.178])
 by mails.dpdk.org (Postfix) with ESMTP id E303440041
 for <dev@dpdk.org>; Fri, 28 Jan 2022 23:52:00 +0100 (CET)
Received: by mail-pg1-f178.google.com with SMTP id t32so6502963pgm.7
 for <dev@dpdk.org>; Fri, 28 Jan 2022 14:52:00 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20210112.gappssmtp.com; s=20210112;
 h=date:from:to:cc:subject:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding;
 bh=x2jxW+HXOaxAGvyABGN8E9Qw44UE9OyPpUBHieOPEeo=;
 b=eUTdMFEeA14zQAhNrO6ZjLajWzPTfZpgJl+RK72uM+seo1mSRiYjuepeHCMRY0HNs0
 Rc2kvUxKpTTeOSc2de/qdltlkc5/SeVczGSGRCpRzDXSRCGGBdGquoKdOlqT1GI3pPnk
 oYXtaM3HAf1KsJVW5oJ0jClzr2SWMas7/JI31BwkBXs+nOXg+COkbvuuggb0Gqvlsedc
 efgtEPxG+6oHSdl0+2ec1wWHWvYYdadRWiRloSt3yFLpngAB+2PuJIizsTt13bmVajWt
 wcYjqjtamT7VMppDc5Ct97jhOUkfs1HAmLSNxfCahlm93NLqv04P0PzE8O4UxhPmBoKX
 PGgw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
 :references:mime-version:content-transfer-encoding;
 bh=x2jxW+HXOaxAGvyABGN8E9Qw44UE9OyPpUBHieOPEeo=;
 b=PZmedCIoikSS1aznNq3wlTHtQ/3zqc/lD4qQl4U/OPdK2xiOsTf5qC7IaNnwBGpyHR
 rrNaOMhdoUu85SY2WA7rGpIsHnVCjdOv3w3nYJxA79CTTvPu9SRP6raJzy38LRQWovZX
 taqwMK+IOV3E1B1coPcl5bm1jX3LMQ0sHdetVIHXhPueKOYbq3HEJfpEY0mr/CirNcha
 GT0lVjlnr+eDn7tjQwv5Fw1n+sL8dPf87QJvn/lCLUVznyKowsePVUsGyKey+fS/nMB7
 Tw4bDfIzfIUDA1UTtelsZaddtoiIb9fkYBvqMWknDj5pNZQPRUM8divaL70UerZytyY0
 luAg==
X-Gm-Message-State: AOAM530zWRyQwZRr9IA7AbI9aQRm45oXhVr+ds18qRJ9r9kQRxBFdCFJ
 KjsVFOG0MbADdkTE43Zro4WaTRa0/sxHNQ==
X-Google-Smtp-Source: ABdhPJygXz0X4vFhg3Ovf7BKaTtUbGrPFbsa0HlWRhkmhVfAwiZszNpQ+/KM9jJC7M1bXYoguqO2SA==
X-Received: by 2002:a63:83c6:: with SMTP id h189mr5858127pge.128.1643410319950; 
 Fri, 28 Jan 2022 14:51:59 -0800 (PST)
Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199])
 by smtp.gmail.com with ESMTPSA id
 g12sm7511913pfj.186.2022.01.28.14.51.59
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Fri, 28 Jan 2022 14:51:59 -0800 (PST)
Date: Fri, 28 Jan 2022 14:51:55 -0800
From: Stephen Hemminger <stephen@networkplumber.org>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, Yipeng Wang <yipeng1.wang@intel.com>, Sameh Gobriel
 <sameh.gobriel@intel.com>, Bruce Richardson <bruce.richardson@intel.com>,
 Vladimir Medvedkin <vladimir.medvedkin@intel.com>, Olivier Matz
 <olivier.matz@6wind.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>, Konstantin Ananyev
 <konstantin.ananyev@intel.com>
Subject: Re: [PATCH v2 01/83] lib: update documentation of XXX_free() functions
Message-ID: <20220128145155.11bf10cd@hermes.local>
In-Reply-To: <109562095.nniJfEyVGO@thomas>
References: <20220124000518.319850-1-stephen@networkplumber.org>
 <20220124174719.14417-1-stephen@networkplumber.org>
 <20220124174719.14417-2-stephen@networkplumber.org>
 <109562095.nniJfEyVGO@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Fri, 28 Jan 2022 22:47:15 +0100
Thomas Monjalon <thomas@monjalon.net> wrote:

> 24/01/2022 18:45, Stephen Hemminger:
> > These functions all behave like libc free() and do
> > nothing if handed a NULL pointer. The code is already doing
> > this, this patch just documents the behavior.
> > 
> > Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> > ---
> >  /**
> >   * De-allocate all memory used by hash table.
> > + *
> > + * If the pointer is NULL, the function does nothing.  
> 
> Would be better to move in the context of the parameter

I copied text from rte_free to other functions...
For consistency, lets document it one way in all cases.
Don't care which one...