From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C72D7A04A4; Fri, 4 Feb 2022 23:26:42 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51EFD4013F; Fri, 4 Feb 2022 23:26:42 +0100 (CET) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by mails.dpdk.org (Postfix) with ESMTP id BB9F440041 for ; Fri, 4 Feb 2022 23:26:40 +0100 (CET) Received: by mail-pl1-f180.google.com with SMTP id y17so6313641plg.7 for ; Fri, 04 Feb 2022 14:26:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=GEKPDdYUwVyE66SPDBaIq8Fv08e/Xj40+rr+GIPmDVA=; b=iMUkwgQRytF9k7sT/kKPPxxnFRiVhzabXa9/zg44L1sK123TgQNDoHTBp5W8S5Jmtu VYC2pekz7z+2lcZr75VkZ742vDvmY+3vivs8I6aLLOwIaJW9+pSHGbMDlddfsYOELFeQ SQZ3T4ZA+sZKdKdm4MQfybIMwj7G2tk6OXnjStxMe7bBTyfNvEYjnp2wTCjW80HfjVWy ooAZkyp9l7yDlirjmV4tQj0rrSco5nSLAs6nnc79CetxGrkpQKtwjNpLNLdb2SzakBj9 /fvjuqyg99yGdVT9qEMkiEug5/woe/RGOV5Vo2KOgGKL/XCD2PzW3phUQdvM0xwPHOYs slwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=GEKPDdYUwVyE66SPDBaIq8Fv08e/Xj40+rr+GIPmDVA=; b=vUAYceeDCzxuHGU7zkUSxu7owTolaSYqQIceyxyhLbEXbz5TNts1yWbgnUEaNcSw83 j72hY8J/ar59LA2XNeCjuE2e1EPIRqZaY5Nj69PZWn/Qijj0D2COhFqLlgRAA3sJCmlj 2w8T3RRrkQ2Zks9or15ob/giMsoy+9GW+FKasSOZHfMI1Cq0pql5RrSudqEnQIK9CCPZ asX5+aC37EQpjc9gK8YGhQRiJ763i5OQFbx/XJ+q8an77XFG5WvsvrO68+rZ3C36pHwQ 2RjUsw8z5udZYWmVmupX8lW1+mvCNs8RH6Qq3dVnJOIqjLuWZZIJVtoFOP1f7Dv7A16h /koA== X-Gm-Message-State: AOAM531Pp5vLYebuHGJy38G5jYILBIOyknbvlm8A3kTFs7dyfnQ89MK2 SPdy181Q4ZzDmvllV9HqN6I8JJdDGBvla0Ys X-Google-Smtp-Source: ABdhPJzkyoxXRU8E7NtHpy24b9zSUNyfw0O+j3BD/Krqjapgmt65LUw1d8KTdzMbiCoZkX5YF5TUSQ== X-Received: by 2002:a17:90b:682:: with SMTP id m2mr5672408pjz.22.1644013599658; Fri, 04 Feb 2022 14:26:39 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id i17sm2440061pgv.8.2022.02.04.14.26.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Feb 2022 14:26:39 -0800 (PST) Date: Fri, 4 Feb 2022 14:26:36 -0800 From: Stephen Hemminger To: Sean Morrissey Cc: dev@dpdk.org Subject: Re: [PATCH v5 0/2] Add config file support for l3fwd Message-ID: <20220204142636.6250f05c@hermes.local> In-Reply-To: <20220204195905.449192-1-sean.morrissey@intel.com> References: <20220126124459.2469838-1-sean.morrissey@intel.com> <20220204195905.449192-1-sean.morrissey@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 4 Feb 2022 19:59:03 +0000 Sean Morrissey wrote: > This patchset introduces config file support for l3fwd > and its lookup methods LPM, FIB, and EM, similar to > that of l3fwd-acl. This allows for route rules to be > defined in configuration files and edited there instead > of in each of the lookup methods hardcoded route tables. > > V4: > * Fix nondeterministic bug of segfault on termination of > sample app. > V5: > * Reintroduce hardcoded tables as to not break dts and > allow for hardcoded tables to be used if no config > files presented. > > Sean Morrissey (2): > examples/l3fwd: add config file support for LPM/FIB > examples/l3fwd: add config file support for EM > > doc/guides/sample_app_ug/l3_forward.rst | 89 +++-- > examples/l3fwd/em_default_v4.cfg | 17 + > examples/l3fwd/em_default_v6.cfg | 17 + > examples/l3fwd/l3fwd.h | 41 +++ > examples/l3fwd/l3fwd_em.c | 471 +++++++++++++++++------- > examples/l3fwd/l3fwd_fib.c | 50 +-- > examples/l3fwd/l3fwd_lpm.c | 315 +++++++++++++++- > examples/l3fwd/l3fwd_route.h | 41 +++ > examples/l3fwd/lpm_default_v4.cfg | 17 + > examples/l3fwd/lpm_default_v6.cfg | 17 + > examples/l3fwd/main.c | 68 +++- > 11 files changed, 949 insertions(+), 194 deletions(-) > create mode 100644 examples/l3fwd/em_default_v4.cfg > create mode 100644 examples/l3fwd/em_default_v6.cfg > create mode 100644 examples/l3fwd/lpm_default_v4.cfg > create mode 100644 examples/l3fwd/lpm_default_v6.cfg > Why not use the DPDK cfgfile library and format? It is model after standard INI format.