From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A83EA034E; Sun, 6 Feb 2022 17:23:08 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 877714069D; Sun, 6 Feb 2022 17:23:07 +0100 (CET) Received: from mail-lf1-f53.google.com (mail-lf1-f53.google.com [209.85.167.53]) by mails.dpdk.org (Postfix) with ESMTP id B192A40685 for ; Sun, 6 Feb 2022 17:23:05 +0100 (CET) Received: by mail-lf1-f53.google.com with SMTP id f10so22436490lfu.8 for ; Sun, 06 Feb 2022 08:23:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zaNbRH/CyjlF7s0i1BaVmB0hUV0wuZqVRLBte3qBsHM=; b=TY9Yld+UamFnd17nUqG3qYitH8oUswL7d1hFfS4NQA2qyKQt88LToZq033/OTjgkC3 vClO3wNGOITNi1iC0eSNaD2H0Xo8E/0gn9i9/cZygg2pdTrLA2R92DSkLXXnpD7wwhaA prPFPecprLRZbbjjsRRHdlX5iHyGHK/g0n8AJzBUxXcejivznZbGOojWVuYvEqWLUJn2 OvEqMwUWwpwS38EsZfZzap8QoWFitYdWtxCc3HTJpRW4CY8hftpUsr1/xJudg01E9tKQ kdn4PDddTj5XZEEwSVng5CkGerjsZm++VXeSvmT3k0mh0nrHPiN97ECSwYHzj0ex9Qld m7Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zaNbRH/CyjlF7s0i1BaVmB0hUV0wuZqVRLBte3qBsHM=; b=iAkijv8lr6rixr8F8nPQTSmuLKH0D5VNZYOq8l3iQsj3cisVOoRhfeK1n6Sstsd0lY c3A/9Wb/QLdz1bZ4ExgXCEjJ7dr8hfg23lt66x734vnw02EaaMvMxO9FdyJukqLzsttj V+C8agrSB8qobQmfJkYPLgjTLZIBtbNWKQPp3q+cWOBUwrwWq+d7yiGRnQ0ZsLg1e7vi t3S+HRh13Z/2CqdE1trgB7CxVC6Ht/40G7U/idfN+KTUQUjplvoW991Zg9zAVx2c0/5m Z5cHYBE9lAQkAfb8NCvmNQG8Mx9PZgm5VUls0cHxTUilRTf9+ZGjOFhFzTNx6+XwHssR h1tg== X-Gm-Message-State: AOAM533CpjUjelA9nCxR6e2EZjWVVJZ/cz4OWvkHU4w5CurqlpfmESUN FpHvu8OOO74qjc8HoB9OSxY= X-Google-Smtp-Source: ABdhPJxUweoPO6aKz+35qsHf5i6sR7bxUguZePBFjuf611SNs1z6RCUb5qO05d99G3kxAAzZAOPeFA== X-Received: by 2002:ac2:43ae:: with SMTP id t14mr5436880lfl.599.1644164585119; Sun, 06 Feb 2022 08:23:05 -0800 (PST) Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru. [37.110.65.23]) by smtp.gmail.com with ESMTPSA id q14sm1144903lfu.224.2022.02.06.08.23.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Feb 2022 08:23:04 -0800 (PST) Date: Sun, 6 Feb 2022 19:23:03 +0300 From: Dmitry Kozlyuk To: Weiguo Li Cc: dev@dpdk.org, bruce.richardson@intel.com Subject: Re: [PATCH 5/6] eal/windows: fix the curly braces mismatch problem Message-ID: <20220206192303.38c560f7@sovereign> In-Reply-To: References: <20220206004414.2801177-1-liwg06@foxmail.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org 2022-02-06 08:44 (UTC+0800), Weiguo Li: > Supplement the first half of braces for the extern "C" block > > Fixes: 99a2dd955fba6 ("lib: remove librte_ prefix from directory names") > Cc: bruce.richardson@intel.com > > Signed-off-by: Weiguo Li > --- > lib/eal/windows/include/dirent.h | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/lib/eal/windows/include/dirent.h b/lib/eal/windows/include/dirent.h > index 34eb077f8c..0a399d3145 100644 > --- a/lib/eal/windows/include/dirent.h > +++ b/lib/eal/windows/include/dirent.h > @@ -28,6 +28,10 @@ > #include > #include > > +#ifdef __cplusplus > +extern "C" { > +#endif > + > /* Maximum length of file name */ > #if !defined(PATH_MAX) > # define PATH_MAX MAX_PATH This file is not public, used only from DPDK C code. Rather then adding the opening part, the closing part should be removed. The "Fixes" tag is incorrect, should be: Fixes: 6e1ed4cbbe99 ("eal/windows: add dirent implementation") Cc: pallavi.kadam@intel.com