From: Naga Harish K S V <s.v.naga.harish.k@intel.com>
To: jay.jayatheerthan@intel.com, jerinj@marvell.com
Cc: dev@dpdk.org
Subject: [PATCH] eventdev/eth_tx: fix queue add logic
Date: Tue, 8 Feb 2022 23:23:13 -0600 [thread overview]
Message-ID: <20220209052313.1557377-1-s.v.naga.harish.k@intel.com> (raw)
The internal function txa_service_queue_add is returning 0 in case of error.
correct this logic to return negative value to indicate failure.
Fixes: a3bbf2e09756 ("eventdev: add eth Tx adapter implementation")
Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
---
lib/eventdev/rte_event_eth_tx_adapter.c | 13 ++++++++-----
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c
index c17f33f098..49053e6bea 100644
--- a/lib/eventdev/rte_event_eth_tx_adapter.c
+++ b/lib/eventdev/rte_event_eth_tx_adapter.c
@@ -806,10 +806,8 @@ txa_service_queue_add(uint8_t id,
rte_spinlock_lock(&txa->tx_lock);
- if (txa_service_is_queue_added(txa, eth_dev, tx_queue_id)) {
- rte_spinlock_unlock(&txa->tx_lock);
- return 0;
- }
+ if (txa_service_is_queue_added(txa, eth_dev, tx_queue_id))
+ goto ret_unlock;
ret = txa_service_queue_array_alloc(txa, eth_dev->data->port_id);
if (ret)
@@ -821,6 +819,8 @@ txa_service_queue_add(uint8_t id,
tdi = &txa->txa_ethdev[eth_dev->data->port_id];
tqi = txa_service_queue(txa, eth_dev->data->port_id, tx_queue_id);
+ if (tqi == NULL)
+ goto err_unlock;
txa_retry = &tqi->txa_retry;
txa_retry->id = txa->id;
@@ -836,6 +836,9 @@ txa_service_queue_add(uint8_t id,
tdi->nb_queues++;
txa->nb_queues++;
+ret_unlock:
+ rte_spinlock_unlock(&txa->tx_lock);
+ return 0;
err_unlock:
if (txa->nb_queues == 0) {
txa_service_queue_array_free(txa,
@@ -844,7 +847,7 @@ txa_service_queue_add(uint8_t id,
}
rte_spinlock_unlock(&txa->tx_lock);
- return 0;
+ return -1;
}
static int
--
2.23.0
next reply other threads:[~2022-02-09 5:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-09 5:23 Naga Harish K S V [this message]
2022-02-09 5:31 ` [PATCH v2] " Naga Harish K S V
2022-02-11 16:33 ` Jayatheerthan, Jay
2022-02-14 15:23 ` Jerin Jacob
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220209052313.1557377-1-s.v.naga.harish.k@intel.com \
--to=s.v.naga.harish.k@intel.com \
--cc=dev@dpdk.org \
--cc=jay.jayatheerthan@intel.com \
--cc=jerinj@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).