From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE6BFA04A9; Wed, 9 Feb 2022 11:36:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D2B044118A; Wed, 9 Feb 2022 11:36:08 +0100 (CET) Received: from smtpbgbr2.qq.com (smtpbgbr2.qq.com [54.207.22.56]) by mails.dpdk.org (Postfix) with ESMTP id 8F38441C3D for ; Wed, 9 Feb 2022 11:36:06 +0100 (CET) X-QQ-mid: bizesmtp37t1644402953ti62rr90 Received: from wxdbg.localdomain.com (unknown [183.129.236.74]) by bizesmtp.qq.com (ESMTP) with id ; Wed, 09 Feb 2022 18:35:52 +0800 (CST) X-QQ-SSF: 01400000002000F0L000B00A0000000 X-QQ-FEAT: xoS364mEyr34hnzgQqRUYl+ZTF2j5DOI7sAz9y6OCymDYyloDggMwOxA844lJ EO6UewF1z+P+04BPntLLdQPvMbPpq/GeJbJKDDmMmJkp1rqEMZBvxmg+OlRlupPsPqOnWj6 Zc+0znooxTL/EOcyZW6L9aRaBvoryFnku3N+xTuwafd5IGT2h9XooYOXyXfOPPXz67ogzZS B5vmhhVqqgRGscKz7j+mMv56NbinWIBXY6ByQ0Beo3YgQ6Puo7zzqAWc+wsUngG2qf/+MvN 6yZv/khMJpahrZP/DTcaA4f/dNA1kYTzzVqZ7/nu4KbUGnQI4CIFAfLOikyKSFkl8mGMcyZ 3TC8rG+iVud3xi3SPKvGOOMt+I/XNJUEFfF91zysDmtHYJ/kHA= X-QQ-GoodBg: 2 From: Jiawen Wu To: dev@dpdk.org Cc: Jiawen Wu , stable@dpdk.org Subject: [PATCH v2 10/12] net/txgbe: fix debug log Date: Wed, 9 Feb 2022 18:42:11 +0800 Message-Id: <20220209104213.602728-11-jiawenwu@trustnetic.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20220209104213.602728-1-jiawenwu@trustnetic.com> References: <20220209104213.602728-1-jiawenwu@trustnetic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:trustnetic.com:qybgforeign:qybgforeign2 X-QQ-Bgrelay: 1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove 'DEBUGFUNC' due to too many invalid debug log prints. And fix that double line was added by using 'DEBUGOUT'. Fixes: 7dc117068a7c ("net/txgbe: support probe and remove") Cc: stable@dpdk.org Signed-off-by: Jiawen Wu --- drivers/net/txgbe/txgbe_logs.h | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/txgbe/txgbe_logs.h b/drivers/net/txgbe/txgbe_logs.h index 67e9bfb3af..8fa80a69b2 100644 --- a/drivers/net/txgbe/txgbe_logs.h +++ b/drivers/net/txgbe/txgbe_logs.h @@ -17,10 +17,13 @@ extern int txgbe_logtype_init; "%s(): " fmt "\n", __func__, ##args) extern int txgbe_logtype_driver; -#define PMD_DRV_LOG(level, fmt, args...) \ +#define PMD_TLOG_DRIVER(level, fmt, args...) \ rte_log(RTE_LOG_ ## level, txgbe_logtype_driver, \ "%s(): " fmt "\n", __func__, ##args) +#define PMD_DRV_LOG(level, fmt, args...) \ + PMD_TLOG_DRIVER(level, fmt "\n", ## args) + #ifdef RTE_LIBRTE_TXGBE_DEBUG_RX extern int txgbe_logtype_rx; #define PMD_RX_LOG(level, fmt, args...) \ @@ -48,11 +51,11 @@ extern int txgbe_logtype_tx_free; #define PMD_TX_FREE_LOG(level, fmt, args...) do { } while (0) #endif -#define TLOG_DEBUG(fmt, args...) PMD_DRV_LOG(DEBUG, fmt, ##args) +#define TLOG_DEBUG(fmt, args...) PMD_TLOG_DRIVER(DEBUG, fmt, ##args) #define DEBUGOUT(fmt, args...) TLOG_DEBUG(fmt, ##args) #define PMD_INIT_FUNC_TRACE() TLOG_DEBUG(" >>") -#define DEBUGFUNC(fmt) TLOG_DEBUG(fmt) +#define DEBUGFUNC(fmt) do { } while (0) extern int txgbe_logtype_bp; #define BP_LOG(fmt, args...) \ -- 2.21.0.windows.1