* [PATCH] examples/ipsec-secgw: add check for unprotected port mask
@ 2022-02-09 11:52 Volodymyr Fialko
2022-02-18 11:27 ` [EXT] " Anoob Joseph
0 siblings, 1 reply; 3+ messages in thread
From: Volodymyr Fialko @ 2022-02-09 11:52 UTC (permalink / raw)
To: dev, Radu Nicolau, Akhil Goyal
Cc: jerinj, konstantin.ananyev, Volodymyr Fialko
Usage of unprotected port mask without any configured SA inbound, will
cause use of uninitialized SA context, so disallow such configuration.
Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
---
examples/ipsec-secgw/ipsec-secgw.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/examples/ipsec-secgw/ipsec-secgw.c b/examples/ipsec-secgw/ipsec-secgw.c
index a643eb3aa7..602e170c96 100644
--- a/examples/ipsec-secgw/ipsec-secgw.c
+++ b/examples/ipsec-secgw/ipsec-secgw.c
@@ -3321,6 +3321,9 @@ main(int32_t argc, char **argv)
rte_exit(EXIT_FAILURE, "Invalid unprotected portmask 0x%x\n",
unprotected_port_mask);
+ if (unprotected_port_mask && !nb_sa_in)
+ rte_exit(EXIT_FAILURE, "Cannot use unprotected portmask without configured SA inbound\n");
+
if (check_poll_mode_params(eh_conf) < 0)
rte_exit(EXIT_FAILURE, "check_poll_mode_params failed\n");
--
2.25.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [EXT] [PATCH] examples/ipsec-secgw: add check for unprotected port mask
2022-02-09 11:52 [PATCH] examples/ipsec-secgw: add check for unprotected port mask Volodymyr Fialko
@ 2022-02-18 11:27 ` Anoob Joseph
2022-02-23 9:22 ` Akhil Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Anoob Joseph @ 2022-02-18 11:27 UTC (permalink / raw)
To: Volodymyr Fialko, dev, Radu Nicolau, Akhil Goyal
Cc: Jerin Jacob Kollanukkaran, konstantin.ananyev, Volodymyr Fialko
> ----------------------------------------------------------------------
> Usage of unprotected port mask without any configured SA inbound, will cause
> use of uninitialized SA context, so disallow such configuration.
>
> Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
>
> ---
> examples/ipsec-secgw/ipsec-secgw.c | 3 +++
> 1 file changed, 3 insertions(+)
>
Acked-by: Anoob Joseph <anoobj@marvell.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [EXT] [PATCH] examples/ipsec-secgw: add check for unprotected port mask
2022-02-18 11:27 ` [EXT] " Anoob Joseph
@ 2022-02-23 9:22 ` Akhil Goyal
0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2022-02-23 9:22 UTC (permalink / raw)
To: Anoob Joseph, Volodymyr Fialko, dev, Radu Nicolau
Cc: Jerin Jacob Kollanukkaran, konstantin.ananyev, Volodymyr Fialko
> > Usage of unprotected port mask without any configured SA inbound, will
> cause
> > use of uninitialized SA context, so disallow such configuration.
> >
> > Signed-off-by: Volodymyr Fialko <vfialko@marvell.com>
> >
> > ---
> > examples/ipsec-secgw/ipsec-secgw.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
>
> Acked-by: Anoob Joseph <anoobj@marvell.com>
Applied to dpdk-next-crypto
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-02-23 9:22 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-09 11:52 [PATCH] examples/ipsec-secgw: add check for unprotected port mask Volodymyr Fialko
2022-02-18 11:27 ` [EXT] " Anoob Joseph
2022-02-23 9:22 ` Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).