From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F2960A00C2; Thu, 10 Feb 2022 13:03:20 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7450740140; Thu, 10 Feb 2022 13:03:20 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id 65CC44013F for <dev@dpdk.org>; Thu, 10 Feb 2022 13:03:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644494598; x=1676030598; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=8tTswuWl64+DQomMfwZTRl5SiNKWM7Omx+XRqvQnm8A=; b=cHpQkVViCBLQ45F3M9xp4kM45Xl/sz0Is+PQBEOvWdGukDiRcO3AQn7U zlRFmMf9dRd5yJIBtKv3UYOHxUUHUzqv9spy+LUwqg0kwpHjoGuzcjV3f 9hOLpjJb8jT8wcbR0/WMn0UTE4YR7Bwn46s1dF9tsnkiedZ+T8pOAaWJF DHsz46U3776FqXijRIpPjCPTJErNQWU1qJZHtZR97e6tBLWAhsux4b2/Z c0i9K9BxXDPgjQCBnYYLOtYo7f1BjxrDSs2Q1dSwSNjVpzo7PIe/sq6g3 ftxVPdbHCMfcnIRNtr8DavEEpKy8NUpwh1Sp9OkwsbJPwslQwEuL/QO+A g==; X-IronPort-AV: E=McAfee;i="6200,9189,10253"; a="233036899" X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="233036899" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Feb 2022 04:03:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,358,1635231600"; d="scan'208";a="622658189" Received: from silpixa00399126.ir.intel.com ([10.237.223.162]) by FMSMGA003.fm.intel.com with ESMTP; 10 Feb 2022 04:03:16 -0800 From: Bruce Richardson <bruce.richardson@intel.com> To: dev@dpdk.org Cc: Bruce Richardson <bruce.richardson@intel.com> Subject: [PATCH v2 0/7] Verify C++ compatibility of public headers Date: Thu, 10 Feb 2022 12:02:50 +0000 Message-Id: <20220210120257.585822-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.32.0 In-Reply-To: <20220204174209.440207-1-bruce.richardson@intel.com> References: <20220204174209.440207-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org This patchset expands upon the exiting chkincs infrastructure to build a C++ test application as well as the existing C test app, which helps catch any build errors when the public DPDK headers are included in C++ code. The rest of this patchset fixes the errors caught by this additional check - mostly missing casts, but also one use of "new" as a variable name, and one missing closing brace for an 'extern "C"' block. V2: * Changed patch 6 to have a minimally-invasive fix for C++ without affecting existing C code. * Added fixlines and Cc stable for all patches which are fixes Bruce Richardson (7): eal: fix header build with C++ eventdev: fix header build with C++ graph: fix missing explicit cast for C++ build ipsec: fix missing explicit cast for C++ build table: fix missing explicit casts for C++ build vhost: fix incompatible header includes for C++ buildtools/chkincs: test headers for C++ compatibility buildtools/chkincs/main.cpp | 4 +++ buildtools/chkincs/meson.build | 20 +++++++++++++++ lib/eal/include/generic/rte_ticketlock.h | 14 +++++------ lib/eal/include/rte_trace_point.h | 2 +- lib/eventdev/rte_event_timer_adapter.h | 3 +++ lib/eventdev/rte_eventdev.h | 2 +- lib/graph/rte_graph_worker.h | 2 +- lib/ipsec/rte_ipsec_group.h | 4 +-- lib/table/rte_table_hash_func.h | 32 ++++++++++++------------ lib/vhost/rte_vhost.h | 2 ++ 10 files changed, 57 insertions(+), 28 deletions(-) create mode 100644 buildtools/chkincs/main.cpp -- 2.32.0