From: Radu Nicolau <radu.nicolau@intel.com>
To: Jingjing Wu <jingjing.wu@intel.com>, Beilei Xing <beilei.xing@intel.com>
Cc: dev@dpdk.org, yux.jiang@intel.com, Radu Nicolau <radu.nicolau@intel.com>
Subject: [PATCH] net/iavf: fix segmentation offload buffer size
Date: Thu, 10 Feb 2022 13:09:23 +0000 [thread overview]
Message-ID: <20220210130923.1442905-1-radu.nicolau@intel.com> (raw)
This reverts commit ff8b8bcd2ebe, which resulted in incorrect buffer size
being computed for TSO packets.
Fixes: ff8b8bcd2ebe ("net/iavf: fix segmentation offload condition")
Signed-off-by: Radu Nicolau <radu.nicolau@intel.com>
---
drivers/net/iavf/iavf_rxtx.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/iavf/iavf_rxtx.c b/drivers/net/iavf/iavf_rxtx.c
index b0fed1b992..ba272bb211 100644
--- a/drivers/net/iavf/iavf_rxtx.c
+++ b/drivers/net/iavf/iavf_rxtx.c
@@ -2464,9 +2464,10 @@ iavf_fill_data_desc(volatile struct iavf_tx_desc *desc,
desc->buffer_addr = rte_mbuf_data_iova(m);
/* calculate data buffer size less set header lengths */
- if (m->ol_flags & (RTE_MBUF_F_TX_TCP_SEG | RTE_MBUF_F_TX_UDP_SEG)) {
- if (m->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK)
- hdrlen += m->outer_l3_len;
+ if ((m->ol_flags & RTE_MBUF_F_TX_TUNNEL_MASK) &&
+ (m->ol_flags & (RTE_MBUF_F_TX_TCP_SEG |
+ RTE_MBUF_F_TX_UDP_SEG))) {
+ hdrlen += m->outer_l3_len;
if (m->ol_flags & RTE_MBUF_F_TX_L4_MASK)
hdrlen += m->l3_len + m->l4_len;
else
--
2.25.1
next reply other threads:[~2022-02-10 13:09 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-10 13:09 Radu Nicolau [this message]
2022-02-15 6:16 ` Huang, ZhiminX
2022-02-15 7:59 ` Zhang, Qi Z
2022-02-15 10:06 ` Ferruh Yigit
2022-02-15 10:46 ` Kevin Traynor
2022-02-15 11:25 ` Ferruh Yigit
2022-02-15 10:47 ` Nicolau, Radu
2022-02-15 11:19 ` Ferruh Yigit
2022-02-15 12:30 ` Nicolau, Radu
2022-02-15 12:44 ` Ferruh Yigit
2022-02-15 12:48 ` Ferruh Yigit
2022-02-15 15:52 ` Nicolau, Radu
2022-02-15 15:50 ` [PATCH v2] " Radu Nicolau
2022-02-20 5:35 ` Zhang, Qi Z
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220210130923.1442905-1-radu.nicolau@intel.com \
--to=radu.nicolau@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=yux.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).