From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92EF8A034E; Mon, 14 Feb 2022 15:47:18 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 348E041C26; Mon, 14 Feb 2022 15:46:02 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id C269441184 for <dev@dpdk.org>; Mon, 14 Feb 2022 15:45:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644849953; x=1676385953; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=efAlmhJXnh7VUu2HKp4OH8akOK47eUiZRTF03S+jBL8=; b=iUR2J9yM/xTOwFhCu1xzmETIWBXOSzFRoYjVTkYwf0lJx7Kw8vSpb/wL 5n//+ZpYJyRtWA+N9VH11gyls8rztfUUrVy7q++FGUa1UKFFuX6PXy8+b pNeWdDyu/qhqYZM0AJMdS1o/Y1hO0LGWCzI+mfBYWhNSH8X2NUUp0Hnme ny6uwfoANK2igCr5Xu8Udbhi87x/tVWllhkxZXO7GupzRICNl4ecresTJ 2wstk/qaWgll9vsNJGIZqDG0HDlEhyNRAcQZnUc+7tkqDp1NgUs6ba0GT Hy33Qqrtvl6rnajr0YHHFS/fjIw0/8JttZ+VXXWQIj4pdc4SjV1QfDyJM A==; X-IronPort-AV: E=McAfee;i="6200,9189,10257"; a="274673438" X-IronPort-AV: E=Sophos;i="5.88,368,1635231600"; d="scan'208";a="274673438" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 06:45:47 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,368,1635231600"; d="scan'208";a="485505117" Received: from silpixa00401215.ir.intel.com ([10.55.128.96]) by orsmga003.jf.intel.com with ESMTP; 14 Feb 2022 06:45:45 -0800 From: Sean Morrissey <sean.morrissey@intel.com> To: David Hunt <david.hunt@intel.com> Cc: dev@dpdk.org, Sean Morrissey <sean.morrissey@intel.com> Subject: [PATCH v8 17/50] power: remove unneeded header includes Date: Mon, 14 Feb 2022 14:43:33 +0000 Message-Id: <20220214144406.4192233-18-sean.morrissey@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220214144406.4192233-1-sean.morrissey@intel.com> References: <20220214113632.3184921-1-sean.morrissey@intel.com> <20220214144406.4192233-1-sean.morrissey@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org These header includes have been flagged by the iwyu_tool and removed. Also added rte_string_fns.h to example app vm_power_manager for users without libbsd. Signed-off-by: Sean Morrissey <sean.morrissey@intel.com> Acked-by: David Hunt <david.hunt@intel.com> --- examples/vm_power_manager/guest_cli/main.c | 1 + lib/power/guest_channel.c | 2 -- lib/power/power_acpi_cpufreq.c | 7 ------- lib/power/power_acpi_cpufreq.h | 4 ---- lib/power/power_common.h | 1 - lib/power/power_cppc_cpufreq.c | 1 - lib/power/power_cppc_cpufreq.h | 4 ---- lib/power/power_kvm_vm.c | 1 - lib/power/power_kvm_vm.h | 4 ---- lib/power/power_pstate_cpufreq.c | 6 ------ lib/power/power_pstate_cpufreq.h | 4 ---- lib/power/rte_power.c | 1 - lib/power/rte_power.h | 2 -- lib/power/rte_power_empty_poll.c | 2 -- 14 files changed, 1 insertion(+), 39 deletions(-) diff --git a/examples/vm_power_manager/guest_cli/main.c b/examples/vm_power_manager/guest_cli/main.c index b8fa65ef15..9da50020ac 100644 --- a/examples/vm_power_manager/guest_cli/main.c +++ b/examples/vm_power_manager/guest_cli/main.c @@ -13,6 +13,7 @@ #include <rte_debug.h> #include <rte_eal.h> #include <rte_log.h> +#include <rte_string_fns.h> #include "vm_power_cli_guest.h" #include "parse.h" diff --git a/lib/power/guest_channel.c b/lib/power/guest_channel.c index 474dd92998..969a9e5aaa 100644 --- a/lib/power/guest_channel.c +++ b/lib/power/guest_channel.c @@ -4,9 +4,7 @@ #include <glob.h> #include <stdio.h> -#include <stdlib.h> #include <unistd.h> -#include <signal.h> #include <limits.h> #include <fcntl.h> #include <string.h> diff --git a/lib/power/power_acpi_cpufreq.c b/lib/power/power_acpi_cpufreq.c index 402ed8c99b..6e57aca535 100644 --- a/lib/power/power_acpi_cpufreq.c +++ b/lib/power/power_acpi_cpufreq.c @@ -3,17 +3,10 @@ */ #include <stdio.h> -#include <sys/types.h> -#include <sys/stat.h> #include <fcntl.h> #include <stdlib.h> -#include <string.h> -#include <unistd.h> -#include <signal.h> -#include <limits.h> #include <rte_memcpy.h> -#include <rte_memory.h> #include <rte_string_fns.h> #include "power_acpi_cpufreq.h" diff --git a/lib/power/power_acpi_cpufreq.h b/lib/power/power_acpi_cpufreq.h index 41675b9cd9..682fd9278c 100644 --- a/lib/power/power_acpi_cpufreq.h +++ b/lib/power/power_acpi_cpufreq.h @@ -10,10 +10,6 @@ * RTE Power Management via userspace ACPI cpufreq */ -#include <rte_common.h> -#include <rte_byteorder.h> -#include <rte_log.h> -#include <rte_string_fns.h> #include "rte_power.h" /** diff --git a/lib/power/power_common.h b/lib/power/power_common.h index 0b264edfa5..c1c7139276 100644 --- a/lib/power/power_common.h +++ b/lib/power/power_common.h @@ -5,7 +5,6 @@ #ifndef _POWER_COMMON_H_ #define _POWER_COMMON_H_ -#include <inttypes.h> #include <rte_common.h> diff --git a/lib/power/power_cppc_cpufreq.c b/lib/power/power_cppc_cpufreq.c index 25185a791c..ef06fbcd9e 100644 --- a/lib/power/power_cppc_cpufreq.c +++ b/lib/power/power_cppc_cpufreq.c @@ -4,7 +4,6 @@ */ #include <rte_memcpy.h> -#include <rte_memory.h> #include "power_cppc_cpufreq.h" #include "power_common.h" diff --git a/lib/power/power_cppc_cpufreq.h b/lib/power/power_cppc_cpufreq.h index 4e73c91b05..f4121b237e 100644 --- a/lib/power/power_cppc_cpufreq.h +++ b/lib/power/power_cppc_cpufreq.h @@ -11,10 +11,6 @@ * RTE Power Management via userspace CPPC cpufreq */ -#include <rte_common.h> -#include <rte_byteorder.h> -#include <rte_log.h> -#include <rte_string_fns.h> #include "rte_power.h" /** diff --git a/lib/power/power_kvm_vm.c b/lib/power/power_kvm_vm.c index ab7d4b8cee..6a8109d449 100644 --- a/lib/power/power_kvm_vm.c +++ b/lib/power/power_kvm_vm.c @@ -9,7 +9,6 @@ #include "rte_power_guest_channel.h" #include "guest_channel.h" #include "power_kvm_vm.h" -#include "power_common.h" #define FD_PATH "/dev/virtio-ports/virtio.serial.port.poweragent" diff --git a/lib/power/power_kvm_vm.h b/lib/power/power_kvm_vm.h index 9a309a300f..303fcc041b 100644 --- a/lib/power/power_kvm_vm.h +++ b/lib/power/power_kvm_vm.h @@ -10,10 +10,6 @@ * RTE Power Management KVM VM */ -#include <rte_common.h> -#include <rte_byteorder.h> -#include <rte_log.h> -#include <rte_string_fns.h> #include "rte_power.h" /** diff --git a/lib/power/power_pstate_cpufreq.c b/lib/power/power_pstate_cpufreq.c index 86f8a76e46..f4c36179ec 100644 --- a/lib/power/power_pstate_cpufreq.c +++ b/lib/power/power_pstate_cpufreq.c @@ -3,20 +3,14 @@ */ #include <stdio.h> -#include <sys/types.h> -#include <sys/stat.h> #include <fcntl.h> -#include <stdlib.h> #include <string.h> #include <unistd.h> -#include <signal.h> #include <limits.h> #include <errno.h> #include <inttypes.h> #include <rte_memcpy.h> -#include <rte_memory.h> -#include <rte_string_fns.h> #include "power_pstate_cpufreq.h" #include "power_common.h" diff --git a/lib/power/power_pstate_cpufreq.h b/lib/power/power_pstate_cpufreq.h index 3260b32494..7bf64a518c 100644 --- a/lib/power/power_pstate_cpufreq.h +++ b/lib/power/power_pstate_cpufreq.h @@ -10,10 +10,6 @@ * RTE Power Management via Intel Pstate driver */ -#include <rte_common.h> -#include <rte_byteorder.h> -#include <rte_log.h> -#include <rte_string_fns.h> #include "rte_power.h" /** diff --git a/lib/power/rte_power.c b/lib/power/rte_power.c index 3cba56bac9..0a6614be77 100644 --- a/lib/power/rte_power.c +++ b/lib/power/rte_power.c @@ -10,7 +10,6 @@ #include "power_cppc_cpufreq.h" #include "power_kvm_vm.h" #include "power_pstate_cpufreq.h" -#include "power_common.h" enum power_management_env global_default_env = PM_ENV_NOT_SET; diff --git a/lib/power/rte_power.h b/lib/power/rte_power.h index c5759afa39..47345e26df 100644 --- a/lib/power/rte_power.h +++ b/lib/power/rte_power.h @@ -11,9 +11,7 @@ */ #include <rte_common.h> -#include <rte_byteorder.h> #include <rte_log.h> -#include <rte_string_fns.h> #include <rte_power_guest_channel.h> #ifdef __cplusplus diff --git a/lib/power/rte_power_empty_poll.c b/lib/power/rte_power_empty_poll.c index 2261ce7820..4a4db51247 100644 --- a/lib/power/rte_power_empty_poll.c +++ b/lib/power/rte_power_empty_poll.c @@ -5,8 +5,6 @@ #include <string.h> #include <rte_lcore.h> -#include <rte_cycles.h> -#include <rte_atomic.h> #include <rte_malloc.h> #include <inttypes.h> -- 2.25.1