* [PATCH] eventdev/eth_rx: fix queue config get API
@ 2022-02-09 5:09 Naga Harish K S V
2022-02-14 15:28 ` Jerin Jacob
2022-02-14 17:10 ` [PATCH v2] eventdev/eth_rx: fix queue config get logic Naga Harish K S V
0 siblings, 2 replies; 7+ messages in thread
From: Naga Harish K S V @ 2022-02-09 5:09 UTC (permalink / raw)
To: jay.jayatheerthan, jerinj; +Cc: dev
the memcpy size used in queue config get function is more than
the source size. Use correct size to avoid copy of unnecessary
data.
Fixes: da781e6488 ("eventdev/eth_rx: support Rx queue config get")
Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com>
---
lib/eventdev/rte_event_eth_rx_adapter.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
index ae1e260c08..e44499e887 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -3238,7 +3238,7 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id,
RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID;
queue_conf->servicing_weight = queue_info->wt;
- memcpy(&queue_conf->ev, qi_ev, sizeof(*qi_ev));
+ memcpy(&queue_conf->ev, qi_ev, sizeof(queue_info->event));
dev = &rte_eventdevs[rx_adapter->eventdev_id];
if (dev->dev_ops->eth_rx_adapter_queue_conf_get != NULL) {
--
2.23.0
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [PATCH] eventdev/eth_rx: fix queue config get API 2022-02-09 5:09 [PATCH] eventdev/eth_rx: fix queue config get API Naga Harish K S V @ 2022-02-14 15:28 ` Jerin Jacob 2022-02-14 17:09 ` Jayatheerthan, Jay 2022-02-14 17:10 ` [PATCH v2] eventdev/eth_rx: fix queue config get logic Naga Harish K S V 1 sibling, 1 reply; 7+ messages in thread From: Jerin Jacob @ 2022-02-14 15:28 UTC (permalink / raw) To: Naga Harish K S V; +Cc: Jayatheerthan, Jay, Jerin Jacob, dpdk-dev On Wed, Feb 9, 2022 at 10:40 AM Naga Harish K S V <s.v.naga.harish.k@intel.com> wrote: > > the memcpy size used in queue config get function is more than > the source size. Use correct size to avoid copy of unnecessary > data. > > Fixes: da781e6488 ("eventdev/eth_rx: support Rx queue config get") > > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com> Hi @Jayatheerthan, Jay Could you review it? > --- > lib/eventdev/rte_event_eth_rx_adapter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c > index ae1e260c08..e44499e887 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -3238,7 +3238,7 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, > RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID; > queue_conf->servicing_weight = queue_info->wt; > > - memcpy(&queue_conf->ev, qi_ev, sizeof(*qi_ev)); > + memcpy(&queue_conf->ev, qi_ev, sizeof(queue_info->event)); > > dev = &rte_eventdevs[rx_adapter->eventdev_id]; > if (dev->dev_ops->eth_rx_adapter_queue_conf_get != NULL) { > -- > 2.23.0 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] eventdev/eth_rx: fix queue config get API 2022-02-14 15:28 ` Jerin Jacob @ 2022-02-14 17:09 ` Jayatheerthan, Jay 2022-02-14 17:13 ` Naga Harish K, S V 0 siblings, 1 reply; 7+ messages in thread From: Jayatheerthan, Jay @ 2022-02-14 17:09 UTC (permalink / raw) To: Jerin Jacob, Naga Harish K, S V; +Cc: Jerin Jacob, dpdk-dev Hi Harish, > -----Original Message----- > From: Jerin Jacob <jerinjacobk@gmail.com> > Sent: Monday, February 14, 2022 8:59 PM > To: Naga Harish K, S V <s.v.naga.harish.k@intel.com> > Cc: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Jerin Jacob <jerinj@marvell.com>; dpdk-dev <dev@dpdk.org> > Subject: Re: [PATCH] eventdev/eth_rx: fix queue config get API > > On Wed, Feb 9, 2022 at 10:40 AM Naga Harish K S V > <s.v.naga.harish.k@intel.com> wrote: > > > > the memcpy size used in queue config get function is more than > > the source size. Use correct size to avoid copy of unnecessary > > data. > > > > Fixes: da781e6488 ("eventdev/eth_rx: support Rx queue config get") > > > > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com> > > Hi @Jayatheerthan, Jay > > Could you review it? > > > > --- > > lib/eventdev/rte_event_eth_rx_adapter.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c > > index ae1e260c08..e44499e887 100644 > > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > > @@ -3238,7 +3238,7 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, > > RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID; > > queue_conf->servicing_weight = queue_info->wt; > > > > - memcpy(&queue_conf->ev, qi_ev, sizeof(*qi_ev)); > > + memcpy(&queue_conf->ev, qi_ev, sizeof(queue_info->event)); Why do we need to assign queue_info->event to qi_ev and then copy it to queue_conf->ev ? We should be able to do straight copy from queue_info->event to queue_conf->ev. > > > > dev = &rte_eventdevs[rx_adapter->eventdev_id]; > > if (dev->dev_ops->eth_rx_adapter_queue_conf_get != NULL) { > > -- > > 2.23.0 > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH] eventdev/eth_rx: fix queue config get API 2022-02-14 17:09 ` Jayatheerthan, Jay @ 2022-02-14 17:13 ` Naga Harish K, S V 0 siblings, 0 replies; 7+ messages in thread From: Naga Harish K, S V @ 2022-02-14 17:13 UTC (permalink / raw) To: Jayatheerthan, Jay, Jerin Jacob; +Cc: Jerin Jacob, dpdk-dev Hi Jay, > -----Original Message----- > From: Jayatheerthan, Jay <jay.jayatheerthan@intel.com> > Sent: Monday, February 14, 2022 10:39 PM > To: Jerin Jacob <jerinjacobk@gmail.com>; Naga Harish K, S V > <s.v.naga.harish.k@intel.com> > Cc: Jerin Jacob <jerinj@marvell.com>; dpdk-dev <dev@dpdk.org> > Subject: RE: [PATCH] eventdev/eth_rx: fix queue config get API > > Hi Harish, > > > -----Original Message----- > > From: Jerin Jacob <jerinjacobk@gmail.com> > > Sent: Monday, February 14, 2022 8:59 PM > > To: Naga Harish K, S V <s.v.naga.harish.k@intel.com> > > Cc: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; Jerin Jacob > > <jerinj@marvell.com>; dpdk-dev <dev@dpdk.org> > > Subject: Re: [PATCH] eventdev/eth_rx: fix queue config get API > > > > On Wed, Feb 9, 2022 at 10:40 AM Naga Harish K S V > > <s.v.naga.harish.k@intel.com> wrote: > > > > > > the memcpy size used in queue config get function is more than the > > > source size. Use correct size to avoid copy of unnecessary data. > > > > > > Fixes: da781e6488 ("eventdev/eth_rx: support Rx queue config get") > > > > > > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com> > > > > Hi @Jayatheerthan, Jay > > > > Could you review it? > > > > > > > --- > > > lib/eventdev/rte_event_eth_rx_adapter.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c > > > b/lib/eventdev/rte_event_eth_rx_adapter.c > > > index ae1e260c08..e44499e887 100644 > > > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > > > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > > > @@ -3238,7 +3238,7 @@ > rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, > > > RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID; > > > queue_conf->servicing_weight = queue_info->wt; > > > > > > - memcpy(&queue_conf->ev, qi_ev, sizeof(*qi_ev)); > > > + memcpy(&queue_conf->ev, qi_ev, sizeof(queue_info->event)); > > Why do we need to assign queue_info->event to qi_ev and then copy it to > queue_conf->ev ? We should be able to do straight copy from queue_info- > >event to queue_conf->ev. > Updated in v2 patch. Also added vector data and queue event buffer size. > > > > > > dev = &rte_eventdevs[rx_adapter->eventdev_id]; > > > if (dev->dev_ops->eth_rx_adapter_queue_conf_get != NULL) { > > > -- > > > 2.23.0 > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH v2] eventdev/eth_rx: fix queue config get logic 2022-02-09 5:09 [PATCH] eventdev/eth_rx: fix queue config get API Naga Harish K S V 2022-02-14 15:28 ` Jerin Jacob @ 2022-02-14 17:10 ` Naga Harish K S V 2022-02-15 16:54 ` Jayatheerthan, Jay 1 sibling, 1 reply; 7+ messages in thread From: Naga Harish K S V @ 2022-02-14 17:10 UTC (permalink / raw) To: jay.jayatheerthan, jerinj; +Cc: dev remove the memcpy usage in queue config get function for `event` variable which is 8 byte size and use direct copy. Also provide vector information and event buffer size in the queue config info. Fixes: da781e6488 ("eventdev/eth_rx: support Rx queue config get") Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com> --- v2: * remove memcpy usage also provide vector data and event buffer size info --- lib/eventdev/rte_event_eth_rx_adapter.c | 16 +++++++++++++--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index ae1e260c08..28388d3abb 100644 --- a/lib/eventdev/rte_event_eth_rx_adapter.c +++ b/lib/eventdev/rte_event_eth_rx_adapter.c @@ -3194,11 +3194,11 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, uint16_t rx_queue_id, struct rte_event_eth_rx_adapter_queue_conf *queue_conf) { +#define TICK2NSEC(_ticks, _freq) (((_ticks) * (1E9)) / (_freq)) struct rte_eventdev *dev; struct event_eth_rx_adapter *rx_adapter; struct eth_device_info *dev_info; struct eth_rx_queue_info *queue_info; - struct rte_event *qi_ev; int ret; if (rxa_memzone_lookup()) @@ -3229,7 +3229,6 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, } queue_info = &dev_info->rx_queue[rx_queue_id]; - qi_ev = (struct rte_event *)&queue_info->event; memset(queue_conf, 0, sizeof(*queue_conf)); queue_conf->rx_queue_flags = 0; @@ -3238,7 +3237,18 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID; queue_conf->servicing_weight = queue_info->wt; - memcpy(&queue_conf->ev, qi_ev, sizeof(*qi_ev)); + queue_conf->ev.event = queue_info->event; + + queue_conf->vector_sz = queue_info->vector_data.max_vector_count; + queue_conf->vector_mp = queue_info->vector_data.vector_pool; + /* need to be converted from ticks to ns */ + queue_conf->vector_timeout_ns = TICK2NSEC( + queue_info->vector_data.vector_timeout_ticks, rte_get_timer_hz()); + + if (queue_info->event_buf != NULL) + queue_conf->event_buf_size = queue_info->event_buf->events_size; + else + queue_conf->event_buf_size = 0; dev = &rte_eventdevs[rx_adapter->eventdev_id]; if (dev->dev_ops->eth_rx_adapter_queue_conf_get != NULL) { -- 2.23.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH v2] eventdev/eth_rx: fix queue config get logic 2022-02-14 17:10 ` [PATCH v2] eventdev/eth_rx: fix queue config get logic Naga Harish K S V @ 2022-02-15 16:54 ` Jayatheerthan, Jay 2022-02-18 13:57 ` Jerin Jacob 0 siblings, 1 reply; 7+ messages in thread From: Jayatheerthan, Jay @ 2022-02-15 16:54 UTC (permalink / raw) To: Naga Harish K, S V, jerinj; +Cc: dev Looks good. Thanks! Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com> -Jay > -----Original Message----- > From: Naga Harish K, S V <s.v.naga.harish.k@intel.com> > Sent: Monday, February 14, 2022 10:40 PM > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; jerinj@marvell.com > Cc: dev@dpdk.org > Subject: [PATCH v2] eventdev/eth_rx: fix queue config get logic > > remove the memcpy usage in queue config get function for > `event` variable which is 8 byte size and use direct copy. > Also provide vector information and event buffer size in the > queue config info. > > Fixes: da781e6488 ("eventdev/eth_rx: support Rx queue config get") > > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com> > --- > v2: > * remove memcpy usage > also provide vector data and event buffer size info > --- > lib/eventdev/rte_event_eth_rx_adapter.c | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c > index ae1e260c08..28388d3abb 100644 > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > @@ -3194,11 +3194,11 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, > uint16_t rx_queue_id, > struct rte_event_eth_rx_adapter_queue_conf *queue_conf) > { > +#define TICK2NSEC(_ticks, _freq) (((_ticks) * (1E9)) / (_freq)) > struct rte_eventdev *dev; > struct event_eth_rx_adapter *rx_adapter; > struct eth_device_info *dev_info; > struct eth_rx_queue_info *queue_info; > - struct rte_event *qi_ev; > int ret; > > if (rxa_memzone_lookup()) > @@ -3229,7 +3229,6 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, > } > > queue_info = &dev_info->rx_queue[rx_queue_id]; > - qi_ev = (struct rte_event *)&queue_info->event; > > memset(queue_conf, 0, sizeof(*queue_conf)); > queue_conf->rx_queue_flags = 0; > @@ -3238,7 +3237,18 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, > RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID; > queue_conf->servicing_weight = queue_info->wt; > > - memcpy(&queue_conf->ev, qi_ev, sizeof(*qi_ev)); > + queue_conf->ev.event = queue_info->event; > + > + queue_conf->vector_sz = queue_info->vector_data.max_vector_count; > + queue_conf->vector_mp = queue_info->vector_data.vector_pool; > + /* need to be converted from ticks to ns */ > + queue_conf->vector_timeout_ns = TICK2NSEC( > + queue_info->vector_data.vector_timeout_ticks, rte_get_timer_hz()); > + > + if (queue_info->event_buf != NULL) > + queue_conf->event_buf_size = queue_info->event_buf->events_size; > + else > + queue_conf->event_buf_size = 0; > > dev = &rte_eventdevs[rx_adapter->eventdev_id]; > if (dev->dev_ops->eth_rx_adapter_queue_conf_get != NULL) { > -- > 2.23.0 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH v2] eventdev/eth_rx: fix queue config get logic 2022-02-15 16:54 ` Jayatheerthan, Jay @ 2022-02-18 13:57 ` Jerin Jacob 0 siblings, 0 replies; 7+ messages in thread From: Jerin Jacob @ 2022-02-18 13:57 UTC (permalink / raw) To: Jayatheerthan, Jay; +Cc: Naga Harish K, S V, jerinj, dev On Tue, Feb 15, 2022 at 10:24 PM Jayatheerthan, Jay <jay.jayatheerthan@intel.com> wrote: > > Looks good. Thanks! > > Acked-by: Jay Jayatheerthan <jay.jayatheerthan@intel.com> Applied to dpdk-next-net-eventdev/for-main. Thanks > -Jay > > > > > -----Original Message----- > > From: Naga Harish K, S V <s.v.naga.harish.k@intel.com> > > Sent: Monday, February 14, 2022 10:40 PM > > To: Jayatheerthan, Jay <jay.jayatheerthan@intel.com>; jerinj@marvell.com > > Cc: dev@dpdk.org > > Subject: [PATCH v2] eventdev/eth_rx: fix queue config get logic > > > > remove the memcpy usage in queue config get function for > > `event` variable which is 8 byte size and use direct copy. > > Also provide vector information and event buffer size in the > > queue config info. > > > > Fixes: da781e6488 ("eventdev/eth_rx: support Rx queue config get") > > > > Signed-off-by: Naga Harish K S V <s.v.naga.harish.k@intel.com> > > --- > > v2: > > * remove memcpy usage > > also provide vector data and event buffer size info > > --- > > lib/eventdev/rte_event_eth_rx_adapter.c | 16 +++++++++++++--- > > 1 file changed, 13 insertions(+), 3 deletions(-) > > > > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c > > index ae1e260c08..28388d3abb 100644 > > --- a/lib/eventdev/rte_event_eth_rx_adapter.c > > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c > > @@ -3194,11 +3194,11 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, > > uint16_t rx_queue_id, > > struct rte_event_eth_rx_adapter_queue_conf *queue_conf) > > { > > +#define TICK2NSEC(_ticks, _freq) (((_ticks) * (1E9)) / (_freq)) > > struct rte_eventdev *dev; > > struct event_eth_rx_adapter *rx_adapter; > > struct eth_device_info *dev_info; > > struct eth_rx_queue_info *queue_info; > > - struct rte_event *qi_ev; > > int ret; > > > > if (rxa_memzone_lookup()) > > @@ -3229,7 +3229,6 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, > > } > > > > queue_info = &dev_info->rx_queue[rx_queue_id]; > > - qi_ev = (struct rte_event *)&queue_info->event; > > > > memset(queue_conf, 0, sizeof(*queue_conf)); > > queue_conf->rx_queue_flags = 0; > > @@ -3238,7 +3237,18 @@ rte_event_eth_rx_adapter_queue_conf_get(uint8_t id, > > RTE_EVENT_ETH_RX_ADAPTER_QUEUE_FLOW_ID_VALID; > > queue_conf->servicing_weight = queue_info->wt; > > > > - memcpy(&queue_conf->ev, qi_ev, sizeof(*qi_ev)); > > + queue_conf->ev.event = queue_info->event; > > + > > + queue_conf->vector_sz = queue_info->vector_data.max_vector_count; > > + queue_conf->vector_mp = queue_info->vector_data.vector_pool; > > + /* need to be converted from ticks to ns */ > > + queue_conf->vector_timeout_ns = TICK2NSEC( > > + queue_info->vector_data.vector_timeout_ticks, rte_get_timer_hz()); > > + > > + if (queue_info->event_buf != NULL) > > + queue_conf->event_buf_size = queue_info->event_buf->events_size; > > + else > > + queue_conf->event_buf_size = 0; > > > > dev = &rte_eventdevs[rx_adapter->eventdev_id]; > > if (dev->dev_ops->eth_rx_adapter_queue_conf_get != NULL) { > > -- > > 2.23.0 > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-02-18 13:57 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2022-02-09 5:09 [PATCH] eventdev/eth_rx: fix queue config get API Naga Harish K S V 2022-02-14 15:28 ` Jerin Jacob 2022-02-14 17:09 ` Jayatheerthan, Jay 2022-02-14 17:13 ` Naga Harish K, S V 2022-02-14 17:10 ` [PATCH v2] eventdev/eth_rx: fix queue config get logic Naga Harish K S V 2022-02-15 16:54 ` Jayatheerthan, Jay 2022-02-18 13:57 ` Jerin Jacob
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).