DPDK patches and discussions
 help / color / mirror / Atom feed
From: Peng Yu <penyu@amazon.com>
To: <dev@dpdk.org>
Cc: Peng Yu <penyu@amazon.com>, Ray Kinsella <mdr@ashroe.eu>,
	Maxime Coquelin <maxime.coquelin@redhat.com>,
	Chenbo Xia <chenbo.xia@intel.com>
Subject: [PATCH] vhost: use colon in version.map
Date: Tue, 15 Feb 2022 05:55:52 +0000	[thread overview]
Message-ID: <20220215055552.16656-1-penyu@amazon.com> (raw)

The punctuation after the `global` keyword should be colon, not
semicolon. The default gcc linker accepts both colon and semicolon, but
the gold linker will report syntax error if we use semicolon after the
`global` keyword.

Signed-off-by: Peng Yu <penyu@amazon.com>
---
 lib/vhost/version.map | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/vhost/version.map b/lib/vhost/version.map
index 1202ba9c1a..0a66c5840c 100644
--- a/lib/vhost/version.map
+++ b/lib/vhost/version.map
@@ -90,7 +90,7 @@ EXPERIMENTAL {
 };
 
 INTERNAL {
-	global;
+	global:
 
 	rte_vdpa_register_device;
 	rte_vdpa_relay_vring_used;
-- 
2.16.6


             reply	other threads:[~2022-02-15  5:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-15  5:55 Peng Yu [this message]
2022-03-03 11:32 ` Xia, Chenbo
2022-03-04 13:57   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220215055552.16656-1-penyu@amazon.com \
    --to=penyu@amazon.com \
    --cc=chenbo.xia@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=mdr@ashroe.eu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).