From: spinler@cesnet.cz
To: dev@dpdk.org
Cc: Martin Spinler <spinler@cesnet.cz>, cernay@netcope.com, stable@dpdk.org
Subject: [PATCH v2 1/5] net/nfb: fix array indexes in deinit functions
Date: Tue, 15 Feb 2022 13:55:39 +0100 [thread overview]
Message-ID: <20220215125543.142108-2-spinler@cesnet.cz> (raw)
In-Reply-To: <20220215125543.142108-1-spinler@cesnet.cz>
From: Martin Spinler <spinler@cesnet.cz>
The indexes in the for cycle were wrongly used and
the code accessed outside of the rxmac/txmac array.
Fixes: 6435f9a0ac22 ("net/nfb: add new netcope driver")
Cc: cernay@netcope.com
Cc: stable@dpdk.org
Signed-off-by: Martin Spinler <spinler@cesnet.cz>
---
drivers/net/nfb/nfb_ethdev.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/drivers/net/nfb/nfb_ethdev.c b/drivers/net/nfb/nfb_ethdev.c
index 3c39937816..0b27fe78cc 100644
--- a/drivers/net/nfb/nfb_ethdev.c
+++ b/drivers/net/nfb/nfb_ethdev.c
@@ -77,9 +77,10 @@ static void
nfb_nc_rxmac_deinit(struct nc_rxmac *rxmac[RTE_MAX_NC_RXMAC],
uint16_t max_rxmac)
{
- for (; max_rxmac > 0; --max_rxmac) {
- nc_rxmac_close(rxmac[max_rxmac]);
- rxmac[max_rxmac] = NULL;
+ uint16_t i;
+ for (i = 0; i < max_rxmac; i++) {
+ nc_rxmac_close(rxmac[i]);
+ rxmac[i] = NULL;
}
}
@@ -95,9 +96,10 @@ static void
nfb_nc_txmac_deinit(struct nc_txmac *txmac[RTE_MAX_NC_TXMAC],
uint16_t max_txmac)
{
- for (; max_txmac > 0; --max_txmac) {
- nc_txmac_close(txmac[max_txmac]);
- txmac[max_txmac] = NULL;
+ uint16_t i;
+ for (i = 0; i < max_txmac; i++) {
+ nc_txmac_close(txmac[i]);
+ txmac[i] = NULL;
}
}
--
2.35.1
next prev parent reply other threads:[~2022-02-15 12:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-14 11:25 [PATCH 1/6] net/nfb: add missing libfdt dependency for build spinler
2022-02-14 11:25 ` [PATCH 2/6] drivers/nfb: fix array indexes in deinit functions spinler
2022-02-14 13:34 ` Ferruh Yigit
2022-02-14 16:52 ` Martin Spinler
2022-02-14 11:25 ` [PATCH 3/6] drivers/nfb: do not report zero-sized TX burst spinler
2022-02-14 13:35 ` Ferruh Yigit
2022-02-14 16:53 ` Martin Spinler
2022-02-14 17:34 ` Ferruh Yigit
2022-02-14 11:25 ` [PATCH 4/6] drivers/nfb: use RTE_ETH_RX_OFFLOAD_TIMESTAMP flag spinler
2022-02-14 11:25 ` [PATCH 5/6] drivers/nfb: fix multicast/promiscuous mode switching spinler
2022-02-14 13:36 ` Ferruh Yigit
2022-02-14 16:53 ` Martin Spinler
2022-02-14 11:25 ` [PATCH 6/6] drivers/nfb: add support for more MAC addresses spinler
2022-02-14 13:37 ` Ferruh Yigit
2022-02-14 16:53 ` Martin Spinler
2022-02-14 17:54 ` Ferruh Yigit
2022-02-15 13:02 ` Martin Spinler
2022-02-14 13:36 ` [PATCH 1/6] net/nfb: add missing libfdt dependency for build Ferruh Yigit
2022-02-14 16:53 ` Martin Spinler
2022-02-15 12:55 ` [PATCH v2 0/5] " spinler
2022-02-15 12:55 ` spinler [this message]
2022-02-15 12:55 ` [PATCH v2 2/5] net/nfb: do not report zero-sized TX burst spinler
2022-02-15 12:55 ` [PATCH v2 3/5] net/nfb: use RTE_ETH_RX_OFFLOAD_TIMESTAMP flag spinler
2022-02-15 12:55 ` [PATCH v2 4/5] net/nfb: fix multicast/promiscuous mode switching spinler
2022-02-15 12:55 ` [PATCH v2 5/5] net/nfb: add support for more MAC addresses spinler
2022-02-15 13:55 ` [PATCH v2 0/5] net/nfb: add missing libfdt dependency for build Ferruh Yigit
2022-02-15 13:57 ` Martin Spinler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220215125543.142108-2-spinler@cesnet.cz \
--to=spinler@cesnet.cz \
--cc=cernay@netcope.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).