From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 788EBA00BE; Wed, 16 Feb 2022 20:39:09 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 490E140150; Wed, 16 Feb 2022 20:39:09 +0100 (CET) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id D402C40042 for ; Wed, 16 Feb 2022 20:39:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645040348; x=1676576348; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=OX4o2nOqeVgiSEbrnRQTghQpT77EG1tnP/6clr5U/MQ=; b=HGyXwDmz5Eo7FxM8kkFtccgUo/2qsLS03X/2R0HnhFKu9WefyPhn/Tt/ Y1ZPeSFkdLoLPmvS/nyhnj165gYhl5ggA7eA/AGGy9C0N6NLUqyeu/Lsi Vt8Hk5cV6sIs2Q+uIFUPowxe5MeVrwp4leQzlLLWA0gRg7XL5c3Km4y5R G0oXm2WZNqb4wU5kkjzQC9WSi4+NHpPzMCi3a1eHuVCbK40Ea5HR3eVEH P7ZncDWS2Rzm6uVZUwLWapufrf7+kAGkJxy/vIzrmyCJOCNbjAAK6m9rc 6kXvUINU/j2A52NvrQ1wp8fNLk8Ywv9jvfbyq8nHtcaY4lYsv6vX/K0R3 Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10260"; a="275291075" X-IronPort-AV: E=Sophos;i="5.88,374,1635231600"; d="scan'208";a="275291075" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Feb 2022 11:38:35 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,374,1635231600"; d="scan'208";a="545132584" Received: from txanpdk03.an.intel.com ([10.123.117.78]) by orsmga008.jf.intel.com with ESMTP; 16 Feb 2022 11:38:33 -0800 From: Timothy McDaniel To: jerin.jacob@caviumnetworks.com Cc: dev@dpdk.org Subject: [PATCH 1/2] event/dlb2: update rolling mask used for dequeue Date: Wed, 16 Feb 2022 13:38:26 -0600 Message-Id: <20220216193827.2908858-1-timothy.mcdaniel@intel.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Update the rolling mask used in dequeue operations. Fixes vector optimized dequeue. Fixes: 000a7b8e7582 ("event/dlb2: optimize dequeue operation") Signed-off-by: Timothy McDaniel --- drivers/event/dlb2/dlb2.c | 28 +++++++++++++++++++++------- 1 file changed, 21 insertions(+), 7 deletions(-) diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index d75f12e382..09abdd1660 100644 --- a/drivers/event/dlb2/dlb2.c +++ b/drivers/event/dlb2/dlb2.c @@ -3897,31 +3897,45 @@ dlb2_hw_dequeue_sparse(struct dlb2_eventdev *dlb2, while (num < max_num) { struct dlb2_dequeue_qe qes[DLB2_NUM_QES_PER_CACHE_LINE]; int num_avail; + if (use_scalar) { + int n_iter = 0; + uint64_t m_rshift, m_lshift, m2_rshift, m2_lshift; + num_avail = dlb2_recv_qe_sparse(qm_port, qes); num_avail = RTE_MIN(num_avail, max_num - num); dlb2_inc_cq_idx(qm_port, num_avail << 2); if (num_avail == DLB2_NUM_QES_PER_CACHE_LINE) - num += dlb2_process_dequeue_four_qes(ev_port, - qm_port, - &events[num], - &qes[0]); + n_iter = dlb2_process_dequeue_four_qes(ev_port, + qm_port, + &events[num], + &qes[0]); else if (num_avail) - num += dlb2_process_dequeue_qes(ev_port, + n_iter = dlb2_process_dequeue_qes(ev_port, qm_port, &events[num], &qes[0], num_avail); + num += n_iter; + /* update rolling_mask for vector code support */ + m_rshift = qm_port->cq_rolling_mask >> n_iter; + m_lshift = qm_port->cq_rolling_mask << (64 - n_iter); + m2_rshift = qm_port->cq_rolling_mask_2 >> n_iter; + m2_lshift = qm_port->cq_rolling_mask_2 << + (64 - n_iter); + qm_port->cq_rolling_mask = (m_rshift | m2_lshift); + qm_port->cq_rolling_mask_2 = (m2_rshift | m_lshift); } else { /* !use_scalar */ num_avail = dlb2_recv_qe_sparse_vec(qm_port, &events[num], max_num - num); - num += num_avail; dlb2_inc_cq_idx(qm_port, num_avail << 2); + num += num_avail; DLB2_INC_STAT(ev_port->stats.traffic.rx_ok, num_avail); } if (!num_avail) { - if (num > 0) + if ((timeout == 0) || (num > 0)) + /* Not waiting in any form or 1+ events recd */ break; else if (dlb2_dequeue_wait(dlb2, ev_port, qm_port, timeout, start_ticks)) -- 2.23.0