DPDK patches and discussions
 help / color / mirror / Atom feed
* [PATCH] examples/vhost: delete DMA type parameter help info
@ 2022-02-17  3:24 Chengwen Feng
  2022-02-17  7:41 ` Xia, Chenbo
  2022-02-17  8:55 ` Maxime Coquelin
  0 siblings, 2 replies; 3+ messages in thread
From: Chengwen Feng @ 2022-02-17  3:24 UTC (permalink / raw)
  To: thomas; +Cc: dev, maxime.coquelin, chenbo.xia

The dma-type parameter was not support when integrate dmadev in vhost,
but the help info still exist, this patch deletes it.

Fixes: 53d3f4778c1d ("vhost: integrate dmadev in asynchronous data-path")

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
---
 examples/vhost/main.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/examples/vhost/main.c b/examples/vhost/main.c
index 3e784f5c6f..68afd398bb 100644
--- a/examples/vhost/main.c
+++ b/examples/vhost/main.c
@@ -608,7 +608,6 @@ us_vhost_usage(const char *prgname)
 	"		--tx-csum [0|1] disable/enable TX checksum offload.\n"
 	"		--tso [0|1] disable/enable TCP segment offload.\n"
 	"		--client register a vhost-user socket as client mode.\n"
-	"		--dma-type register dma type for your vhost async driver. For example \"ioat\" for now.\n"
 	"		--dmas register dma channel for specific vhost device.\n",
 	       prgname);
 }
-- 
2.33.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [PATCH] examples/vhost: delete DMA type parameter help info
  2022-02-17  3:24 [PATCH] examples/vhost: delete DMA type parameter help info Chengwen Feng
@ 2022-02-17  7:41 ` Xia, Chenbo
  2022-02-17  8:55 ` Maxime Coquelin
  1 sibling, 0 replies; 3+ messages in thread
From: Xia, Chenbo @ 2022-02-17  7:41 UTC (permalink / raw)
  To: Chengwen Feng, thomas; +Cc: dev, maxime.coquelin

> -----Original Message-----
> From: Chengwen Feng <fengchengwen@huawei.com>
> Sent: Thursday, February 17, 2022 11:25 AM
> To: thomas@monjalon.net
> Cc: dev@dpdk.org; maxime.coquelin@redhat.com; Xia, Chenbo
> <chenbo.xia@intel.com>
> Subject: [PATCH] examples/vhost: delete DMA type parameter help info
> 
> The dma-type parameter was not support when integrate dmadev in vhost,

Supported when dmadev was integrated

> but the help info still exist, this patch deletes it.

Exists. And no need to send V2, will fix when applying

With above fixed:

Reviewed-by: Chenbo Xia <chenbo.xia@intel.com>

> 
> Fixes: 53d3f4778c1d ("vhost: integrate dmadev in asynchronous data-path")
> 
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> ---
>  examples/vhost/main.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index 3e784f5c6f..68afd398bb 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -608,7 +608,6 @@ us_vhost_usage(const char *prgname)
>  	"		--tx-csum [0|1] disable/enable TX checksum offload.\n"
>  	"		--tso [0|1] disable/enable TCP segment offload.\n"
>  	"		--client register a vhost-user socket as client mode.\n"
> -	"		--dma-type register dma type for your vhost async driver.
> For example \"ioat\" for now.\n"
>  	"		--dmas register dma channel for specific vhost device.\n",
>  	       prgname);
>  }
> --
> 2.33.0


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] examples/vhost: delete DMA type parameter help info
  2022-02-17  3:24 [PATCH] examples/vhost: delete DMA type parameter help info Chengwen Feng
  2022-02-17  7:41 ` Xia, Chenbo
@ 2022-02-17  8:55 ` Maxime Coquelin
  1 sibling, 0 replies; 3+ messages in thread
From: Maxime Coquelin @ 2022-02-17  8:55 UTC (permalink / raw)
  To: Chengwen Feng, thomas; +Cc: dev, chenbo.xia



On 2/17/22 04:24, Chengwen Feng wrote:
> The dma-type parameter was not support when integrate dmadev in vhost,
> but the help info still exist, this patch deletes it.
> 
> Fixes: 53d3f4778c1d ("vhost: integrate dmadev in asynchronous data-path")
> 
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> ---
>   examples/vhost/main.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/examples/vhost/main.c b/examples/vhost/main.c
> index 3e784f5c6f..68afd398bb 100644
> --- a/examples/vhost/main.c
> +++ b/examples/vhost/main.c
> @@ -608,7 +608,6 @@ us_vhost_usage(const char *prgname)
>   	"		--tx-csum [0|1] disable/enable TX checksum offload.\n"
>   	"		--tso [0|1] disable/enable TCP segment offload.\n"
>   	"		--client register a vhost-user socket as client mode.\n"
> -	"		--dma-type register dma type for your vhost async driver. For example \"ioat\" for now.\n"
>   	"		--dmas register dma channel for specific vhost device.\n",
>   	       prgname);
>   }

Applied to dpdk-next-virtio/main.

Thanks,
Maxime


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-02-17  8:55 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-17  3:24 [PATCH] examples/vhost: delete DMA type parameter help info Chengwen Feng
2022-02-17  7:41 ` Xia, Chenbo
2022-02-17  8:55 ` Maxime Coquelin

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).