DPDK patches and discussions
 help / color / mirror / Atom feed
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	Stephen Hemminger <stephen@networkplumber.org>,
	dev@dpdk.org
Subject: Re: [RFC 0/2] Eliminate zero length arrays in DPDK
Date: Thu, 17 Feb 2022 00:32:05 -0800	[thread overview]
Message-ID: <20220217083205.GE1815@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <000501d82321$7a92cd24$0a04a8c0@smartsharesys.local>

On Wed, Feb 16, 2022 at 11:39:30AM +0100, Morten Brørup wrote:
> My answer is at the end.Sent from a smartphone. Please pardon brevity and spelling.

> I am therefore wondering if we needto have our public headers C90-compliant?/BruceWe are publicly using C11 for atomics [1]. I'm not sure if that also implies that we are requiring C11 generally. Otherwise,  I agree with your concerns about old code bases. [1]https://www.dpdk.org/blog/2021/03/26/dpdk-adopts-the-c11-memory-model

we aren't actually using C11 atomics. we are using gcc builtin atomics
that follow the C11 memory model for accessing atomics.

so strictly speaking we don't need to make the minimum a C11 compiler.

i suspect a lot of pushback would occur if we made C11 a minimum.  so
for atomics i would make the suggestion that we abstract atomics to
permit C11 atomics to be used when a C11 compiler with stdatomic is
available.

  reply	other threads:[~2022-02-17  8:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-16 10:39 Morten Brørup
2022-02-17  8:32 ` Tyler Retzlaff [this message]
  -- strict thread matches above, loose matches on Subject: below --
2022-02-15 23:00 Stephen Hemminger
2022-02-16  9:27 ` Morten Brørup
2022-02-16  9:33 ` Bruce Richardson
2022-02-16 10:05   ` Morten Brørup
2022-02-16 10:10     ` Bruce Richardson
2022-02-17  7:41       ` Tyler Retzlaff
2022-02-24 21:51         ` Morten Brørup
2022-02-24 23:03           ` Stephen Hemminger
2022-02-16 18:56   ` Stephen Hemminger
2022-02-17  8:09 ` Tyler Retzlaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220217083205.GE1815@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
    --to=roretzla@linux.microsoft.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=mb@smartsharesystems.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).