From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
To: dev@dpdk.org
Cc: gakhil@marvell.com, roy.fan.zhang@intel.com, mdr@ashroe.eu,
Arek Kusztal <arkadiuszx.kusztal@intel.com>
Subject: [PATCH v2] crypto: fix misspelled key in qt format
Date: Fri, 18 Feb 2022 07:53:32 +0000 [thread overview]
Message-ID: <20220218075332.18916-1-arkadiuszx.kusztal@intel.com> (raw)
This patch fixes misspelled RTE_RSA_KEY_TYPE_QT,
this will prevent checkpach from complaining wherever
change to RSA is being made.
Fixes: 26008aaed14c ("cryptodev: add asymmetric xform and op definitions")
Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
v2:
- added ignore hint to abidiff suppression file
app/test/test_cryptodev_asym.c | 2 +-
app/test/test_cryptodev_rsa_test_vectors.h | 2 +-
devtools/libabigail.abignore | 4 ++++
drivers/crypto/qat/qat_asym.c | 4 ++--
lib/cryptodev/rte_crypto_asym.h | 2 +-
5 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
index 7cda8bb081..573af2a537 100644
--- a/app/test/test_cryptodev_asym.c
+++ b/app/test/test_cryptodev_asym.c
@@ -549,7 +549,7 @@ test_one_case(const void *test_case, int sessionless)
status = test_cryptodev_asym_op(
&testsuite_params,
&tc, test_msg, sessionless, i,
- RTE_RSA_KET_TYPE_QT);
+ RTE_RSA_KEY_TYPE_QT);
}
if (status)
break;
diff --git a/app/test/test_cryptodev_rsa_test_vectors.h b/app/test/test_cryptodev_rsa_test_vectors.h
index 48a72e1492..04539a1ecf 100644
--- a/app/test/test_cryptodev_rsa_test_vectors.h
+++ b/app/test/test_cryptodev_rsa_test_vectors.h
@@ -378,7 +378,7 @@ struct rte_crypto_asym_xform rsa_xform_crt = {
.data = rsa_e,
.length = sizeof(rsa_e)
},
- .key_type = RTE_RSA_KET_TYPE_QT,
+ .key_type = RTE_RSA_KEY_TYPE_QT,
.qt = {
.p = {
.data = rsa_p,
diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
index ef0602975a..10c8f64662 100644
--- a/devtools/libabigail.abignore
+++ b/devtools/libabigail.abignore
@@ -20,3 +20,7 @@
; Ignore changes to rte_crypto_asym_op, asymmetric crypto API is experimental
[suppress_type]
name = rte_crypto_asym_op
+
+; Ignore name change of rsa qt key type
+[suppress_type]
+ name = rte_crypto_rsa_priv_key_type
diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qat_asym.c
index f46eefd4b3..27ce0337a7 100644
--- a/drivers/crypto/qat/qat_asym.c
+++ b/drivers/crypto/qat/qat_asym.c
@@ -97,7 +97,7 @@ static void qat_clear_arrays_by_alg(struct qat_asym_op_cookie *cookie,
qat_clear_arrays(cookie, QAT_ASYM_MODINV_NUM_IN_PARAMS,
QAT_ASYM_MODINV_NUM_OUT_PARAMS, alg_size);
else if (xform->xform_type == RTE_CRYPTO_ASYM_XFORM_RSA) {
- if (xform->rsa.key_type == RTE_RSA_KET_TYPE_QT)
+ if (xform->rsa.key_type == RTE_RSA_KEY_TYPE_QT)
qat_clear_arrays_crt(cookie, alg_size);
else {
qat_clear_arrays(cookie, QAT_ASYM_RSA_NUM_IN_PARAMS,
@@ -370,7 +370,7 @@ qat_asym_fill_arrays(struct rte_crypto_asym_op *asym_op,
return -(EINVAL);
}
}
- if (xform->rsa.key_type == RTE_RSA_KET_TYPE_QT) {
+ if (xform->rsa.key_type == RTE_RSA_KEY_TYPE_QT) {
qat_req->input_param_count =
QAT_ASYM_RSA_QT_NUM_IN_PARAMS;
diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h
index 2eb0f001e3..cd24d4b07b 100644
--- a/lib/cryptodev/rte_crypto_asym.h
+++ b/lib/cryptodev/rte_crypto_asym.h
@@ -145,7 +145,7 @@ enum rte_crypto_rsa_padding_type {
enum rte_crypto_rsa_priv_key_type {
RTE_RSA_KEY_TYPE_EXP,
/**< RSA private key is an exponent */
- RTE_RSA_KET_TYPE_QT,
+ RTE_RSA_KEY_TYPE_QT,
/**< RSA private key is in quintuple format
* See rte_crypto_rsa_priv_key_qt
*/
--
2.30.2
next reply other threads:[~2022-02-18 7:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-18 7:53 Arek Kusztal [this message]
2022-02-22 19:25 ` [EXT] " Akhil Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220218075332.18916-1-arkadiuszx.kusztal@intel.com \
--to=arkadiuszx.kusztal@intel.com \
--cc=dev@dpdk.org \
--cc=gakhil@marvell.com \
--cc=mdr@ashroe.eu \
--cc=roy.fan.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).