From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 18E10A0032; Fri, 18 Feb 2022 17:24:03 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D9F974014E; Fri, 18 Feb 2022 17:24:02 +0100 (CET) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by mails.dpdk.org (Postfix) with ESMTP id B737040141 for ; Fri, 18 Feb 2022 17:24:01 +0100 (CET) Received: by mail-pj1-f52.google.com with SMTP id v8-20020a17090a634800b001bb78857ccdso10463614pjs.1 for ; Fri, 18 Feb 2022 08:24:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=MHFb+L6GLetoPcrjsJfGbuMumrszFnnqWSh6+6Fsj2g=; b=XChRsp+3c5nr/uVhOvh9xAN2OmF+56AS0q4cNRIu/ZWMqhH4x2d1BHpbrc4TP3Rb3H wSix1RI2fZC0fNENZ5J07uz5GLuIVCUs/MNmp+TxkHxKE1vJonJRhSr5CZFOIoPRuhjM 9MaE68Hz5ujIOfjhjcI0EPEe6LQy4uNj2Wh45i4wN2MMGpALjSDYrSaaY0Na+BpSEilS 6neao1NrXY7Tw/Ke/rI0rr0QM+ou0lLwcxMxnAtIP7SqtcWOU2h3P9L6r/3HEILeqO2l 4v23VuOTPnT+PBvqMwCi6hCD7EIHlcux8V7+A3e4hN6XjLsc0t6qFZW2xKJw/FEhfcfP Fy3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=MHFb+L6GLetoPcrjsJfGbuMumrszFnnqWSh6+6Fsj2g=; b=sz4bFWIm9CtZJ5vtzW8TdOySZr6FVPz2kuTvHf1vf7/S34W+LI3rsIYpXLZpeUjLo2 rjPVcBXbh/u8VfTIvDE8cOWxLc1QebmtvE+vja7sG3QTJ39Af3zFQ39eOsgm7jSgR2IO 61wPpHv7UY7UGi2KAtZDAX5jqUetqRdo1YAvylQCHD7QMPiWBvpU831TyaINR0gA63zH QpKO46XqzTPxjKq3Q/n4WQjjyUn7Jdpc8h395TOzloajqQUF/VfKLkKZvBMk0hbj6Uyz tCEgGQ9BXs74ODeXwwotOvd2o8zJ0SAkxmGr4v5ukFwITU6O3p9ZSd/h6AWN1UkYlP5N ZMew== X-Gm-Message-State: AOAM530l4wQjJXkIClhXvdmtFEuk6VULCxMtfBlGwIr9tM0y+ka6DtAB eRj10Hl/lVykGcuw1LVPWHaA5TTMDYlbiZbi X-Google-Smtp-Source: ABdhPJz69VX3SIBRYwv/IVcuspFA2Dk2Nc1xLunAhsVLhmPwFNtXeC8xzKlyJvvFQ0PEnIYu56OrGg== X-Received: by 2002:a17:902:694b:b0:14f:3f88:14a3 with SMTP id k11-20020a170902694b00b0014f3f8814a3mr8092349plt.150.1645201440756; Fri, 18 Feb 2022 08:24:00 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id a38sm3282300pfx.121.2022.02.18.08.24.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 18 Feb 2022 08:24:00 -0800 (PST) Date: Fri, 18 Feb 2022 08:23:58 -0800 From: Stephen Hemminger To: Megha Ajmera Cc: dev@dpdk.org, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, thomas@monjalon.net Subject: Re: [PATCH v1 1/4] sched: Cleanup qos scheduler defines from rte_config Message-ID: <20220218082358.4cdc5eab@hermes.local> In-Reply-To: <20220218074148.2549134-2-megha.ajmera@intel.com> References: <20220218074148.2549134-1-megha.ajmera@intel.com> <20220218074148.2549134-2-megha.ajmera@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 18 Feb 2022 07:41:45 +0000 Megha Ajmera wrote: > diff --git a/doc/guides/sample_app_ug/qos_scheduler.rst b/doc/guides/sample_app_ug/qos_scheduler.rst > index 49c14a00da..7016ca4078 100644 > --- a/doc/guides/sample_app_ug/qos_scheduler.rst > +++ b/doc/guides/sample_app_ug/qos_scheduler.rst > @@ -42,8 +42,7 @@ The application is located in the ``qos_sched`` sub-directory. > .. note:: > > To get statistics on the sample app using the command line interface as described in the next section, > - DPDK must be compiled defining *RTE_SCHED_COLLECT_STATS*, which can be done by changing the relevant > - entry in the ``config/rte_config.h`` file. > + DPDK must be compiled after defining *RTE_SCHED_COLLECT_STATS* in the ``config/rte_config.h`` file. Please don't have a process that requires users to edit rte_config.h If necessary use meson options?