DPDK patches and discussions
 help / color / mirror / Atom feed
From: Megha Ajmera <megha.ajmera@intel.com>
To: dev@dpdk.org, jasvinder.singh@intel.com,
	cristian.dumitrescu@intel.com, thomas@monjalon.net,
	david.marchand@redhat.com
Subject: [PATCH v2 2/4] sched: Always enable stats in HQoS library.
Date: Fri, 18 Feb 2022 09:36:48 +0000	[thread overview]
Message-ID: <20220218093650.2549927-3-megha.ajmera@intel.com> (raw)
In-Reply-To: <20220218093650.2549927-1-megha.ajmera@intel.com>

Removed "RTE_SCHED_COLLECT_STATS" flag from HQoS.

Signed-off-by: Megha Ajmera <megha.ajmera@intel.com>
---
 lib/sched/rte_sched.c | 12 ------------
 1 file changed, 12 deletions(-)

diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c
index 6c3e3bb0bf..6f2d85edc0 100644
--- a/lib/sched/rte_sched.c
+++ b/lib/sched/rte_sched.c
@@ -1790,8 +1790,6 @@ rte_sched_port_queue_is_empty(struct rte_sched_subport *subport,
 
 #endif /* RTE_SCHED_DEBUG */
 
-#ifdef RTE_SCHED_COLLECT_STATS
-
 static inline void
 rte_sched_port_update_subport_stats(struct rte_sched_port *port,
 	struct rte_sched_subport *subport,
@@ -1849,8 +1847,6 @@ rte_sched_port_update_queue_stats_on_drop(struct rte_sched_subport *subport,
 #endif
 }
 
-#endif /* RTE_SCHED_COLLECT_STATS */
-
 #ifdef RTE_SCHED_CMAN
 
 static inline int
@@ -1989,18 +1985,14 @@ rte_sched_port_enqueue_qptrs_prefetch0(struct rte_sched_subport *subport,
 	struct rte_mbuf *pkt, uint32_t subport_qmask)
 {
 	struct rte_sched_queue *q;
-#ifdef RTE_SCHED_COLLECT_STATS
 	struct rte_sched_queue_extra *qe;
-#endif
 	uint32_t qindex = rte_mbuf_sched_queue_get(pkt);
 	uint32_t subport_queue_id = subport_qmask & qindex;
 
 	q = subport->queue + subport_queue_id;
 	rte_prefetch0(q);
-#ifdef RTE_SCHED_COLLECT_STATS
 	qe = subport->queue_extra + subport_queue_id;
 	rte_prefetch0(qe);
-#endif
 
 	return subport_queue_id;
 }
@@ -2042,12 +2034,10 @@ rte_sched_port_enqueue_qwa(struct rte_sched_port *port,
 	if (unlikely(rte_sched_port_cman_drop(port, subport, pkt, qindex, qlen) ||
 		     (qlen >= qsize))) {
 		rte_pktmbuf_free(pkt);
-#ifdef RTE_SCHED_COLLECT_STATS
 		rte_sched_port_update_subport_stats_on_drop(port, subport,
 			qindex, pkt, qlen < qsize);
 		rte_sched_port_update_queue_stats_on_drop(subport, qindex, pkt,
 			qlen < qsize);
-#endif
 		return 0;
 	}
 
@@ -2059,10 +2049,8 @@ rte_sched_port_enqueue_qwa(struct rte_sched_port *port,
 	rte_bitmap_set(subport->bmp, qindex);
 
 	/* Statistics */
-#ifdef RTE_SCHED_COLLECT_STATS
 	rte_sched_port_update_subport_stats(port, subport, qindex, pkt);
 	rte_sched_port_update_queue_stats(subport, qindex, pkt);
-#endif
 
 	return 1;
 }
-- 
2.25.1


  parent reply	other threads:[~2022-02-18  9:37 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18  9:36 [PATCH v2 0/4] sched: HQoS Library cleanup Megha Ajmera
2022-02-18  9:36 ` [PATCH v2 1/4] sched: Cleanup qos scheduler defines from rte_config Megha Ajmera
2022-02-18 10:52   ` Thomas Monjalon
2022-02-18 11:14     ` Dumitrescu, Cristian
2022-02-18 11:17     ` Dumitrescu, Cristian
2022-02-18 11:04   ` Dumitrescu, Cristian
2022-02-18  9:36 ` Megha Ajmera [this message]
2022-02-18 11:01   ` [PATCH v2 2/4] sched: Always enable stats in HQoS library Dumitrescu, Cristian
2022-02-18  9:36 ` [PATCH v2 3/4] sched: Always enable best effort TC oversubscription " Megha Ajmera
2022-02-18 11:02   ` Dumitrescu, Cristian
2022-02-18  9:36 ` [PATCH v2 4/4] sched: Removed code defined under VECTOR Defines Megha Ajmera
2022-02-18 11:03   ` Dumitrescu, Cristian
2022-02-18 10:58 ` [PATCH v2 0/4] sched: HQoS Library cleanup Dumitrescu, Cristian
2022-02-18 11:49   ` Thomas Monjalon
2022-02-22 12:57 ` [PATCH v3 0/4] sched: cleanup of sched library Megha Ajmera
2022-02-22 12:57   ` [PATCH v3 1/4] sched: remove code no longer needed Megha Ajmera
2022-02-22 12:57   ` [PATCH v3 2/4] sched: move grinder configuration flag Megha Ajmera
2022-02-22 12:57   ` [PATCH v3 3/4] sched: enable statistics unconditionally Megha Ajmera
2022-02-22 12:57   ` [PATCH v3 4/4] sched: enable traffic class oversubscription unconditionally Megha Ajmera
2022-02-22 15:27   ` [PATCH v3 0/4] sched: cleanup of sched library Dumitrescu, Cristian
2022-02-24 22:44     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220218093650.2549927-3-megha.ajmera@intel.com \
    --to=megha.ajmera@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).