From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id DC9A8A0032;
Fri, 18 Feb 2022 10:37:13 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 5E07C41150;
Fri, 18 Feb 2022 10:37:05 +0100 (CET)
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
by mails.dpdk.org (Postfix) with ESMTP id 4B549410FB
for <dev@dpdk.org>; Fri, 18 Feb 2022 10:37:04 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=intel.com; i=@intel.com; q=dns/txt; s=Intel;
t=1645177024; x=1676713024;
h=from:to:subject:date:message-id:in-reply-to:references:
mime-version:content-transfer-encoding;
bh=4cr4lDATOL/E23xYyCsv+y0pfT7HvN0yUk8DX1zO1uE=;
b=iCYRudyhz7MVXTHMkj2wgNsh/e84/mFnOgNz1vQn5aKpz0LF3gdw0jOD
UXyUSPm5eG+XzWuMa4OWrMDx0GSpjs+hdvih4MRdSTKeO7yUnG5+TZ7XB
R3eDv3HO3/c6Q9MDGWrGlQnWMsD31UaoFi+MhyVIi2HEd1Sy/uuSZN5V+
wNZKAyf2Zd/S9HXw/pFjNZaPpdKDq0Xx4jbnxVpIRJLZDgd1YFStrkLh6
pikjDVUwsipvRuscg59K0N+HxNtFJ6NbPFULd9R9DAR/SGUE4ZM/vacoT
pwkxBqpcE+q/nXnkH/trjIZZ1J0S7MPvpgkt7djRe85glYfVSvEV40Dg7 Q==;
X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="250849506"
X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="250849506"
Received: from orsmga003.jf.intel.com ([10.7.209.27])
by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
18 Feb 2022 01:37:03 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="489318650"
Received: from silpixa00397515.ir.intel.com (HELO
silpixa00397515.ger.corp.intel.com) ([10.237.222.51])
by orsmga003.jf.intel.com with ESMTP; 18 Feb 2022 01:37:02 -0800
From: Megha Ajmera <megha.ajmera@intel.com>
To: dev@dpdk.org, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com,
thomas@monjalon.net, david.marchand@redhat.com
Subject: [PATCH v2 2/4] sched: Always enable stats in HQoS library.
Date: Fri, 18 Feb 2022 09:36:48 +0000
Message-Id: <20220218093650.2549927-3-megha.ajmera@intel.com>
X-Mailer: git-send-email 2.25.1
In-Reply-To: <20220218093650.2549927-1-megha.ajmera@intel.com>
References: <20220218093650.2549927-1-megha.ajmera@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Removed "RTE_SCHED_COLLECT_STATS" flag from HQoS.
Signed-off-by: Megha Ajmera <megha.ajmera@intel.com>
---
lib/sched/rte_sched.c | 12 ------------
1 file changed, 12 deletions(-)
diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c
index 6c3e3bb0bf..6f2d85edc0 100644
--- a/lib/sched/rte_sched.c
+++ b/lib/sched/rte_sched.c
@@ -1790,8 +1790,6 @@ rte_sched_port_queue_is_empty(struct rte_sched_subport *subport,
#endif /* RTE_SCHED_DEBUG */
-#ifdef RTE_SCHED_COLLECT_STATS
-
static inline void
rte_sched_port_update_subport_stats(struct rte_sched_port *port,
struct rte_sched_subport *subport,
@@ -1849,8 +1847,6 @@ rte_sched_port_update_queue_stats_on_drop(struct rte_sched_subport *subport,
#endif
}
-#endif /* RTE_SCHED_COLLECT_STATS */
-
#ifdef RTE_SCHED_CMAN
static inline int
@@ -1989,18 +1985,14 @@ rte_sched_port_enqueue_qptrs_prefetch0(struct rte_sched_subport *subport,
struct rte_mbuf *pkt, uint32_t subport_qmask)
{
struct rte_sched_queue *q;
-#ifdef RTE_SCHED_COLLECT_STATS
struct rte_sched_queue_extra *qe;
-#endif
uint32_t qindex = rte_mbuf_sched_queue_get(pkt);
uint32_t subport_queue_id = subport_qmask & qindex;
q = subport->queue + subport_queue_id;
rte_prefetch0(q);
-#ifdef RTE_SCHED_COLLECT_STATS
qe = subport->queue_extra + subport_queue_id;
rte_prefetch0(qe);
-#endif
return subport_queue_id;
}
@@ -2042,12 +2034,10 @@ rte_sched_port_enqueue_qwa(struct rte_sched_port *port,
if (unlikely(rte_sched_port_cman_drop(port, subport, pkt, qindex, qlen) ||
(qlen >= qsize))) {
rte_pktmbuf_free(pkt);
-#ifdef RTE_SCHED_COLLECT_STATS
rte_sched_port_update_subport_stats_on_drop(port, subport,
qindex, pkt, qlen < qsize);
rte_sched_port_update_queue_stats_on_drop(subport, qindex, pkt,
qlen < qsize);
-#endif
return 0;
}
@@ -2059,10 +2049,8 @@ rte_sched_port_enqueue_qwa(struct rte_sched_port *port,
rte_bitmap_set(subport->bmp, qindex);
/* Statistics */
-#ifdef RTE_SCHED_COLLECT_STATS
rte_sched_port_update_subport_stats(port, subport, qindex, pkt);
rte_sched_port_update_queue_stats(subport, qindex, pkt);
-#endif
return 1;
}
--
2.25.1