From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99CD3A0032; Fri, 18 Feb 2022 16:29:50 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2C2674014E; Fri, 18 Feb 2022 16:29:50 +0100 (CET) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mails.dpdk.org (Postfix) with ESMTP id A912B40141 for ; Fri, 18 Feb 2022 12:57:41 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645185461; x=1676721461; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=1qpS5yCPrqvUYYzGBptnayU+1z25XjL/wB9myImMQYc=; b=m6lmpgsZ108fwZYQVQ7uliiipclBUULZNnl7KPRecZzki99VsQvetJLU NUVeHEMWutNvEuWVQN2UahVngsl7ZTQ++H6qm/Io3lMHUX/7Djytjp0Ge w44scDv8pxQzAfwzNJiiii+7/TxMKT7xAHL6qJgxNZDAPsQiKitSrsaTK QK1Zzh7302qRm4zQWYi/ijzIUEaUzowqOLQ45pckQIGxrJPsjFzFoGJF0 fjtFscj6RDerthAAlm37ZK6BrT2h+SpbCdw1EVdj7Am/PZo8xi+IWiZ6f dyO0GKERcJQgX/mM3D56fHMAfHGXq5hK44WTrDxkQxiOd634eoLuSydsT g==; X-IronPort-AV: E=McAfee;i="6200,9189,10261"; a="311854912" X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="311854912" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 03:57:40 -0800 X-IronPort-AV: E=Sophos;i="5.88,378,1635231600"; d="scan'208";a="505587422" Received: from mwilczyn-mobl.ger.corp.intel.com ([10.249.143.70]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Feb 2022 03:57:39 -0800 From: Michal Wilczynski To: dev@dpdk.org Cc: haiyue.wang@intel.com, qi.z.zhang@intel.com, Michal Wilczynski Subject: [PATCH] net/ice: fix overwriting of LSE bit by DCF Date: Fri, 18 Feb 2022 12:57:19 +0100 Message-Id: <20220218115719.20471-1-michal.wilczynski@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailman-Approved-At: Fri, 18 Feb 2022 16:29:49 +0100 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org After enabling DCF on a VF, the ice driver stops receiving link updates on it's Admin Receive Queue. During the init of DCF ice_aqc_opc_get_link_status command is send to the firmware without LSE(LINK STATUS EVENT) bit set. This prevents the ice driver from receiving up/down events, and correspondingly updating netdev. Signed-off-by: Michal Wilczynski --- drivers/net/ice/ice_dcf_parent.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ice/ice_dcf_parent.c b/drivers/net/ice/ice_dcf_parent.c index 0c8c2ed6c7..2f96dedcce 100644 --- a/drivers/net/ice/ice_dcf_parent.c +++ b/drivers/net/ice/ice_dcf_parent.c @@ -340,7 +340,7 @@ ice_dcf_init_parent_hw(struct ice_hw *hw) goto err_unroll_alloc; /* Initialize port_info struct with link information */ - status = ice_aq_get_link_info(hw->port_info, false, NULL, NULL); + status = ice_aq_get_link_info(hw->port_info, true, NULL, NULL); if (status) goto err_unroll_alloc; -- 2.25.1 --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited.