From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH v3 1/8] cocci/nullfree: add more functions
Date: Sun, 20 Feb 2022 10:21:40 -0800 [thread overview]
Message-ID: <20220220182147.9750-2-stephen@networkplumber.org> (raw)
In-Reply-To: <20220220182147.9750-1-stephen@networkplumber.org>
There are more functions in DPDK which have the semantics
as free() when passed NULL pointer. Also, put the checks
in alpha order.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
devtools/cocci/nullfree.cocci | 108 ++++++++++++++++++++++++++++++++--
1 file changed, 102 insertions(+), 6 deletions(-)
diff --git a/devtools/cocci/nullfree.cocci b/devtools/cocci/nullfree.cocci
index 363b6149ac28..9ca3fc286497 100644
--- a/devtools/cocci/nullfree.cocci
+++ b/devtools/cocci/nullfree.cocci
@@ -7,27 +7,123 @@
expression E;
@@
(
+- if (E != NULL) cmdline_free(E);
++ cmdline_free(E);
+|
- if (E != NULL) free(E);
+ free(E);
|
+- if (E != NULL) rte_acl_free(E);
++ rte_acl_free(E);
+|
- if (E != NULL) rte_bitmap_free(E);
+ rte_bitmap_free(E);
|
+- if (E != NULL) rte_comp_op_free(E);
++ rte_comp_op_free(E);
+|
+- if (E != NULL) rte_crypto_op_free(E);
++ rte_crypto_op_free(E);
+|
+- if (E != NULL) rte_efd_free(E);
++ rte_efd_free(E);
+|
+- if (E != NULL) rte_event_ring_free(E);
++ rte_event_ring_free(E);
+|
+- if (E != NULL) rte_fib_free(E);
++ rte_fib_free(E);
+|
+- if (E != NULL) rte_fib6_free(E);
++ rte_fib6_free(E);
+|
+- if (E != NULL) rte_flow_classifier_free(E);
++ rte_flow_classifier_free(E);
+|
- if (E != NULL) rte_free(E);
+ rte_free(E);
|
+- if (E != NULL) rte_fbk_hash_free(E);
++ rte_fbk_hash_free(E);
+|
+- if (E != NULL) rte_gpu_mem_free(E);
++ rte_gpu_mem_free(E);
+|
- if (E != NULL) rte_hash_free(E);
+ rte_hash_free(E);
|
-- if (E != NULL) rte_ring_free(E);
-+ rte_ring_free(E);
+- if (E != NULL) rte_intr_instance_free(E);
++ rte_intr_instance_free(E);
|
-- if (E != NULL) rte_pktmbuf_free(E);
-+ rte_pktmbuf_free(E);
+- if (E != NULL) rte_intr_vec_list_free(E);
++ rte_intr_vec_list_free(E);
+|
+- if (E != NULL) rte_kvargs_free(E);
++ rte_kvargs_free(E);
+|
+- if (E != NULL) rte_lpm_free(E);
++ rte_lpm_free(E);
+|
+- if (E != NULL) rte_lpm6_free(E);
++ rte_lpm6_free(E);
+|
+- if (E != NULL) rte_member_free(E);
++ rte_member_free(E);
|
- if (E != NULL) rte_mempool_free(E);
+ rte_mempool_free(E);
|
-- if (E != NULL) rte_kvargs_free(E);
-+ rte_kvargs_free(E);
+- if (E != NULL) rte_pktmbuf_free(E);
++ rte_pktmbuf_free(E);
+|
+- if (E != NULL) rte_rib_free(E);
++ rte_rib_free(E);
+|
+- if (E != NULL) rte_rib6_free(E);
++ rte_rib6_free(E);
+|
+- if (E != NULL) rte_reorder_free(E);
++ rte_reorder_free(E);
+|
+- if (E != NULL) rte_ring_free(E);
++ rte_ring_free(E);
+|
+- if (E != NULL) rte_port_in_action_free(E);
++ rte_port_in_action_free(E);
+|
+- if (E != NULL) rte_port_in_action_profile_free(E);
++ rte_port_in_action_profile_free(E);
+|
+- if (E != NULL) rte_sched_port_free(E);
++ rte_sched_port_free(E);
+|
+- if (E != NULL) rte_stack_free(E);
++ rte_stack_free(E);
+|
+- if (E != NULL) rte_stats_bitrate_free(E);
++ rte_stats_bitrate_free(E);
+|
+- if (E != NULL) rte_swx_ctl_pipeline_free(E);
++ rte_swx_ctl_pipeline_free(E);
+|
+- if (E != NULL) rte_swx_pipeline_free(E);
++ rte_swx_pipeline_free(E);
+|
+- if (E != NULL) rte_swx_table_learner_free(E);
++ rte_swx_table_learner_free(E);
+|
+- if (E != NULL) rte_swx_table_selector_free(E);
++ rte_swx_table_selector_free(E);
+|
+- if (E != NULL) rte_table_action_free(E);
++ rte_table_action_free(E);
+|
+- if (E != NULL) rte_table_action_profile_free(E);
++ rte_table_action_profile_free(E);
+|
+- if (E != NULL) rte_tel_data_free(E);
++ rte_tel_data_free(E);
+|
+- if (E != NULL) trie_free(E);
++ trie_free(E);
)
--
2.34.1
next prev parent reply other threads:[~2022-02-20 18:21 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-19 23:43 [PATCH 0/3] more unnecessary null checks Stephen Hemminger
2022-02-19 23:43 ` [PATCH 1/3] cocci/nullfree: add more functions Stephen Hemminger
2022-02-19 23:43 ` [PATCH 2/3] acl: remove unncessary null checks in calls to rte_acl_free() Stephen Hemminger
2022-02-19 23:43 ` [PATCH 3/3] lpm: remove unnecessary NULL checks Stephen Hemminger
2022-02-20 0:51 ` [PATCH v2 0/7] fix more unnecessary null checks Stephen Hemminger
2022-02-20 0:51 ` [PATCH v2 1/7] cocci/nullfree: add more functions Stephen Hemminger
2022-02-20 0:51 ` [PATCH v2 2/7] acl: remove unnecessary null checks Stephen Hemminger
2022-02-20 0:51 ` [PATCH v2 3/7] lpm: remove unnecessary NULL checks Stephen Hemminger
2022-02-20 0:51 ` [PATCH v2 4/7] lib: document existing free functions Stephen Hemminger
2022-02-20 0:51 ` [PATCH v2 5/7] test: remove unecessary NULL checks before free Stephen Hemminger
2022-02-20 0:51 ` [PATCH v2 6/7] fips_validation: remove unnecessary NULL check Stephen Hemminger
2022-02-20 0:51 ` [PATCH v2 7/7] event/sw: " Stephen Hemminger
2022-02-20 5:18 ` [PATCH 0/3] more unnecessary null checks Jerin Jacob
2022-02-20 18:21 ` [PATCH v3 0/8] yet more unnecessary NULL checks Stephen Hemminger
2022-02-20 18:21 ` Stephen Hemminger [this message]
2022-02-20 18:21 ` [PATCH v3 2/8] acl: remove unnecessary null checks Stephen Hemminger
2022-02-20 18:21 ` [PATCH v3 3/8] lpm: remove unnecessary NULL checks Stephen Hemminger
2022-02-21 2:47 ` Ruifeng Wang
2022-02-21 15:51 ` Medvedkin, Vladimir
2022-02-20 18:21 ` [PATCH v3 4/8] lib: document existing free functions Stephen Hemminger
2022-02-27 20:48 ` Thomas Monjalon
2022-02-28 9:42 ` Bruce Richardson
2022-02-28 17:08 ` Stephen Hemminger
2022-06-22 9:23 ` Thomas Monjalon
2022-06-22 14:55 ` Stephen Hemminger
2022-02-20 18:21 ` [PATCH v3 5/8] test: remove unnecessary NULL checks before free Stephen Hemminger
2022-02-20 18:21 ` [PATCH v3 6/8] fips_validation: remove unnecessary NULL check Stephen Hemminger
2022-02-20 18:21 ` [PATCH v3 7/8] event/sw: " Stephen Hemminger
2022-02-20 18:21 ` [PATCH v3 8/8] pipeline: remove unnecessary checks for NULL pointer before free Stephen Hemminger
2022-06-22 20:52 ` [PATCH v4] lib: document existing free functions Stephen Hemminger
2022-06-23 0:37 ` fengchengwen
2022-06-24 12:35 ` David Marchand
2022-06-24 12:41 ` [PATCH v3 0/8] yet more unnecessary NULL checks David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220220182147.9750-2-stephen@networkplumber.org \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).