From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6E92A0352; Tue, 22 Feb 2022 17:09:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D480426E5; Tue, 22 Feb 2022 17:07:23 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 763AA41C3B for ; Tue, 22 Feb 2022 17:07:17 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id q1so7448290plx.4 for ; Tue, 22 Feb 2022 08:07:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cRQWXnDR1l+z0DYsgRFWXdkdZlbZXE9UsiU74n/sdeI=; b=4vu6BZPGYb21q8ChSwDzHvbPi8vFccJO9iSm+gimTdlgZCq56WfUhaihAjeClYVxol IyZOmqMOmjjqavaw6v16sCvRBN76T7k6x0DtxkAZkj18Ez4FFKpj3WcLzA2wlXsUnHGB yBx1PAtNZ7ykaTR83k8Sc+q9djTh6BDwe3SFNDRzqbTCwbBq29YI88wIiqqMy/s4BMyl pAAChsbCS/PMOgMJG0qytmAVOwmdgALkH5JGq3IxJOvwjknmU/wh9J692Ur/6qhS3K5w gSQL7NH9/aKVxaMxkQzjphfJa5G10/J4/YgbOVNheut69f40oNSTbhiH7sNQGVf12bXI 5Elw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cRQWXnDR1l+z0DYsgRFWXdkdZlbZXE9UsiU74n/sdeI=; b=l2J+GqOqLBksi21s6JuEoH37hkktFNRSOtFvYO9Iy6LgxEsu1MzX6Rbfo2v2T8cvSp A9NA/oDl2d+yGqpH+4qv8xfGLMr22p+JzFk0lgAJ/bbfOWB8C2PN6fWsouIuMwLKkT7G txbO4So49Pnu4aI0/7ZdBw8MXFCPrvM+b+bv8bknoZy7K++4yb1pHsHPslMG6dcCE/+7 69Ugs8fN77ZlBB21DUMYccQ1h0cGdRkYpuWPc51Qayua5x5geTpa7deuZs5VCPH2geUQ MQ6V2VbP1mHdJ8PicvNQs4Bjr5aJ9jajWfNb3+pAwtSN6JzsQjZlT8REG0e2MJF9nDiR GKew== X-Gm-Message-State: AOAM533gP1TgZ4KD7Jvl6wHYOQGsIb0dHH+Y5BVmQGljAzbSVK42ES3R ArxIj2J9gmhUmZe0hb8kJ0ngnykiXArsCTIb X-Google-Smtp-Source: ABdhPJzhY+cIuVGWbSsJxQLqYf31evCCJMAKaZwrtKBEfdoDMdMZK3uBfccV4z0uOxuA29tBq0V4LA== X-Received: by 2002:a17:90b:3b42:b0:1b9:b5d8:ead2 with SMTP id ot2-20020a17090b3b4200b001b9b5d8ead2mr4864257pjb.149.1645546036754; Tue, 22 Feb 2022 08:07:16 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id c9sm18160180pfv.70.2022.02.22.08.07.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Feb 2022 08:07:16 -0800 (PST) Date: Tue, 22 Feb 2022 08:07:13 -0800 From: Stephen Hemminger To: Miao Li Cc: dev@dpdk.org, david.hunt@intel.com, yinan.wang@intel.com Subject: Re: [PATCH v1] power: add wakeup log Message-ID: <20220222080713.5ea7a07d@hermes.local> In-Reply-To: <20220222135227.631275-1-miao.li@intel.com> References: <20220222135227.631275-1-miao.li@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 22 Feb 2022 13:52:27 +0000 Miao Li wrote: > + "lcore %u is waked up from value change\n", That is awkward phrasing in English and should be DEBUG not INFO level because it may happen often. Maybe: "lcore %u awoke because value changed\n" or something better. PS: sometimes it is good idea to using grammar tools when wording commit or messages.