DPDK patches and discussions
 help / color / mirror / Atom feed
From: Megha Ajmera <megha.ajmera@intel.com>
To: dev@dpdk.org, jasvinder.singh@intel.com,
	cristian.dumitrescu@intel.com, thomas@monjalon.net,
	david.marchand@redhat.com, sham.singh.thakur@intel.com
Subject: [PATCH v3 0/4] sched: cleanup of sched library
Date: Tue, 22 Feb 2022 12:57:41 +0000	[thread overview]
Message-ID: <20220222125745.2944462-1-megha.ajmera@intel.com> (raw)
In-Reply-To: <20220218093650.2549927-1-megha.ajmera@intel.com>

v3:
This patchset involves the cleanup of sched library:

* Addresses review comments on v2 patchset.

* RTE_SCHED_CMAN is left unmodified in rte_config.h.
  Cleanup of this will be taken up later.

* Removed unused flag RTE_SCHED_VECTOR from arm/meson.build. Only
  scalar version is now supported.

* Added grinder configuration in docs. The configuration is moved from
  rte_config.h into sched library.  Default number of grinders is 8.
  To override the default, specify RTE_SCHED_PORT_N_GRINDERS=N in CFLAGS
  before compiling sched library.

* Sample app is updated to always collect statistics as this flag is
  removed.

* Updated softnic library by enabling TC oversubscription.
  This flag is now removed from sched.

v2:
This patchset involves the cleanup of sched Library:

* Removed unused sched #defines from rte_config.
  RTE_SCHED_CMAN, RTE_SCHED_COLLECT_STATS, RTE_SCHED_SUBPORT_TC_OV and
  RTE_SCHED_VECTOR.

* RTE_SCHED_COLLECT_STATS flag is removed from the code.
  Stats collection is now always enabled.

* RTE_SCHED_SUBPORT_TC_OV flag is removed.
  TC over subscription for best effort queues is now always enabled.

* RTE_SCHED_VECTOR flag is removed from sched library as the code under this
  flag is no longer useful. Only scalar version is supported.

* Rebased with latest main branch code.

Megha Ajmera (4):
  sched: remove code no longer needed
  sched: move grinder configuration flag
  sched: enable statistics unconditionally
  sched: enable traffic class oversubscription unconditionally

 config/arm/meson.build                     |   1 -
 config/rte_config.h                        |   4 -
 doc/guides/sample_app_ug/qos_scheduler.rst |   5 +-
 drivers/net/softnic/rte_eth_softnic_tm.c   |  18 ---
 examples/qos_sched/init.c                  |   2 -
 lib/sched/rte_sched.c                      | 156 +--------------------
 6 files changed, 4 insertions(+), 182 deletions(-)

-- 
2.25.1


  parent reply	other threads:[~2022-02-22 12:57 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-18  9:36 [PATCH v2 0/4] sched: HQoS Library cleanup Megha Ajmera
2022-02-18  9:36 ` [PATCH v2 1/4] sched: Cleanup qos scheduler defines from rte_config Megha Ajmera
2022-02-18 10:52   ` Thomas Monjalon
2022-02-18 11:14     ` Dumitrescu, Cristian
2022-02-18 11:17     ` Dumitrescu, Cristian
2022-02-18 11:04   ` Dumitrescu, Cristian
2022-02-18  9:36 ` [PATCH v2 2/4] sched: Always enable stats in HQoS library Megha Ajmera
2022-02-18 11:01   ` Dumitrescu, Cristian
2022-02-18  9:36 ` [PATCH v2 3/4] sched: Always enable best effort TC oversubscription " Megha Ajmera
2022-02-18 11:02   ` Dumitrescu, Cristian
2022-02-18  9:36 ` [PATCH v2 4/4] sched: Removed code defined under VECTOR Defines Megha Ajmera
2022-02-18 11:03   ` Dumitrescu, Cristian
2022-02-18 10:58 ` [PATCH v2 0/4] sched: HQoS Library cleanup Dumitrescu, Cristian
2022-02-18 11:49   ` Thomas Monjalon
2022-02-22 12:57 ` Megha Ajmera [this message]
2022-02-22 12:57   ` [PATCH v3 1/4] sched: remove code no longer needed Megha Ajmera
2022-02-22 12:57   ` [PATCH v3 2/4] sched: move grinder configuration flag Megha Ajmera
2022-02-22 12:57   ` [PATCH v3 3/4] sched: enable statistics unconditionally Megha Ajmera
2022-02-22 12:57   ` [PATCH v3 4/4] sched: enable traffic class oversubscription unconditionally Megha Ajmera
2022-02-22 15:27   ` [PATCH v3 0/4] sched: cleanup of sched library Dumitrescu, Cristian
2022-02-24 22:44     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220222125745.2944462-1-megha.ajmera@intel.com \
    --to=megha.ajmera@intel.com \
    --cc=cristian.dumitrescu@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=jasvinder.singh@intel.com \
    --cc=sham.singh.thakur@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).