From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCF29A0350; Tue, 22 Feb 2022 13:57:57 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7AAAF41145; Tue, 22 Feb 2022 13:57:56 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mails.dpdk.org (Postfix) with ESMTP id 8AB6440DF6 for ; Tue, 22 Feb 2022 13:57:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645534672; x=1677070672; h=from:to:subject:date:message-id:in-reply-to:references: mime-version:content-transfer-encoding; bh=pVeK0Epea3EjB6dZZuMM0aDz9x0/B+T2TP1M/4ZL6Go=; b=NwMQ7iIIJ9nWE+rC1kMEzUPn/Ek2ewHB10BwefDRfCUxSLdB3qGBFqZ8 HbKAn9Owdx3K2Lq44mGuBEa5Z/JuZ2R/zGe5so2YAC9xaIcgTrmq1vpCy xP6Ztbn3UXSe0l3DeyXEGZw0F6hJozHbDsynSxNHicU56CvMUwcZaroew /lE15a8+IZPei90/FRIHUrXNnympkMFjxCXNk/ncNW/XnBSyKKsndFeJi il/KJoT3ABKdsaVJMHAl22sx7VL+xwHMM3XnI2U11b/WBxJXdqN9tgXur y/AdcLgByT0qjtkLLrvm+Vi7tZQHA2ZKMKQwxdYtz3OqLmHF2EWWF13Ba Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10265"; a="251627054" X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="251627054" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2022 04:57:52 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="542926650" Received: from silpixa00397515.ir.intel.com (HELO silpixa00397515.ger.corp.intel.com) ([10.237.222.51]) by fmsmga007.fm.intel.com with ESMTP; 22 Feb 2022 04:57:50 -0800 From: Megha Ajmera To: dev@dpdk.org, jasvinder.singh@intel.com, cristian.dumitrescu@intel.com, thomas@monjalon.net, david.marchand@redhat.com, sham.singh.thakur@intel.com Subject: [PATCH v3 1/4] sched: remove code no longer needed Date: Tue, 22 Feb 2022 12:57:42 +0000 Message-Id: <20220222125745.2944462-2-megha.ajmera@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220222125745.2944462-1-megha.ajmera@intel.com> References: <20220218093650.2549927-1-megha.ajmera@intel.com> <20220222125745.2944462-1-megha.ajmera@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Remove RTE_SCHED_VECTOR flag from rte_config.h. This flag is no longer useful. Only scalar version is supported. Signed-off-by: Megha Ajmera --- config/arm/meson.build | 1 - config/rte_config.h | 1 - lib/sched/rte_sched.c | 54 ------------------------------------------ 3 files changed, 56 deletions(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index 48b88a84f2..8aead74086 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -17,7 +17,6 @@ flags_common = [ # ['RTE_ARM64_MEMCPY_ALIGN_MASK', 0xF], # ['RTE_ARM64_MEMCPY_STRICT_ALIGN', false], - ['RTE_SCHED_VECTOR', false], ['RTE_ARM_USE_WFE', false], ['RTE_ARCH_ARM64', true], ['RTE_CACHE_LINE_SIZE', 128] diff --git a/config/rte_config.h b/config/rte_config.h index 91d96eeecb..7a7da2f4e5 100644 --- a/config/rte_config.h +++ b/config/rte_config.h @@ -93,7 +93,6 @@ #undef RTE_SCHED_COLLECT_STATS #undef RTE_SCHED_SUBPORT_TC_OV #define RTE_SCHED_PORT_N_GRINDERS 8 -#undef RTE_SCHED_VECTOR /* rte_graph defines */ #define RTE_GRAPH_BURST_SIZE 256 diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index 62b3d2e315..1d3051cc0f 100644 --- a/lib/sched/rte_sched.c +++ b/lib/sched/rte_sched.c @@ -24,17 +24,6 @@ #pragma warning(disable:2259) /* conversion may lose significant bits */ #endif -#ifdef RTE_SCHED_VECTOR -#include - -#ifdef RTE_ARCH_X86 -#define SCHED_VECTOR_SSE4 -#elif defined(__ARM_NEON) -#define SCHED_VECTOR_NEON -#endif - -#endif - #define RTE_SCHED_TB_RATE_CONFIG_ERR (1e-7) #define RTE_SCHED_WRR_SHIFT 3 #define RTE_SCHED_MAX_QUEUES_PER_TC RTE_SCHED_BE_QUEUES_PER_PIPE @@ -2545,47 +2534,6 @@ grinder_schedule(struct rte_sched_port *port, return 1; } -#ifdef SCHED_VECTOR_SSE4 - -static inline int -grinder_pipe_exists(struct rte_sched_subport *subport, uint32_t base_pipe) -{ - __m128i index = _mm_set1_epi32(base_pipe); - __m128i pipes = _mm_load_si128((__m128i *)subport->grinder_base_bmp_pos); - __m128i res = _mm_cmpeq_epi32(pipes, index); - - pipes = _mm_load_si128((__m128i *)(subport->grinder_base_bmp_pos + 4)); - pipes = _mm_cmpeq_epi32(pipes, index); - res = _mm_or_si128(res, pipes); - - if (_mm_testz_si128(res, res)) - return 0; - - return 1; -} - -#elif defined(SCHED_VECTOR_NEON) - -static inline int -grinder_pipe_exists(struct rte_sched_subport *subport, uint32_t base_pipe) -{ - uint32x4_t index, pipes; - uint32_t *pos = (uint32_t *)subport->grinder_base_bmp_pos; - - index = vmovq_n_u32(base_pipe); - pipes = vld1q_u32(pos); - if (!vminvq_u32(veorq_u32(pipes, index))) - return 1; - - pipes = vld1q_u32(pos + 4); - if (!vminvq_u32(veorq_u32(pipes, index))) - return 1; - - return 0; -} - -#else - static inline int grinder_pipe_exists(struct rte_sched_subport *subport, uint32_t base_pipe) { @@ -2599,8 +2547,6 @@ grinder_pipe_exists(struct rte_sched_subport *subport, uint32_t base_pipe) return 0; } -#endif /* RTE_SCHED_OPTIMIZATIONS */ - static inline void grinder_pcache_populate(struct rte_sched_subport *subport, uint32_t pos, uint32_t bmp_pos, uint64_t bmp_slab) -- 2.25.1