DPDK patches and discussions
 help / color / mirror / Atom feed
From: Megha Ajmera <megha.ajmera@intel.com>
To: dev@dpdk.org, mb@smartsharesystems.com,
	stephen@networkplumber.org, thomas@monjalon.net,
	john.mcnamara@intel.com, sham.singh.thakur@intel.com
Subject: [PATCH v2] sched: fix integer handling issue
Date: Wed, 23 Feb 2022 17:36:30 +0000	[thread overview]
Message-ID: <20220223173630.2951400-1-megha.ajmera@intel.com> (raw)
In-Reply-To: <20220222131851.2944637-1-megha.ajmera@intel.com>

Masking of core mask was incorrect. Instead of using 1U for shifting, it
should be using 1LU as the result is assigned to uint64.

CID 375859: Potentially overflowing expression "1U << app_main_core" with
type "unsigned int" (32 bits, unsigned) is evaluated using 32-bit
arithmetic, and then used in a context that expects an expression of
type "uint64_t" (64 bits, unsigned).

Coverity issue: 375859

Signed-off-by: Megha Ajmera <megha.ajmera@intel.com>
---
 examples/qos_sched/args.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c
index 10ca7bea61..562d9ca150 100644
--- a/examples/qos_sched/args.c
+++ b/examples/qos_sched/args.c
@@ -427,13 +427,13 @@ app_parse_args(int argc, char **argv)
 
 	/* check main core index validity */
 	for (i = 0; i <= app_main_core; i++) {
-		if (app_used_core_mask & (1u << app_main_core)) {
+		if (app_used_core_mask & (RTE_BIT64(app_main_core))) {
 			RTE_LOG(ERR, APP, "Main core index is not configured properly\n");
 			app_usage(prgname);
 			return -1;
 		}
 	}
-	app_used_core_mask |= 1u << app_main_core;
+	app_used_core_mask |= RTE_BIT64(app_main_core);
 
 	if ((app_used_core_mask != app_eal_core_mask()) ||
 			(app_main_core != rte_get_main_lcore())) {
-- 
2.25.1


  parent reply	other threads:[~2022-02-23 17:41 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-22 13:18 [PATCH] " Megha Ajmera
2022-02-22 14:13 ` Morten Brørup
2022-02-22 16:03   ` Stephen Hemminger
2022-02-22 18:55     ` Ajmera, Megha
2022-02-23  7:17     ` Morten Brørup
2022-02-23 10:03       ` Ferruh Yigit
2022-02-23 10:42         ` more than 64 lcores not properly supported Morten Brørup
2022-02-23 11:20           ` Ferruh Yigit
2022-02-23 13:49             ` Thomas Monjalon
2022-02-23 15:12               ` Stephen Hemminger
2022-02-23 17:36 ` Megha Ajmera [this message]
2022-02-23 18:13   ` [PATCH v2] sched: fix integer handling issue Morten Brørup
2022-02-24 22:51     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220223173630.2951400-1-megha.ajmera@intel.com \
    --to=megha.ajmera@intel.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=mb@smartsharesystems.com \
    --cc=sham.singh.thakur@intel.com \
    --cc=stephen@networkplumber.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).