* RE: [PATCH] net/ice/base: support E824S and E825 devices
2021-12-29 9:25 [PATCH] net/ice/base: support E824S and E825 devices Robin Zhang
@ 2022-01-25 1:29 ` Zhang, Qi Z
2022-01-25 14:50 ` Ferruh Yigit
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Zhang, Qi Z @ 2022-01-25 1:29 UTC (permalink / raw)
To: Zhang, RobinX, dev; +Cc: Yang, Qiming, Guo, Junfeng, Yang, SteveX
> -----Original Message-----
> From: Zhang, RobinX <robinx.zhang@intel.com>
> Sent: Wednesday, December 29, 2021 5:26 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Guo, Junfeng <junfeng.guo@intel.com>; Yang,
> SteveX <stevex.yang@intel.com>; Zhang, RobinX <robinx.zhang@intel.com>
> Subject: [PATCH] net/ice/base: support E824S and E825 devices
>
> Add support for E824S and E825 family devices.
>
> Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] net/ice/base: support E824S and E825 devices
2021-12-29 9:25 [PATCH] net/ice/base: support E824S and E825 devices Robin Zhang
2022-01-25 1:29 ` Zhang, Qi Z
@ 2022-01-25 14:50 ` Ferruh Yigit
2022-02-15 11:15 ` Ferruh Yigit
2022-02-16 7:45 ` [PATCH v2] " Robin Zhang
2022-02-25 2:00 ` [PATCH v3] " Robin Zhang
3 siblings, 1 reply; 9+ messages in thread
From: Ferruh Yigit @ 2022-01-25 14:50 UTC (permalink / raw)
To: Robin Zhang, dev; +Cc: qiming.yang, qi.z.zhang, junfeng.guo, stevex.yang
On 12/29/2021 9:25 AM, Robin Zhang wrote:
> Add support for E824S and E825 family devices.
>
> Signed-off-by: Robin Zhang<robinx.zhang@intel.com>
What do you think documenting these new device support on release notes?
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] net/ice/base: support E824S and E825 devices
2022-01-25 14:50 ` Ferruh Yigit
@ 2022-02-15 11:15 ` Ferruh Yigit
0 siblings, 0 replies; 9+ messages in thread
From: Ferruh Yigit @ 2022-02-15 11:15 UTC (permalink / raw)
To: Robin Zhang, dev; +Cc: qiming.yang, qi.z.zhang, junfeng.guo, stevex.yang
On 1/25/2022 2:50 PM, Ferruh Yigit wrote:
> On 12/29/2021 9:25 AM, Robin Zhang wrote:
>> Add support for E824S and E825 family devices.
>>
>> Signed-off-by: Robin Zhang<robinx.zhang@intel.com>
>
> What do you think documenting these new device support on release notes?
Hi Qi,
There was a change request on this patch, it is
still pending, is it missed?
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] net/ice/base: support E824S and E825 devices
2021-12-29 9:25 [PATCH] net/ice/base: support E824S and E825 devices Robin Zhang
2022-01-25 1:29 ` Zhang, Qi Z
2022-01-25 14:50 ` Ferruh Yigit
@ 2022-02-16 7:45 ` Robin Zhang
2022-02-23 2:42 ` Zhang, Qi Z
2022-02-25 2:00 ` [PATCH v3] " Robin Zhang
3 siblings, 1 reply; 9+ messages in thread
From: Robin Zhang @ 2022-02-16 7:45 UTC (permalink / raw)
To: dev; +Cc: qiming.yang, qi.z.zhang, junfeng.guo, stevex.yang, Robin Zhang
Add support for E824S and E825 family devices.
Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
---
doc/guides/rel_notes/release_22_03.rst | 4 ++++
drivers/net/ice/base/ice_common.c | 6 ++++++
drivers/net/ice/base/ice_devids.h | 13 +++++++++++++
drivers/net/ice/ice_ethdev.c | 6 ++++++
4 files changed, 29 insertions(+)
diff --git a/doc/guides/rel_notes/release_22_03.rst b/doc/guides/rel_notes/release_22_03.rst
index 41923f50e6..63df1c78da 100644
--- a/doc/guides/rel_notes/release_22_03.rst
+++ b/doc/guides/rel_notes/release_22_03.rst
@@ -118,6 +118,10 @@ New Features
* Added PPPoL2TPv2oUDP FDIR distribute packets based on inner IP
src/dst address and UDP/TCP src/dst port.
+* **Updated the Intel ice driver.**
+
+ * Added new device IDs to support E824S and E825 devices.
+
* **Updated Wangxun ngbe driver.**
* Added support for devices of custom PHY interfaces.
diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c
index ae55bebaa2..db87bacd97 100644
--- a/drivers/net/ice/base/ice_common.c
+++ b/drivers/net/ice/base/ice_common.c
@@ -167,6 +167,12 @@ static enum ice_status ice_set_mac_type(struct ice_hw *hw)
case ICE_DEV_ID_E823C_QSFP:
case ICE_DEV_ID_E823C_SFP:
case ICE_DEV_ID_E823C_SGMII:
+ case ICE_DEV_ID_E824S:
+ case ICE_DEV_ID_E825C_BACKPLANE:
+ case ICE_DEV_ID_E825C_QSFP:
+ case ICE_DEV_ID_E825C_SFP:
+ case ICE_DEV_ID_E825C_1GBE:
+ case ICE_DEV_ID_E825X:
hw->mac_type = ICE_MAC_GENERIC;
break;
default:
diff --git a/drivers/net/ice/base/ice_devids.h b/drivers/net/ice/base/ice_devids.h
index e52bb71403..96f2528c5e 100644
--- a/drivers/net/ice/base/ice_devids.h
+++ b/drivers/net/ice/base/ice_devids.h
@@ -58,5 +58,18 @@
#define ICE_DEV_ID_E822L_10G_BASE_T 0x1899
/* Intel(R) Ethernet Connection E822-L 1GbE */
#define ICE_DEV_ID_E822L_SGMII 0x189A
+/* Intel(R) Ethernet Connection E824-S */
+#define ICE_DEV_ID_E824S 0x0DBD
+/* Intel(R) Ethernet Connection E825-C for backplane */
+#define ICE_DEV_ID_E825C_BACKPLANE 0x579C
+/* Intel(R) Ethernet Connection E825-C for QSFP */
+#define ICE_DEV_ID_E825C_QSFP 0x579D
+/* Intel(R) Ethernet Connection E825-C for SFP */
+#define ICE_DEV_ID_E825C_SFP 0x579E
+/* Intel(R) Ethernet Connection E825-C 1GbE */
+#define ICE_DEV_ID_E825C_1GBE 0x579F
+/* Intel(R) Ethernet Connection E825-X */
+#define ICE_DEV_ID_E825X 0x0DCD
+
#endif /* _ICE_DEVIDS_H_ */
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 1a469afeac..13adcf90ed 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -196,6 +196,12 @@ static const struct rte_pci_id pci_id_ice_map[] = {
{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E822L_SFP) },
{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E822L_10G_BASE_T) },
{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E822L_SGMII) },
+ { RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E824S) },
+ { RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825C_BACKPLANE) },
+ { RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825C_QSFP) },
+ { RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825C_SFP) },
+ { RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825C_1GBE) },
+ { RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825X) },
{ .vendor_id = 0, /* sentinel */ },
};
--
2.25.1
^ permalink raw reply [flat|nested] 9+ messages in thread* RE: [PATCH v2] net/ice/base: support E824S and E825 devices
2022-02-16 7:45 ` [PATCH v2] " Robin Zhang
@ 2022-02-23 2:42 ` Zhang, Qi Z
2022-02-24 11:37 ` Ferruh Yigit
0 siblings, 1 reply; 9+ messages in thread
From: Zhang, Qi Z @ 2022-02-23 2:42 UTC (permalink / raw)
To: Zhang, RobinX, dev; +Cc: Yang, Qiming, Guo, Junfeng, Yang, SteveX
> -----Original Message-----
> From: Zhang, RobinX <robinx.zhang@intel.com>
> Sent: Wednesday, February 16, 2022 3:45 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Guo, Junfeng <junfeng.guo@intel.com>; Yang, SteveX
> <stevex.yang@intel.com>; Zhang, RobinX <robinx.zhang@intel.com>
> Subject: [PATCH v2] net/ice/base: support E824S and E825 devices
>
> Add support for E824S and E825 family devices.
>
> Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH v2] net/ice/base: support E824S and E825 devices
2022-02-23 2:42 ` Zhang, Qi Z
@ 2022-02-24 11:37 ` Ferruh Yigit
0 siblings, 0 replies; 9+ messages in thread
From: Ferruh Yigit @ 2022-02-24 11:37 UTC (permalink / raw)
To: Zhang, Qi Z, Zhang, RobinX, dev
Cc: Yang, Qiming, Guo, Junfeng, Yang, SteveX, John McNamara
On 2/23/2022 2:42 AM, Zhang, Qi Z wrote:
>
>
>> -----Original Message-----
>> From: Zhang, RobinX <robinx.zhang@intel.com>
>> Sent: Wednesday, February 16, 2022 3:45 PM
>> To: dev@dpdk.org
>> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
>> <qi.z.zhang@intel.com>; Guo, Junfeng <junfeng.guo@intel.com>; Yang, SteveX
>> <stevex.yang@intel.com>; Zhang, RobinX <robinx.zhang@intel.com>
>> Subject: [PATCH v2] net/ice/base: support E824S and E825 devices
>>
>> Add support for E824S and E825 family devices.
>>
>> Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Applied to dpdk-next-net-intel.
>
Hi Qi, Robin,
The apply note is on v2, but v1 seems merged to your tree,
omitting release notes update (which was the request on v1).
I guess you don't want to document it in release notes
since devices are still under test and it will be
documented later when device support is matured, is this
correct?
If so can you please clarify this in the commit log with
a new version of patch?
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v3] net/ice/base: support E824S and E825 devices
2021-12-29 9:25 [PATCH] net/ice/base: support E824S and E825 devices Robin Zhang
` (2 preceding siblings ...)
2022-02-16 7:45 ` [PATCH v2] " Robin Zhang
@ 2022-02-25 2:00 ` Robin Zhang
2022-02-25 14:07 ` Ferruh Yigit
3 siblings, 1 reply; 9+ messages in thread
From: Robin Zhang @ 2022-02-25 2:00 UTC (permalink / raw)
To: dev, qiming.yang, qi.z.zhang, junfeng.guo, stevex.yang; +Cc: Robin Zhang
Add support for E824S and E825 family devices.
This will be documented later in release notes due to we don't have
mature product now.
Signed-off-by: Robin Zhang <robinx.zhang@intel.com>
---
v3:
- refine commit message.
drivers/net/ice/base/ice_common.c | 6 ++++++
drivers/net/ice/base/ice_devids.h | 13 +++++++++++++
drivers/net/ice/ice_ethdev.c | 6 ++++++
3 files changed, 25 insertions(+)
diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c
index ae55bebaa2..db87bacd97 100644
--- a/drivers/net/ice/base/ice_common.c
+++ b/drivers/net/ice/base/ice_common.c
@@ -167,6 +167,12 @@ static enum ice_status ice_set_mac_type(struct ice_hw *hw)
case ICE_DEV_ID_E823C_QSFP:
case ICE_DEV_ID_E823C_SFP:
case ICE_DEV_ID_E823C_SGMII:
+ case ICE_DEV_ID_E824S:
+ case ICE_DEV_ID_E825C_BACKPLANE:
+ case ICE_DEV_ID_E825C_QSFP:
+ case ICE_DEV_ID_E825C_SFP:
+ case ICE_DEV_ID_E825C_1GBE:
+ case ICE_DEV_ID_E825X:
hw->mac_type = ICE_MAC_GENERIC;
break;
default:
diff --git a/drivers/net/ice/base/ice_devids.h b/drivers/net/ice/base/ice_devids.h
index e52bb71403..96f2528c5e 100644
--- a/drivers/net/ice/base/ice_devids.h
+++ b/drivers/net/ice/base/ice_devids.h
@@ -58,5 +58,18 @@
#define ICE_DEV_ID_E822L_10G_BASE_T 0x1899
/* Intel(R) Ethernet Connection E822-L 1GbE */
#define ICE_DEV_ID_E822L_SGMII 0x189A
+/* Intel(R) Ethernet Connection E824-S */
+#define ICE_DEV_ID_E824S 0x0DBD
+/* Intel(R) Ethernet Connection E825-C for backplane */
+#define ICE_DEV_ID_E825C_BACKPLANE 0x579C
+/* Intel(R) Ethernet Connection E825-C for QSFP */
+#define ICE_DEV_ID_E825C_QSFP 0x579D
+/* Intel(R) Ethernet Connection E825-C for SFP */
+#define ICE_DEV_ID_E825C_SFP 0x579E
+/* Intel(R) Ethernet Connection E825-C 1GbE */
+#define ICE_DEV_ID_E825C_1GBE 0x579F
+/* Intel(R) Ethernet Connection E825-X */
+#define ICE_DEV_ID_E825X 0x0DCD
+
#endif /* _ICE_DEVIDS_H_ */
diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 1a469afeac..13adcf90ed 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -196,6 +196,12 @@ static const struct rte_pci_id pci_id_ice_map[] = {
{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E822L_SFP) },
{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E822L_10G_BASE_T) },
{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E822L_SGMII) },
+ { RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E824S) },
+ { RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825C_BACKPLANE) },
+ { RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825C_QSFP) },
+ { RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825C_SFP) },
+ { RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825C_1GBE) },
+ { RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825X) },
{ .vendor_id = 0, /* sentinel */ },
};
--
2.25.1
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH v3] net/ice/base: support E824S and E825 devices
2022-02-25 2:00 ` [PATCH v3] " Robin Zhang
@ 2022-02-25 14:07 ` Ferruh Yigit
0 siblings, 0 replies; 9+ messages in thread
From: Ferruh Yigit @ 2022-02-25 14:07 UTC (permalink / raw)
To: Robin Zhang, dev, qiming.yang, qi.z.zhang, junfeng.guo, stevex.yang
On 2/25/2022 2:00 AM, Robin Zhang wrote:
> Add support for E824S and E825 family devices.
>
> This will be documented later in release notes due to we don't have
> mature product now.
>
> Signed-off-by: Robin Zhang<robinx.zhang@intel.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread