* [PATCH] compress/mlx5: support out-of-space status
@ 2022-02-23 13:31 Raja Zidane
2022-02-27 14:00 ` [PATCH V2] " Raja Zidane
0 siblings, 1 reply; 3+ messages in thread
From: Raja Zidane @ 2022-02-23 13:31 UTC (permalink / raw)
To: dev; +Cc: matan, stable
When trying to dequeue, an OP may fail due to insufficient space for the
OP output, the compressdev API defines out-of-space for OP status.
The driver can detect out-of-space errors and report them to the user.
Check if hw_error_syndrome specifies out-of-space and set the OP
status accordingly.
Also added an error message for a case of missing B-final flag.
Fixes: f8c97babc9f4 ("compress/mlx5: add data-path functions")
Cc: stable@dpdk.org
Signed-off-by: Raja Zidane <rzidane@nvidia.com>
---
Acked-by: Matan Azrad matan@nvidia.com
drivers/common/mlx5/mlx5_prm.h | 5 +++++
drivers/compress/mlx5/mlx5_compress.c | 12 +++++++++++-
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h
index 495b63191a..fc05734ecd 100644
--- a/drivers/common/mlx5/mlx5_prm.h
+++ b/drivers/common/mlx5/mlx5_prm.h
@@ -249,6 +249,9 @@
/* Maximum number of DS in WQE. Limited by 6-bit field. */
#define MLX5_DSEG_MAX 63
+/* The 32 bit syndrome offset in struct mlx5_err_cqe. */
+#define MLX5_ERROR_CQE_SYNDROME_OFFSET 52
+
/* The completion mode offset in the WQE control segment line 2. */
#define MLX5_COMP_MODE_OFFSET 2
@@ -559,6 +562,8 @@ struct mlx5_rdma_write_wqe {
#define MLX5_GGA_COMP_LOG_BLOCK_SIZE_MAX 15u
#define MLX5_GGA_COMP_LOG_DYNAMIC_SIZE_MAX 15u
#define MLX5_GGA_COMP_LOG_DYNAMIC_SIZE_MIN 0u
+#define MLX5_GGA_COMP_OUT_OF_SPACE_SYNDROME_BE 0x29D0084
+#define MLX5_GGA_COMP_MISSING_BFINAL_SYNDROME_BE 0x29D0011
struct mlx5_wqe_metadata_seg {
uint32_t mmo_control_31_0; /* mmo_control_63_32 is in ctrl_seg.imm */
diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compress/mlx5/mlx5_compress.c
index 7a482c3fbb..fc50b5bde9 100644
--- a/drivers/compress/mlx5/mlx5_compress.c
+++ b/drivers/compress/mlx5/mlx5_compress.c
@@ -562,7 +562,17 @@ mlx5_compress_cqe_err_handle(struct mlx5_compress_qp *qp,
qp->qp.wqes;
volatile struct mlx5_gga_compress_opaque *opaq = qp->opaque_mr.addr;
- op->status = RTE_COMP_OP_STATUS_ERROR;
+ volatile uint32_t *synd_word = RTE_PTR_ADD(cqe, MLX5_ERROR_CQE_SYNDROME_OFFSET);
+ switch (*synd_word) {
+ case MLX5_GGA_COMP_OUT_OF_SPACE_SYNDROME_BE:
+ op->status = RTE_COMP_OP_STATUS_OUT_OF_SPACE_TERMINATED;
+ DRV_LOG(DEBUG, "OUT OF SPACE error, output is bigger than dst buffer.");
+ break;
+ case MLX5_GGA_COMP_MISSING_BFINAL_SYNDROME_BE:
+ DRV_LOG(DEBUG, "The last compressed block missed the B-final flag; maybe the compressed data is not complete or garbaged?");
+ default:
+ op->status = RTE_COMP_OP_STATUS_ERROR;
+ }
op->consumed = 0;
op->produced = 0;
op->output_chksum = 0;
--
2.21.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH V2] compress/mlx5: support out-of-space status
2022-02-23 13:31 [PATCH] compress/mlx5: support out-of-space status Raja Zidane
@ 2022-02-27 14:00 ` Raja Zidane
2022-03-04 9:47 ` [EXT] " Akhil Goyal
0 siblings, 1 reply; 3+ messages in thread
From: Raja Zidane @ 2022-02-27 14:00 UTC (permalink / raw)
To: dev; +Cc: matan, stable
When trying to dequeue, an OP may fail due to insufficient space for the
OP output, the compressdev API defines out-of-space for OP status.
The driver can detect out-of-space errors and report them to the user.
Check if hw_error_syndrome specifies out-of-space and set the OP
status accordingly.
Also added an error message for a case of missing B-final flag.
Fixes: f8c97babc9f4 ("compress/mlx5: add data-path functions")
Cc: stable@dpdk.org
Signed-off-by: Raja Zidane <rzidane@nvidia.com>
---
Acked-by: Matan Azrad <matan@nvidia.com>
V2: fix implicit switch-case fallthrough
drivers/common/mlx5/mlx5_prm.h | 5 +++++
drivers/compress/mlx5/mlx5_compress.c | 13 ++++++++++++-
2 files changed, 17 insertions(+), 1 deletion(-)
diff --git a/drivers/common/mlx5/mlx5_prm.h b/drivers/common/mlx5/mlx5_prm.h
index ce3e47059f..44b18225f6 100644
--- a/drivers/common/mlx5/mlx5_prm.h
+++ b/drivers/common/mlx5/mlx5_prm.h
@@ -262,6 +262,9 @@
/* Maximum number of DS in WQE. Limited by 6-bit field. */
#define MLX5_DSEG_MAX 63
+/* The 32 bit syndrome offset in struct mlx5_err_cqe. */
+#define MLX5_ERROR_CQE_SYNDROME_OFFSET 52
+
/* The completion mode offset in the WQE control segment line 2. */
#define MLX5_COMP_MODE_OFFSET 2
@@ -581,6 +584,8 @@ struct mlx5_rdma_write_wqe {
#define MLX5_GGA_COMP_LOG_BLOCK_SIZE_MAX 15u
#define MLX5_GGA_COMP_LOG_DYNAMIC_SIZE_MAX 15u
#define MLX5_GGA_COMP_LOG_DYNAMIC_SIZE_MIN 0u
+#define MLX5_GGA_COMP_OUT_OF_SPACE_SYNDROME_BE 0x29D0084
+#define MLX5_GGA_COMP_MISSING_BFINAL_SYNDROME_BE 0x29D0011
struct mlx5_wqe_metadata_seg {
uint32_t mmo_control_31_0; /* mmo_control_63_32 is in ctrl_seg.imm */
diff --git a/drivers/compress/mlx5/mlx5_compress.c b/drivers/compress/mlx5/mlx5_compress.c
index 7a482c3fbb..d64a628c74 100644
--- a/drivers/compress/mlx5/mlx5_compress.c
+++ b/drivers/compress/mlx5/mlx5_compress.c
@@ -562,7 +562,18 @@ mlx5_compress_cqe_err_handle(struct mlx5_compress_qp *qp,
qp->qp.wqes;
volatile struct mlx5_gga_compress_opaque *opaq = qp->opaque_mr.addr;
- op->status = RTE_COMP_OP_STATUS_ERROR;
+ volatile uint32_t *synd_word = RTE_PTR_ADD(cqe, MLX5_ERROR_CQE_SYNDROME_OFFSET);
+ switch (*synd_word) {
+ case MLX5_GGA_COMP_OUT_OF_SPACE_SYNDROME_BE:
+ op->status = RTE_COMP_OP_STATUS_OUT_OF_SPACE_TERMINATED;
+ DRV_LOG(DEBUG, "OUT OF SPACE error, output is bigger than dst buffer.");
+ break;
+ case MLX5_GGA_COMP_MISSING_BFINAL_SYNDROME_BE:
+ DRV_LOG(DEBUG, "The last compressed block missed the B-final flag; maybe the compressed data is not complete or garbaged?");
+ /* fallthrough */
+ default:
+ op->status = RTE_COMP_OP_STATUS_ERROR;
+ }
op->consumed = 0;
op->produced = 0;
op->output_chksum = 0;
--
2.21.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [EXT] [PATCH V2] compress/mlx5: support out-of-space status
2022-02-27 14:00 ` [PATCH V2] " Raja Zidane
@ 2022-03-04 9:47 ` Akhil Goyal
0 siblings, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2022-03-04 9:47 UTC (permalink / raw)
To: Raja Zidane, dev; +Cc: matan, stable
> When trying to dequeue, an OP may fail due to insufficient space for the
> OP output, the compressdev API defines out-of-space for OP status.
> The driver can detect out-of-space errors and report them to the user.
>
> Check if hw_error_syndrome specifies out-of-space and set the OP
> status accordingly.
> Also added an error message for a case of missing B-final flag.
>
> Fixes: f8c97babc9f4 ("compress/mlx5: add data-path functions")
> Cc: stable@dpdk.org
>
> Signed-off-by: Raja Zidane <rzidane@nvidia.com>
> ---
> Acked-by: Matan Azrad <matan@nvidia.com>
Applied to dpdk-next-crypto
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-04 9:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-23 13:31 [PATCH] compress/mlx5: support out-of-space status Raja Zidane
2022-02-27 14:00 ` [PATCH V2] " Raja Zidane
2022-03-04 9:47 ` [EXT] " Akhil Goyal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).