From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57767A0350; Mon, 28 Feb 2022 18:08:11 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1CA984068C; Mon, 28 Feb 2022 18:08:11 +0100 (CET) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 1A5D540140 for ; Mon, 28 Feb 2022 18:08:10 +0100 (CET) Received: by mail-pj1-f51.google.com with SMTP id em10-20020a17090b014a00b001bc3071f921so15304762pjb.5 for ; Mon, 28 Feb 2022 09:08:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hFWyHBXs6fSUHZMI438lmrxf2ZOiuhk/Q6ieE7pAo8s=; b=wLrIziHJ2r7FMKDeKYdCFsPRLUsgRBUcC6NZNb7HZRWC0q200SeuZI7sLtrXqj9IsQ 2YO6goytK409rK/TeNoafcADEEaEDBumrcuEFHD8puvfVehaxd4LEO/qtANB3XhfLJcc T5vO7fWpVaGrUnkBTqw/WfT1/RyzgBO4hYKslHKb3ITx4v8Hw6Ba5YbduWLgJz/mAc6T DcdpGiYrR8UwIjhxtKmvL0SWEn5o3CiSa40yjZGMoldLLTlqJa4Flmy6GWI08zBnphr0 R0vDWM7FKfMY7Q1HJOETmoCnUzFy8QVqGcwGR2vQRqiUBcLHDda21HDgC6SERGgJupYd 8dgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hFWyHBXs6fSUHZMI438lmrxf2ZOiuhk/Q6ieE7pAo8s=; b=IUz0TVNtPp1GA6wnk/yKNZ4dAThY8AXL4U5Boh+fjqoQCgEGhz5hOZjG+04kEI9HHT uck5oV/n74cuHGDheulFynvr1lG1ctOW9DEqp1MSOhlvSGWaus3pp1rD3Nz2w4hF+4H7 AgJTDoMCe5tQZbHXhdTG56xypUgPeF0TQdrCeFyl0GnVFiFPSxoq9K8vG7TxtRZ2DS8k i5pHTLba8dcR9YHVFq7wMOWoXbXPx5a0zMVuJFDcRY506WlET4RimYBFa3TdooWYMBQx rOSvLO4osrh+ql2CkJMg3qyZe/YOk9tuyWfxag91MvdAx/rqjkYLn6a4k9mrDuyDCLnK Q+hg== X-Gm-Message-State: AOAM531toCsl+5ys931YBXcSvfLhPz6EYEfYOl9XAaAFvNRK0G2B3DR4 KF2gi8642j1tl0TK/MYmqlfD0A== X-Google-Smtp-Source: ABdhPJyUImLsXRY/Q5dyR5bLK5/myUyIkAglH8odpEklm68sHgKlbiWUU6Iqn4DPjuq5RTPGM0P8QQ== X-Received: by 2002:a17:902:b715:b0:14d:bb53:da0 with SMTP id d21-20020a170902b71500b0014dbb530da0mr21268761pls.18.1646068088815; Mon, 28 Feb 2022 09:08:08 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id y17-20020a63ce11000000b0036c96df445fsm10625360pgf.53.2022.02.28.09.08.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Feb 2022 09:08:08 -0800 (PST) Date: Mon, 28 Feb 2022 09:08:05 -0800 From: Stephen Hemminger To: Bruce Richardson Cc: Thomas Monjalon , dev@dpdk.org Subject: Re: [PATCH v3 4/8] lib: document existing free functions Message-ID: <20220228090805.6730fcee@hermes.local> In-Reply-To: References: <20220219234322.61309-1-stephen@networkplumber.org> <20220220182147.9750-1-stephen@networkplumber.org> <20220220182147.9750-5-stephen@networkplumber.org> <3949827.atdPhlSkOF@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, 28 Feb 2022 09:42:47 +0000 Bruce Richardson wrote: > On Sun, Feb 27, 2022 at 09:48:57PM +0100, Thomas Monjalon wrote: > > 20/02/2022 19:21, Stephen Hemminger: > > > + * If NULL then, the function does nothing. > > > > I'm not English native, but I thought it should be one of these 2 forms: > > - If NULL, the function does nothing. > > - If NULL then the function does nothing. > > > I would agree, and also would tend toward the first version. > > /Bruce Either one. I was just copy/pasting pre-existing grammar problem.