* [PATCH] crypto/qat: fix structurally dead code
@ 2022-02-28 16:05 Arek Kusztal
2022-03-04 10:07 ` [EXT] " Akhil Goyal
2022-03-08 11:09 ` Zhang, Roy Fan
0 siblings, 2 replies; 3+ messages in thread
From: Arek Kusztal @ 2022-02-28 16:05 UTC (permalink / raw)
To: dev; +Cc: gakhil, roy.fan.zhang, Arek Kusztal
This patch fixes structurally dead code in QAT
asym pmd.
Coverity issue: 376563
Fixes: ef2f4238a04d ("crypto/qat: refactor asymmetric session")
Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
drivers/crypto/qat/qat_asym.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qat_asym.c
index badf018f13..1e4304a3c0 100644
--- a/drivers/crypto/qat/qat_asym.c
+++ b/drivers/crypto/qat/qat_asym.c
@@ -1183,7 +1183,6 @@ session_clear_modinv(struct rte_crypto_modinv_xform *modinv)
static void
session_clear_rsa(struct rte_crypto_rsa_xform *rsa)
{
- return;
memset(rsa->n.data, 0, rsa->n.length);
rte_free(rsa->n.data);
memset(rsa->e.data, 0, rsa->e.length);
--
2.13.6
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [EXT] [PATCH] crypto/qat: fix structurally dead code
2022-02-28 16:05 [PATCH] crypto/qat: fix structurally dead code Arek Kusztal
@ 2022-03-04 10:07 ` Akhil Goyal
2022-03-08 11:09 ` Zhang, Roy Fan
1 sibling, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2022-03-04 10:07 UTC (permalink / raw)
To: Arek Kusztal, dev; +Cc: roy.fan.zhang
> This patch fixes structurally dead code in QAT
> asym pmd.
>
> Coverity issue: 376563
> Fixes: ef2f4238a04d ("crypto/qat: refactor asymmetric session")
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Applied to dpdk-next-crypto
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: [PATCH] crypto/qat: fix structurally dead code
2022-02-28 16:05 [PATCH] crypto/qat: fix structurally dead code Arek Kusztal
2022-03-04 10:07 ` [EXT] " Akhil Goyal
@ 2022-03-08 11:09 ` Zhang, Roy Fan
1 sibling, 0 replies; 3+ messages in thread
From: Zhang, Roy Fan @ 2022-03-08 11:09 UTC (permalink / raw)
To: Kusztal, ArkadiuszX, dev; +Cc: gakhil
> -----Original Message-----
> From: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Sent: Monday, February 28, 2022 4:06 PM
> To: dev@dpdk.org
> Cc: gakhil@marvell.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>; Kusztal,
> ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH] crypto/qat: fix structurally dead code
>
> This patch fixes structurally dead code in QAT
> asym pmd.
>
> Coverity issue: 376563
> Fixes: ef2f4238a04d ("crypto/qat: refactor asymmetric session")
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> drivers/crypto/qat/qat_asym.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/crypto/qat/qat_asym.c b/drivers/crypto/qat/qat_asym.c
> index badf018f13..1e4304a3c0 100644
> --- a/drivers/crypto/qat/qat_asym.c
> +++ b/drivers/crypto/qat/qat_asym.c
> @@ -1183,7 +1183,6 @@ session_clear_modinv(struct
> rte_crypto_modinv_xform *modinv)
> static void
> session_clear_rsa(struct rte_crypto_rsa_xform *rsa)
> {
> - return;
> memset(rsa->n.data, 0, rsa->n.length);
> rte_free(rsa->n.data);
> memset(rsa->e.data, 0, rsa->e.length);
> --
> 2.13.6
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-03-08 11:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-02-28 16:05 [PATCH] crypto/qat: fix structurally dead code Arek Kusztal
2022-03-04 10:07 ` [EXT] " Akhil Goyal
2022-03-08 11:09 ` Zhang, Roy Fan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).