From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, Ray Kinsella <mdr@ashroe.eu>
Subject: [PATCH 2/2] devtools: use libabigail rule for mlx glue drivers
Date: Tue, 1 Mar 2022 17:54:04 +0100 [thread overview]
Message-ID: <20220301165404.18936-2-david.marchand@redhat.com> (raw)
In-Reply-To: <20220301165404.18936-1-david.marchand@redhat.com>
Convert the existing exception in the ABI script into a libabigail
suppression rule.
Note: file_name_regexp could be used to achive the same with versions of
libabigail < 1.7 but soname_regexp has been preferred here since it is
already used with a recent change on common/mlx5.
While at it, fix indent from a recent change.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
devtools/check-abi.sh | 7 -------
devtools/libabigail.abignore | 8 ++++++--
2 files changed, 6 insertions(+), 9 deletions(-)
diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh
index 033f6252d0..64e148070d 100755
--- a/devtools/check-abi.sh
+++ b/devtools/check-abi.sh
@@ -37,13 +37,6 @@ fi
error=
for dump in $(find $refdir -name "*.dump"); do
name=$(basename $dump)
- # skip glue drivers, example librte_pmd_mlx5_glue.dump
- # We can't rely on a suppression rule for now:
- # https://sourceware.org/bugzilla/show_bug.cgi?id=25480
- if grep -qE "\<soname='[^']*_glue\.so\.[^']*'" $dump; then
- echo "Skipped glue library $name."
- continue
- fi
if grep -qE "\<librte_*.*_octeontx2" $dump; then
echo "Skipped removed driver $name."
continue
diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
index 301b3dacb8..9c921c47d4 100644
--- a/devtools/libabigail.abignore
+++ b/devtools/libabigail.abignore
@@ -12,10 +12,14 @@
[suppress_variable]
name_regexp = _pmd_info$
+; Ignore changes on soname for mlx glue internal drivers
+[suppress_file]
+ soname_regexp = ^librte_.*mlx.*glue\.
+
; Ignore fields inserted in place of reserved_opts of rte_security_ipsec_sa_options
[suppress_type]
- name = rte_security_ipsec_sa_options
- has_data_member_inserted_between = {offset_of(reserved_opts), end}
+ name = rte_security_ipsec_sa_options
+ has_data_member_inserted_between = {offset_of(reserved_opts), end}
; Ignore changes to rte_crypto_asym_op, asymmetric crypto API is experimental
[suppress_type]
--
2.23.0
next prev parent reply other threads:[~2022-03-01 16:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-01 16:54 [PATCH 1/2] devtools: remove event/dlb exception in ABI check David Marchand
2022-03-01 16:54 ` David Marchand [this message]
2022-03-02 10:16 ` [PATCH 2/2] devtools: use libabigail rule for mlx glue drivers Ray Kinsella
2022-03-08 14:04 ` Thomas Monjalon
2022-03-02 10:13 ` [PATCH 1/2] devtools: remove event/dlb exception in ABI check Ray Kinsella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220301165404.18936-2-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=mdr@ashroe.eu \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).