From: Ke Zhang <ke1x.zhang@intel.com>
To: dev@dpdk.org, qiming.yang@intel.com, qi.z.zhang@intel.com
Cc: Ke Zhang <ke1x.zhang@intel.com>
Subject: [PATCH v6 2/4] net/ice: add support for display/reset stats by DCF
Date: Wed, 2 Mar 2022 06:30:50 +0000 [thread overview]
Message-ID: <20220302063052.347122-3-ke1x.zhang@intel.com> (raw)
In-Reply-To: <20220302063052.347122-1-ke1x.zhang@intel.com>
allow to display/reset VFs stats over VF0.
this feature need to update ice kernel driver (newer than v1.8.0)
Signed-off-by: Ke Zhang <ke1x.zhang@intel.com>
---
drivers/net/ice/ice_dcf_vf_representor.c | 129 +++++++++++++++++++++++
1 file changed, 129 insertions(+)
diff --git a/drivers/net/ice/ice_dcf_vf_representor.c b/drivers/net/ice/ice_dcf_vf_representor.c
index 781282f68c..765f5d4c95 100644
--- a/drivers/net/ice/ice_dcf_vf_representor.c
+++ b/drivers/net/ice/ice_dcf_vf_representor.c
@@ -10,6 +10,10 @@
#include "ice_dcf_ethdev.h"
#include "ice_rxtx.h"
+#define ICE_DCF_REPR_32_BIT_WIDTH (CHAR_BIT * 4)
+#define ICE_DCF_REPR_48_BIT_WIDTH (CHAR_BIT * 6)
+#define ICE_DCF_REPR_48_BIT_MASK RTE_LEN2MASK(ICE_DCF_REPR_48_BIT_WIDTH, uint64_t)
+
static __rte_always_inline struct ice_dcf_hw *
ice_dcf_vf_repr_hw(struct ice_dcf_vf_repr *repr)
{
@@ -409,6 +413,129 @@ ice_dcf_vf_repr_vlan_tpid_set(struct rte_eth_dev *dev,
return 0;
}
+static int
+ice_dcf_repr_query_stats(struct ice_dcf_hw *hw,
+ uint16_t vf_id, struct virtchnl_eth_stats *pstats)
+{
+ struct virtchnl_queue_select q_stats;
+ struct dcf_virtchnl_cmd args;
+ int err;
+
+ memset(&q_stats, 0, sizeof(q_stats));
+ q_stats.vsi_id = hw->vf_vsi_map[vf_id] & ~VIRTCHNL_DCF_VF_VSI_VALID;
+
+ args.v_op = VIRTCHNL_OP_GET_STATS;
+ args.req_msg = (uint8_t *)&q_stats;
+ args.req_msglen = sizeof(q_stats);
+ args.rsp_msglen = sizeof(struct virtchnl_eth_stats);
+ args.rsp_msgbuf = (uint8_t *)pstats;
+ args.rsp_buflen = sizeof(struct virtchnl_eth_stats);
+
+ err = ice_dcf_execute_virtchnl_cmd(hw, &args);
+ if (err) {
+ PMD_DRV_LOG(ERR, "fail to execute command OP_GET_STATS");
+ return err;
+ }
+
+ return 0;
+}
+
+static int
+ice_dcf_vf_repr_stats_reset(struct rte_eth_dev *dev)
+{
+ struct ice_dcf_vf_repr *repr = dev->data->dev_private;
+ struct ice_dcf_hw *hw = ice_dcf_vf_repr_hw(repr);
+ struct virtchnl_eth_stats pstats;
+ int ret;
+
+ if (hw->resetting)
+ return 0;
+
+ /* read stat values to clear hardware registers */
+ ret = ice_dcf_repr_query_stats(hw, repr->vf_id, &pstats);
+ if (ret != 0)
+ return ret;
+
+ /* set stats offset base on current values */
+ hw->eth_stats_offset = pstats;
+
+ return 0;
+}
+
+static void
+ice_dcf_stat_update_48(uint64_t *offset, uint64_t *stat)
+{
+ if (*stat >= *offset)
+ *stat = *stat - *offset;
+ else
+ *stat = (uint64_t)((*stat +
+ ((uint64_t)1 << ICE_DCF_REPR_48_BIT_WIDTH)) - *offset);
+
+ *stat &= ICE_DCF_REPR_48_BIT_MASK;
+}
+
+static void
+ice_dcf_stat_update_32(uint64_t *offset, uint64_t *stat)
+{
+ if (*stat >= *offset)
+ *stat = (uint64_t)(*stat - *offset);
+ else
+ *stat = (uint64_t)((*stat +
+ ((uint64_t)1 << ICE_DCF_REPR_32_BIT_WIDTH)) - *offset);
+}
+
+static void
+ice_dcf_update_stats(struct ice_dcf_hw *hw, struct virtchnl_eth_stats *nes)
+{
+ struct virtchnl_eth_stats *oes = &hw->eth_stats_offset;
+
+ ice_dcf_stat_update_48(&oes->rx_bytes, &nes->rx_bytes);
+ ice_dcf_stat_update_48(&oes->rx_unicast, &nes->rx_unicast);
+ ice_dcf_stat_update_48(&oes->rx_multicast, &nes->rx_multicast);
+ ice_dcf_stat_update_48(&oes->rx_broadcast, &nes->rx_broadcast);
+ ice_dcf_stat_update_32(&oes->rx_discards, &nes->rx_discards);
+ ice_dcf_stat_update_48(&oes->tx_bytes, &nes->tx_bytes);
+ ice_dcf_stat_update_48(&oes->tx_unicast, &nes->tx_unicast);
+ ice_dcf_stat_update_48(&oes->tx_multicast, &nes->tx_multicast);
+ ice_dcf_stat_update_48(&oes->tx_broadcast, &nes->tx_broadcast);
+ ice_dcf_stat_update_32(&oes->tx_errors, &nes->tx_errors);
+ ice_dcf_stat_update_32(&oes->tx_discards, &nes->tx_discards);
+}
+
+static int
+ice_dcf_vf_repr_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)
+{
+ struct ice_dcf_vf_repr *repr = dev->data->dev_private;
+ struct ice_dcf_hw *hw = ice_dcf_vf_repr_hw(repr);
+ struct virtchnl_eth_stats pstats;
+ int ret;
+
+ if (hw->resetting) {
+ PMD_DRV_LOG(ERR,
+ "The DCF has been reset by PF, please reinit first");
+ return -EIO;
+ }
+
+ ret = ice_dcf_repr_query_stats(hw, repr->vf_id, &pstats);
+ if (ret == 0) {
+ uint8_t crc_stats_len = (dev->data->dev_conf.rxmode.offloads &
+ RTE_ETH_RX_OFFLOAD_KEEP_CRC) ? 0 :
+ RTE_ETHER_CRC_LEN;
+ ice_dcf_update_stats(hw, &pstats);
+ stats->ipackets = pstats.rx_unicast + pstats.rx_multicast +
+ pstats.rx_broadcast - pstats.rx_discards;
+ stats->opackets = pstats.tx_broadcast + pstats.tx_multicast +
+ pstats.tx_unicast;
+ stats->imissed = pstats.rx_discards;
+ stats->oerrors = pstats.tx_errors + pstats.tx_discards;
+ stats->ibytes = pstats.rx_bytes;
+ stats->ibytes -= stats->ipackets * crc_stats_len;
+ stats->obytes = pstats.tx_bytes;
+ } else {
+ PMD_DRV_LOG(ERR, "Get statistics failed, ret:%d", ret);
+ }
+ return ret;
+}
static const struct eth_dev_ops ice_dcf_vf_repr_dev_ops = {
.dev_configure = ice_dcf_vf_repr_dev_configure,
.dev_start = ice_dcf_vf_repr_dev_start,
@@ -425,6 +552,8 @@ static const struct eth_dev_ops ice_dcf_vf_repr_dev_ops = {
.vlan_offload_set = ice_dcf_vf_repr_vlan_offload_set,
.vlan_pvid_set = ice_dcf_vf_repr_vlan_pvid_set,
.vlan_tpid_set = ice_dcf_vf_repr_vlan_tpid_set,
+ .stats_reset = ice_dcf_vf_repr_stats_reset,
+ .stats_get = ice_dcf_vf_repr_stats_get,
};
int
--
2.25.1
next prev parent reply other threads:[~2022-03-02 6:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 6:30 [PATCH v6 0/4] ice repr functions " Ke Zhang
2022-03-02 6:30 ` [PATCH v6 1/4] net/ice: add support for setting promisc " Ke Zhang
2022-03-02 9:14 ` David Marchand
2022-03-02 6:30 ` Ke Zhang [this message]
2022-03-02 6:30 ` [PATCH v6 3/4] net/ice: add support for add/remove mac addr " Ke Zhang
2022-03-02 6:30 ` [PATCH v6 4/4] net/ice: add support to configure the VLAN filter " Ke Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220302063052.347122-3-ke1x.zhang@intel.com \
--to=ke1x.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=qi.z.zhang@intel.com \
--cc=qiming.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).