From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ABD52A04A4; Wed, 2 Mar 2022 17:52:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 45B1B42715; Wed, 2 Mar 2022 17:52:29 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id DC5D140141 for ; Wed, 2 Mar 2022 17:52:27 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id ay5so2077274plb.1 for ; Wed, 02 Mar 2022 08:52:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CyScVy+HGQCZAgmn+u6jC8UtdqQ7baA1Wn5438Y+1jE=; b=jNtOHmzPjR7q3Ucx7TkaV+8y1cx5LvKydMnI9CoFZBbWMYhAthPnLYqvpPqQIn1ZE2 WNPHyjJznGIf3Q5F3DPAeVd1KYemE0wWOhHN3M9Wf2cwdzvlizvFwaHJtwDXoUl9M54m l6QLVoN050B+vF9GD4jidxCFViApfPrFhPd98FGiRmE87y+f21GmFK6/2lvZDYBzKs7o HZ4NXiuKLPtGNq44/L/QeAyEgb/HJPlculcI+iyQs096KGlJK8mHiNHAfLINdsVg4FZ+ Mf2dcHRLZRH+JA1YSddCK1kSMZ6/OLs59no7+AbHFFbDX5x6eiyEuZeT+X7im7mod9o/ 5sTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CyScVy+HGQCZAgmn+u6jC8UtdqQ7baA1Wn5438Y+1jE=; b=EudKVJu+z/1Ek6KPq8dz1HTkfc1bbcncEGsVSyFEUWwOy7MsGvoQJPOwyaB1HXFioL p1c6l1EmZZIUjO1vddf4jxyUVbwLHNAmwDcSqAn1wYi6/4St4u11hld9Qh7ak0L12VBG MwGnJeVX/8mgpR0ORkb1u6Ispluaz3njgIuDoCBsLC87k5QBrDej8I2Po6MBnaobEQuJ CEV124lJCLLO83FZG2gbrSzoWHF9cPM7HQBhSzSH5YwAcijx8+xoSLwJ8F+xyukh0AaM nhmMkzQhcZkW6Qf1EXTyOXBPxL//t5wN6QcaJZxIvsZX2OP5ESVTqQSBrDXXJXX3J/EC BtdA== X-Gm-Message-State: AOAM532B3PuKwkTRFIg/slSo1xJQEb3WbdV2a0Hg5nh6peZIKv7+TAQO DMEArcIxzALsUXDeDZHfou1Wlg== X-Google-Smtp-Source: ABdhPJz/phVIt2rOr3gV/z3Da3w/55WuJN01Axmoz8xtGmWTcMkc4EvhhVV3IKG6ZF9WqZRr0ovXRA== X-Received: by 2002:a17:902:cece:b0:150:3f2:4616 with SMTP id d14-20020a170902cece00b0015003f24616mr32135035plg.41.1646239946998; Wed, 02 Mar 2022 08:52:26 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id u9-20020a056a00158900b004de90b164d0sm23376982pfk.9.2022.03.02.08.52.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 08:52:26 -0800 (PST) Date: Wed, 2 Mar 2022 08:52:25 -0800 From: Stephen Hemminger To: "usman.tanveer" Cc: reshma.pattan@intel.com, dev@dpdk.org Subject: Re: [PATCH] app/pdump: close program if --pdump argument is missing Message-ID: <20220302085225.117b8570@hermes.local> In-Reply-To: <20220302092614.5164-1-usman.tanveer@emumba.com> References: <20220302092614.5164-1-usman.tanveer@emumba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 2 Mar 2022 14:26:14 +0500 "usman.tanveer" wrote: > --pdump is a mandatory argument in pdump application. > It should print usage and exit if --pdump argument > is missing. The application is not closing and getting > stuck. Made the change to print usage and exit when > this argument is missing. > > Signed-off-by: usman.tanveer Maybe pdump could just do something sane with no arguments. That is one of the issues I tried to address by rewriting it. Ideally, existing pdump can be deprecated and removed in 22.11?