From: "usman.tanveer" <usman.tanveer@emumba.com>
To: reshma.pattan@intel.com, stephen@networkplumber.org
Cc: dev@dpdk.org, "usman.tanveer" <usman.tanveer@emumba.com>
Subject: [PATCH] app/pdump: close program if --pdump argument is missing
Date: Wed, 2 Mar 2022 14:26:14 +0500 [thread overview]
Message-ID: <20220302092614.5164-1-usman.tanveer@emumba.com> (raw)
--pdump is a mandatory argument in pdump application.
It should print usage and exit if --pdump argument
is missing. The application is not closing and getting
stuck. Made the change to print usage and exit when
this argument is missing.
Signed-off-by: usman.tanveer <usman.tanveer@emumba.com>
---
app/pdump/main.c | 19 +++++++++++++------
1 file changed, 13 insertions(+), 6 deletions(-)
diff --git a/app/pdump/main.c b/app/pdump/main.c
index 04a38e8911..59a6846c65 100644
--- a/app/pdump/main.c
+++ b/app/pdump/main.c
@@ -383,14 +383,17 @@ launch_args_parse(int argc, char **argv, char *prgname)
{
int opt, ret;
int option_index;
+ bool pdump_flag = false;
static struct option long_option[] = {
{CMD_LINE_OPT_PDUMP, 1, 0, CMD_LINE_OPT_PDUMP_NUM},
{CMD_LINE_OPT_MULTI, 0, 0, CMD_LINE_OPT_MULTI_NUM},
{NULL, 0, 0, 0}
};
- if (argc == 1)
+ if (argc == 1) {
pdump_usage(prgname);
+ return -1;
+ }
/* Parse command line */
while ((opt = getopt_long(argc, argv, " ",
@@ -402,6 +405,7 @@ launch_args_parse(int argc, char **argv, char *prgname)
pdump_usage(prgname);
return -1;
}
+ pdump_flag = true;
break;
case CMD_LINE_OPT_MULTI_NUM:
multiple_core_capture = 1;
@@ -412,6 +416,11 @@ launch_args_parse(int argc, char **argv, char *prgname)
}
}
+ if (pdump_flag == false) {
+ pdump_usage(prgname);
+ return -1;
+ }
+
return 0;
}
@@ -991,11 +1000,9 @@ main(int argc, char **argv)
argv += (diag - 2);
/* parse app arguments */
- if (argc > 1) {
- ret = launch_args_parse(argc, argv, argp[0]);
- if (ret < 0)
- rte_exit(EXIT_FAILURE, "Invalid argument\n");
- }
+ ret = launch_args_parse(argc, argv, argp[0]);
+ if (ret < 0)
+ rte_exit(EXIT_FAILURE, "Invalid argument\n");
/* create mempool, ring and vdevs info */
create_mp_ring_vdev();
--
2.25.1
next reply other threads:[~2022-03-02 9:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-02 9:26 usman.tanveer [this message]
2022-03-02 16:52 ` Stephen Hemminger
2022-03-31 12:59 ` Usman Tanveer
2023-07-01 2:16 ` [PATCH v2] app/pdump: exit if no device specified Stephen Hemminger
2023-07-03 6:29 ` fengchengwen
2023-07-06 10:45 ` Thomas Monjalon
-- strict thread matches above, loose matches on Subject: below --
2022-03-02 9:20 [PATCH] app/pdump: close program if --pdump argument is missing usman.tanveer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220302092614.5164-1-usman.tanveer@emumba.com \
--to=usman.tanveer@emumba.com \
--cc=dev@dpdk.org \
--cc=reshma.pattan@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).