From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 71F15A04A4; Wed, 2 Mar 2022 13:34:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3778342715; Wed, 2 Mar 2022 13:34:53 +0100 (CET) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id 3A17040141 for ; Wed, 2 Mar 2022 13:34:52 +0100 (CET) Received: by mail-pf1-f180.google.com with SMTP id u16so1813834pfg.12 for ; Wed, 02 Mar 2022 04:34:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eAJ1mUsr3MGfxb7mNr/iWaXZS+6CjI+nyHonia5XyoQ=; b=TJ/1Y7Gu9MkKLSpMREdlULhr11inmVvEPInAHvkiUFmW8HXrJXbo+ZekvCrT54YQ7o hDfHwFBbHIRtKaTceDezD7orL1Jx2RCl+sDxABoF7RL+5R/aBF/akUHCMCXXFlBSNUfg ZEVMgmgtWXjo+gWkYCphGGZ87L0BRyQj0aEun6L8EqurDQA5OkW5pBzb5IXo5gfABlFZ 7QmSfDdEh7HHQz8IZAjy3r4HrAsAhCD/hXdRRybc8LJQWdni9aKoIKS6RFwsJ2piJ5HL hqMdTdYoyWre5iWZ0TM/7RzZbDl0C3i02BsVxNKCjzY9HuToKmpmyb8GxoUoc/pJnD0f Ajfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=eAJ1mUsr3MGfxb7mNr/iWaXZS+6CjI+nyHonia5XyoQ=; b=AUZqqGDOWGlGeXz+amCvbN//oBwoc37hX2YFjEIka1jOusX18wgcjTLEUbw1V31Rte nRDHbfy7RYMQZxG0ieQkfPYJ3Cfg7fyaJDWLjpnNbC4V9p+Gv/VM2WTO/00URpADYL+Y Pt6/2TYt0FcmHGL8GotrPtknuJ6aHRO7KTxKYiJXvjPMGv9K0y8Eot3LHuns+kP+2zae ShTv/APetho2GP35PvHAhschnQqgf1nEVBTUkKGKV6Oi+Ty7YUuuLykS84eNWTn3Vuay /jIcF9s2s8Knjy6kcZm+eWR9bfP6/ULHB3vaF627WKyLvALzazDkGziEGe+T01iI4KGk FGHw== X-Gm-Message-State: AOAM531htkmgPJgCQ5tUq7PTcTTm53KJId667gkND3srXkOoGpuL2nfH vGYHTcJHjUNUIKPq7TXoIAl5+2miUrpA3NL4 X-Google-Smtp-Source: ABdhPJzksuENjUtxbiGmx5uY0+UDbnthv/yvCBsLb5fdCXD8D8vMmJWHkejxSkUMblNNCIoQrnNWLg== X-Received: by 2002:a63:3ecc:0:b0:36c:63a3:1be with SMTP id l195-20020a633ecc000000b0036c63a301bemr25649024pga.353.1646224491291; Wed, 02 Mar 2022 04:34:51 -0800 (PST) Received: from localhost.localdomain ([157.255.44.219]) by smtp.gmail.com with ESMTPSA id u25-20020a62ed19000000b004f140515d56sm20075675pfh.46.2022.03.02.04.34.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 04:34:51 -0800 (PST) From: Harold Huang To: dev@dpdk.org Cc: Harold Huang , Ferruh Yigit , Liron Himi Subject: [PATCH] net/kni: initialize rte_kni_conf to 0 before using it Date: Wed, 2 Mar 2022 20:33:59 +0800 Message-Id: <20220302123400.188209-1-baymaxhuang@gmail.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When kni driver calls eth_kni_start to start device, some fields such as min_mtu and max_mtu of rte_kni_conf are not initialized. It will cause kni_ioctl_create create a kni netdevice with a random min_mtu and max_mtu value. This is unexpected and in some time we could not change the kni device mtu with ip link command. Fixes: ff1e35fb5f8 ("kni: calculate MTU from mbuf size") Signed-off-by: Harold Huang --- drivers/net/kni/rte_eth_kni.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/kni/rte_eth_kni.c b/drivers/net/kni/rte_eth_kni.c index c428caf441..23b15edfac 100644 --- a/drivers/net/kni/rte_eth_kni.c +++ b/drivers/net/kni/rte_eth_kni.c @@ -128,6 +128,7 @@ eth_kni_start(struct rte_eth_dev *dev) const char *name = dev->device->name + 4; /* remove net_ */ mb_pool = internals->rx_queues[0].mb_pool; + memset(&conf, 0, sizeof(conf)); strlcpy(conf.name, name, RTE_KNI_NAMESIZE); conf.force_bind = 0; conf.group_id = port_id; -- 2.27.0