DPDK patches and discussions
 help / color / mirror / Atom feed
From: Devendra Singh Rawat <dsinghrawat@marvell.com>
To: <dev@dpdk.org>, <thomas@monjalon.net>, <jerinj@marvell.com>,
	<ferruh.yigit@intel.com>, <rmody@marvell.com>
Cc: <palok@marvell.com>,
	Devendra Singh Rawat <dsinghrawat@marvell.com>, <stable@dpdk.org>
Subject: [PATCH 3/3] net/qede: fix max Rx pktlen calculation
Date: Fri, 4 Mar 2022 17:38:33 +0530	[thread overview]
Message-ID: <20220304120833.312776-3-dsinghrawat@marvell.com> (raw)
In-Reply-To: <20220304120833.312776-1-dsinghrawat@marvell.com>

size of CRC is not added to max_rx_pktlen, due to this bigger sized
packets(size 1480, 1490 1500) are being dropped.
This fix adds RTE_ETHER_CRC_LEN to max_rx_pktlen.

Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length")
Cc: stable@dpdk.org

Signed-off-by: Devendra Singh Rawat <dsinghrawat@marvell.com>
Signed-off-by: Rasesh Mody <rmody@marvell.com>
---
 drivers/net/qede/qede_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/qede/qede_rxtx.c b/drivers/net/qede/qede_rxtx.c
index 02fa1fcaa1..c35585f5fd 100644
--- a/drivers/net/qede/qede_rxtx.c
+++ b/drivers/net/qede/qede_rxtx.c
@@ -235,7 +235,7 @@ qede_rx_queue_setup(struct rte_eth_dev *dev, uint16_t qid,
 		dev->data->rx_queues[qid] = NULL;
 	}
 
-	max_rx_pktlen = dev->data->mtu + RTE_ETHER_HDR_LEN;
+	max_rx_pktlen = dev->data->mtu + RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN;
 
 	/* Fix up RX buffer size */
 	bufsz = (uint16_t)rte_pktmbuf_data_room_size(mp) - RTE_PKTMBUF_HEADROOM;
-- 
2.18.2


  parent reply	other threads:[~2022-03-04 12:09 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-04 12:08 [PATCH 1/3] net/qede: fix Tx callback completion routine Devendra Singh Rawat
2022-03-04 12:08 ` [PATCH 2/3] net/qede: fix Rx callback Devendra Singh Rawat
2022-03-04 12:08 ` Devendra Singh Rawat [this message]
2022-03-10  7:40 ` [PATCH 1/3] net/qede: fix Tx callback completion routine Jerin Jacob
2022-03-10  8:56   ` Thomas Monjalon
2022-03-10  9:07     ` [EXT] " Devendra Singh Rawat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220304120833.312776-3-dsinghrawat@marvell.com \
    --to=dsinghrawat@marvell.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinj@marvell.com \
    --cc=palok@marvell.com \
    --cc=rmody@marvell.com \
    --cc=stable@dpdk.org \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).