From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 57F22A00C2;
Sun, 6 Mar 2022 10:20:39 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id AA02F4114D;
Sun, 6 Mar 2022 10:20:33 +0100 (CET)
Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com
[66.111.4.29]) by mails.dpdk.org (Postfix) with ESMTP id E8CF640E5A;
Sun, 6 Mar 2022 10:20:31 +0100 (CET)
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
by mailout.nyi.internal (Postfix) with ESMTP id 040B35C023B;
Sun, 6 Mar 2022 04:20:31 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
by compute4.internal (MEProxy); Sun, 06 Mar 2022 04:20:31 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
cc:cc:content-transfer-encoding:date:date:from:from:in-reply-to
:in-reply-to:message-id:mime-version:references:reply-to:sender
:subject:subject:to:to; s=fm1; bh=bg56KG7+xoMSrO4mhjOWaiYJ95ePR+
VRLi1IX1dEDo8=; b=iGU+krEF8PO+jL4EML9/rAcp2ZTqrKNi4ECx0pbq/ISWju
nEXJoD1oj1rIdlwvPw51P+NsrLv2m4S7FNStWYjMySWKa9jL/Nyp7oN9LrhTOMbT
2NZ5Ed/bHlHqKPBt5Bm3oZ5W0i35htzfwnwH+KDCpfNbiB0CkOBiFfkiAm1/GoFJ
6W6Sxqqh3stcV3tAiEPIbWcECdTaLvykCRT/cLBEqpX2GvUPZVXkfm9ebkw/ePwG
U+1fsE+z82aqdOYvhvxTqskIbiXdXwGS5SbMwXzF7Wj8t5+XbNwSYXN26T2yrmfh
s11LbRvp8zPdsqEPEtQrCViLUUf96S9KTNKqjCAQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
messagingengine.com; h=cc:cc:content-transfer-encoding:date:date
:from:from:in-reply-to:in-reply-to:message-id:mime-version
:references:reply-to:sender:subject:subject:to:to:x-me-proxy
:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=bg56KG
7+xoMSrO4mhjOWaiYJ95ePR+VRLi1IX1dEDo8=; b=RUuigL1Wl4AaXMMqTx5X2g
GYLYGUV9HM6tStDvEdjPnft3hXSNipmv/0ZtcK38WmsXSti5+o6q7xmhM6Rm5KRE
j7odnxcOCozACQvs2vVQowduCufTXpWFBgC4gPSCcI4Z+Dt6yP+0PrWjJ2Iat9qG
EBk6gzfOY0cNHBmEhTVWUUZUvfAZRmjkesURI+NxxpE4tivq3Xfp1vPkSCXkhRt7
O7cRY8oeYKd3CCvRgJsGcW3VS9vqyqx2y1XTTb9zxdCucfAmeSATuGca5UETzaMz
bqEbzXe5qfMjklAefQpAelV2ArpNg5if9dYdMDJcYF6BdQegVUw4OfSYcGGLhleQ
==
X-ME-Sender: <xms:3nwkYh0ThDxMes_pjjjtUZc0z93sw4ttwNgu03_h9aQGnUoOwPWVfg>
<xme:3nwkYoFNGnqGDdBgsmgNYW4hFvCU0LN8ja0hE_4_Va_3gpsad0oAXA07RmvxnzWDa
b2b4LYCIbfiHv4qKA>
X-ME-Received: <xmr:3nwkYh4-IedIgzxe1z1y4_FTNSoxvWsUyh4slmzSmLs8wc2y9nz4geF6hpglOK1IjA8QrH8yXC0yjlaRKh6F85Sc8CKOtA8>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddrudduvddgtdefucetufdoteggodetrfdotf
fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
cujfgurhephffvufffkffojghfggfgsedtkeertdertddtnecuhfhrohhmpefvhhhomhgr
shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecugg
ftrfgrthhtvghrnhepvdehgfeivdejgedtveehfefhteelfefgieevgfffveefjeegtdfg
uedthedtgeevnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh
homhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth
X-ME-Proxy: <xmx:3nwkYu3SgdNKvGKpZLvLQTYBlrIgTofR0sGleqc1_JX-0hr3sYE7RA>
<xmx:3nwkYkGBh-ahlVDcEZKPHJEruseXOxEJ9y825G_ezU6sgVeZS0UK3A>
<xmx:3nwkYv8Kpeze5uUvfzfMkFV8suFniNpMvDdse9OTrHFaS_3S3MDiWg>
<xmx:33wkYgizZz7N0nhuwHy1zO8AWU0o5eDNt8XxeiJPbYY0MGcJFlN7zQ>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
6 Mar 2022 04:20:29 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: dev@dpdk.org
Cc: stable@dpdk.org, Ray Kinsella <mdr@ashroe.eu>, Ori Kam <orika@nvidia.com>,
Jerin Jacob <jerinj@marvell.com>,
Pavan Nikhilesh <pbhagavatula@marvell.com>
Subject: [PATCH 1/2] regexdev: fix section attribute of symbols
Date: Sun, 6 Mar 2022 10:20:22 +0100
Message-Id: <20220306092023.2461466-2-thomas@monjalon.net>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20220306092023.2461466-1-thomas@monjalon.net>
References: <20220306092023.2461466-1-thomas@monjalon.net>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
The functions used by the drivers must be internal,
while the function and variables used in inline functions
must be experimental.
These are the changes done in the shared libraries:
- DF .text Base rte_regexdev_get_device_by_name
+ DF .text INTERNAL rte_regexdev_get_device_by_name
- DF .text Base rte_regexdev_register
+ DF .text INTERNAL rte_regexdev_register
- DF .text Base rte_regexdev_unregister
+ DF .text INTERNAL rte_regexdev_unregister
- DF .text Base rte_regexdev_is_valid_dev
+ DF .text EXPERIMENTAL rte_regexdev_is_valid_dev
- DO .bss Base rte_regex_devices
+ DO .bss EXPERIMENTAL rte_regex_devices
- DO .bss Base rte_regexdev_logtype
+ DO .bss EXPERIMENTAL rte_regexdev_logtype
Because these symbols were exported in the default section in DPDK 21.11,
any change in these functions would be seen as incompatible
by the ABI compatibility check.
An exception rule is added for this experimental library,
so the ABI check will skip it until the next ABI version.
Fixes: bab9497ef78b ("regexdev: introduce API")
Cc: stable@dpdk.org
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
devtools/libabigail.abignore | 4 ++++
lib/regexdev/rte_regexdev.h | 4 ++++
lib/regexdev/rte_regexdev_driver.h | 3 +++
lib/regexdev/version.map | 9 +++++++++
4 files changed, 20 insertions(+)
diff --git a/devtools/libabigail.abignore b/devtools/libabigail.abignore
index 301b3dacb8..cff7a293ae 100644
--- a/devtools/libabigail.abignore
+++ b/devtools/libabigail.abignore
@@ -21,6 +21,10 @@
[suppress_type]
name = rte_crypto_asym_op
+; Ignore section attribute fixes in experimental regexdev library
+[suppress_file]
+ soname_regexp = ^librte_regexdev\.
+
; Ignore changes in common mlx5 driver, should be all internal
[suppress_file]
soname_regexp = ^librte_common_mlx5\.
diff --git a/lib/regexdev/rte_regexdev.h b/lib/regexdev/rte_regexdev.h
index 4ba67b0c25..3bce8090f6 100644
--- a/lib/regexdev/rte_regexdev.h
+++ b/lib/regexdev/rte_regexdev.h
@@ -225,6 +225,9 @@ extern int rte_regexdev_logtype;
} while (0)
/**
+ * @warning
+ * @b EXPERIMENTAL: this API may change without prior notice.
+ *
* Check if dev_id is ready.
*
* @param dev_id
@@ -234,6 +237,7 @@ extern int rte_regexdev_logtype;
* - 0 if device state is not in ready state.
* - 1 if device state is ready state.
*/
+__rte_experimental
int rte_regexdev_is_valid_dev(uint16_t dev_id);
/**
diff --git a/lib/regexdev/rte_regexdev_driver.h b/lib/regexdev/rte_regexdev_driver.h
index 64742016c0..6246b144a6 100644
--- a/lib/regexdev/rte_regexdev_driver.h
+++ b/lib/regexdev/rte_regexdev_driver.h
@@ -32,6 +32,7 @@ extern "C" {
* A pointer to the RegEx device slot case of success,
* NULL otherwise.
*/
+__rte_internal
struct rte_regexdev *rte_regexdev_register(const char *name);
/**
@@ -41,6 +42,7 @@ struct rte_regexdev *rte_regexdev_register(const char *name);
* @param dev
* Device to be released.
*/
+__rte_internal
void rte_regexdev_unregister(struct rte_regexdev *dev);
/**
@@ -50,6 +52,7 @@ void rte_regexdev_unregister(struct rte_regexdev *dev);
* @param name
* The device name.
*/
+__rte_internal
struct rte_regexdev *rte_regexdev_get_device_by_name(const char *name);
#ifdef __cplusplus
diff --git a/lib/regexdev/version.map b/lib/regexdev/version.map
index 8db9b17018..988b909638 100644
--- a/lib/regexdev/version.map
+++ b/lib/regexdev/version.map
@@ -1,6 +1,7 @@
EXPERIMENTAL {
global:
+ rte_regex_devices;
rte_regexdev_attr_get;
rte_regexdev_attr_set;
rte_regexdev_close;
@@ -11,6 +12,8 @@ EXPERIMENTAL {
rte_regexdev_enqueue_burst;
rte_regexdev_get_dev_id;
rte_regexdev_info_get;
+ rte_regexdev_is_valid_dev;
+ rte_regexdev_logtype;
rte_regexdev_queue_pair_setup;
rte_regexdev_rule_db_compile_activate;
rte_regexdev_rule_db_export;
@@ -24,3 +27,9 @@ EXPERIMENTAL {
rte_regexdev_xstats_names_get;
rte_regexdev_xstats_reset;
};
+
+INTERNAL {
+ rte_regexdev_get_device_by_name;
+ rte_regexdev_register;
+ rte_regexdev_unregister;
+};
--
2.34.1