From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 80080A0093; Mon, 7 Mar 2022 17:04:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 132A840688; Mon, 7 Mar 2022 17:04:31 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id C50C24014E for ; Mon, 7 Mar 2022 17:04:29 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id w4so3815128ply.13 for ; Mon, 07 Mar 2022 08:04:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=dFcxvgHqHHraD73zvPXqsXavBbB3soXGas9kRkRY8Ks=; b=skg90TRWD100TNwWheXh3IBkAR8APfqmUS8AhSwF9do7r16noP5GUaK/tuSoZ4R26Y 6sPEGYIjQBAE0N8yX1uXxHjwrr5hOLHWgUGMpNiIkkzb0A28vw1uMuSvtyrscsrwyNDd sm2kkZugi6N0QSHKzdzGyCiyHP+uyR0KZZ1Yf+m/Zm+QTg62Nt8AUegOVGwYUUwiCwRj 1nesIhJHZgYWO1xjqSN0uVniuVskDU1HFAAT9L5E+6CftT/I8qOpkaf4L5s/SWIs5fUK TMB8lZIRz+tYBH7TFHT7zaUg+IoAi7Z+NRK2tnrsXepo0HG3qZg7hKLKvP3QVLgUO/el jl+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dFcxvgHqHHraD73zvPXqsXavBbB3soXGas9kRkRY8Ks=; b=hxRdqXGK4xmc8CojbbLPq/Lo9BDeeezKoZTwSTeqpe9YcGR3lfME9IQd7jwHZ0y041 K2AhvXAfLoUuawQYfEiefAJ89xCIoT7gxm/Ct+3A0bou7Egq/FwEsYNTFNYPU9ctEFa6 0KL2xYSTyF9Ig2N/SKM82gdvacVRBr0T7TMAuWRy6dCOeHnWtIErebQLqPXchBPML0k3 fJUkk9GevY+KmamhAhh+YSaq3KoVEWPqBnzv74kNXLEAcL53KmnEdXgHnzp+3ihhH6E3 h5roVk5uUwAQ+6Eh8vRHWgejpgyWXgwA0NXNjustFZGaRpsz5LPGZmWMkd0nl58YVFqQ THWQ== X-Gm-Message-State: AOAM531M0+58ca3cJJV4fv2DwbMlaWyBbMlUviUj/+5uu0EWofdvAWA8 gJLYCw70K5EgEmKxDTh/yXzdCg== X-Google-Smtp-Source: ABdhPJzs1G73Ui8Ia+R0RNDRSqraqc4aFmex6hAr81s/3ky/Z1srUo4J4Wk135Ww8DD9ob7gR5//jQ== X-Received: by 2002:a17:902:b94b:b0:14e:f1a8:9b99 with SMTP id h11-20020a170902b94b00b0014ef1a89b99mr13055340pls.28.1646669068722; Mon, 07 Mar 2022 08:04:28 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id f13-20020a056a001acd00b004f0f9a967basm16542617pfv.100.2022.03.07.08.04.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Mar 2022 08:04:28 -0800 (PST) Date: Mon, 7 Mar 2022 08:04:25 -0800 From: Stephen Hemminger To: Tianli Lai Cc: dev@dpdk.org, Reshma Pattan Subject: Re: [PATCH 2/2] app/pdump: add filter argument Message-ID: <20220307080425.308bebe0@hermes.local> In-Reply-To: <20220307203041.33765-1-laitianli@tom.com> References: <20220307203041.33765-1-laitianli@tom.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, 8 Mar 2022 04:30:41 +0800 Tianli Lai wrote: > filter argument contain size and snaplen argument. > size argument set the pcap file size, if the total packet > length over this value, pdump process will exist. > snaplen argument set each packet length to save pcap file. > > Signed-off-by: Tianli Lai Why not use the the new dpdk-dumpcap? The issue is that adding more to pdump means it now gets a dependency on BPF.