DPDK patches and discussions
 help / color / mirror / Atom feed
From: jeffd@silicom-usa.com
To: dev@dpdk.org
Cc: Stephen Douthit <stephend@silicom-usa.com>,
	Jeff Daly <jeffd@silicom-usa.com>,
	Haiyue Wang <haiyue.wang@intel.com>
Subject: [PATCH] net/ixgbe: Treat 1G Cu SFPs as 1G SX on the X550 devices
Date: Mon,  7 Mar 2022 17:34:42 -0500	[thread overview]
Message-ID: <20220307223442.28012-1-jeffd@silicom-usa.com> (raw)

From: Stephen Douthit <stephend@silicom-usa.com>

1G Cu SFPs are not officially supported on the X552/X553 family of devices
but treat them as 1G SX modules since they usually work.  Print a warning
though since support isn't validated, similar to what already happens for
other unofficially supported SFPs enabled via the allow_unsupported_sfps
parameter inherited from the mainline Linux driver.

Signed-off-by: Stephen Douthit <stephend@silicom-usa.com>
Signed-off-by: Jeff Daly <jeffd@silicom-usa.com>
---
 drivers/net/ixgbe/base/ixgbe_x550.c | 14 +++++++++++++-
 1 file changed, 13 insertions(+), 1 deletion(-)

diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c
index 8810d1658e..8d1bc6c80d 100644
--- a/drivers/net/ixgbe/base/ixgbe_x550.c
+++ b/drivers/net/ixgbe/base/ixgbe_x550.c
@@ -1538,9 +1538,21 @@ STATIC s32 ixgbe_supported_sfp_modules_X550em(struct ixgbe_hw *hw, bool *linear)
 	case ixgbe_sfp_type_1g_lha_core1:
 		*linear = false;
 		break;
-	case ixgbe_sfp_type_unknown:
+	/* Copper SFPs are not officially supported for x550em devices, but can
+	 * often be made to work at fixed 1G speeds.  Pretend they're 1g_sx
+	 * modules here to allow g.Fast DSL SFPs to work.
+	 */
 	case ixgbe_sfp_type_1g_cu_core0:
+		EWARN(hw, "Pretending that unsupported 1g_cu SFP is 1g_sx\n");
+		*linear = false;
+		hw->phy.sfp_type = ixgbe_sfp_type_1g_sx_core0;
+		break;
 	case ixgbe_sfp_type_1g_cu_core1:
+		EWARN(hw, "Pretending that unsupported 1g_cu SFP is 1g_sx\n");
+		*linear = false;
+		hw->phy.sfp_type = ixgbe_sfp_type_1g_sx_core1;
+		break;
+	case ixgbe_sfp_type_unknown:
 	default:
 		return IXGBE_ERR_SFP_NOT_SUPPORTED;
 	}
-- 
2.25.1


             reply	other threads:[~2022-03-07 22:34 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-07 22:34 jeffd [this message]
2022-04-13 14:21 ` Thomas Monjalon
2022-05-20  0:14   ` Zhang, Qi Z
2022-05-20 18:02     ` Jeff Daly
2022-05-23  5:36       ` Zhang, Qi Z
2022-05-23 14:13         ` Jeff Daly
2022-05-23 23:22           ` Zhang, Qi Z
2022-05-25 15:23             ` Jeff Daly
2022-05-26  0:28               ` Zhang, Qi Z
2022-04-14  1:31 ` Wang, Haiyue
2022-04-14  9:42   ` Thomas Monjalon
2022-04-14 12:13     ` Wang, Haiyue
2022-04-14 12:18       ` Thomas Monjalon
2022-04-14 15:11         ` Jeff Daly
2022-04-14 15:43           ` Stephen Hemminger
2022-04-14 17:06             ` Thomas Monjalon
2022-04-19  9:11               ` Morten Brørup
2022-04-19 12:32                 ` Wang, Haiyue
2022-04-15  1:10           ` Wang, Haiyue
2022-05-26 20:43 ` [PATCH v2] " Jeff Daly
2022-05-29 22:49   ` Zhang, Qi Z
2022-05-30 13:32     ` Jeff Daly
2022-05-30 13:50       ` Zhang, Qi Z
2022-05-31 12:30         ` Jeff Daly
2022-05-31 13:38           ` Zhang, Qi Z

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220307223442.28012-1-jeffd@silicom-usa.com \
    --to=jeffd@silicom-usa.com \
    --cc=dev@dpdk.org \
    --cc=haiyue.wang@intel.com \
    --cc=stephend@silicom-usa.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).