From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0228EA0093; Wed, 9 Mar 2022 00:03:10 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8F8FC40395; Wed, 9 Mar 2022 00:03:10 +0100 (CET) Received: from sender11-of-o51.zoho.eu (sender11-of-o51.zoho.eu [185.20.211.237]) by mails.dpdk.org (Postfix) with ESMTP id C4E6E40141 for ; Wed, 9 Mar 2022 00:03:09 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; t=1646780583; cv=none; d=zohomail.eu; s=zohoarc; b=ACMeWdVZ5mXoIt0eGvX13wLTtjQahQn2CbMOC+HAekso7C5yZAymR+kqIlepYsQ/LRzoUF70YiycUK6dWFE9a5bPoglotV5GsdckczZQmQbt9hAlJVKQXqTr5l9L4o1GLpbMzXbOQBd40BBhQ8Ge4Zg9NyHPzdl6WkjHMY3JgKk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.eu; s=zohoarc; t=1646780583; h=Content-Type:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=axoGDejbeHyhll+A8daiWMaUjqH2MARNlfUpdsoP6j4=; b=JmBd82iSsB3sS+h6RIzVoYTVu4l0GmBLVEQbcGMTxGw7nRYhdMJXgctg7KtH7yZja+LaWLqplN9Oznpe6422iWe98eBbHg1fuEX4Etjptti6sDAuqyL5K286ss5IZrA2ScyqJKAlVULXsca/yKWGCR+pN30gS6Jk5yN1aEXZmvA= ARC-Authentication-Results: i=1; mx.zohomail.eu; spf=pass smtp.mailfrom=liangma@liangbit.com; dmarc=pass header.from= Received: from DESKTOP-POQV63C.localdomain (cpc145956-finc19-2-0-cust124.4-2.cable.virginm.net [82.25.6.125]) by mx.zoho.eu with SMTPS id 164678057992323.468203995885574; Wed, 9 Mar 2022 00:02:59 +0100 (CET) Date: Tue, 8 Mar 2022 23:02:56 +0000 From: Liang Ma To: Thomas Monjalon Cc: dev@dpdk.org, Usama Arif Subject: Re: [PATCH] devtools: fix symbols check Message-ID: <20220308230256.GA40@DESKTOP-POQV63C.localdomain> References: <20220308211859.3677476-1-thomas@monjalon.net> <4176712.K71DO8KEF6@thomas> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4176712.K71DO8KEF6@thomas> User-Agent: Mutt/1.9.4 (2018-02-28) X-ZohoMailClient: External X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Mar 08, 2022 at 11:05:49PM +0100, Thomas Monjalon wrote: > 08/03/2022 22:27, Liang Ma: > > On Tue, Mar 08, 2022 at 10:18:59PM +0100, Thomas Monjalon wrote: > > > In some environments, the check of local symbols catch-all > > > was failing. Note: this script is called during the build. > > > > > > The reason is that grep returns an error if nothing is found. > > > The option -e of the shell script makes this error fatal. > > > It is not always fatal because the grep is in a command substitution. > > > > > > Fixes: b403498e1422 ("build: hide local symbols in shared libraries") > > > > > > Reported-by: Usama Arif > > > Signed-off-by: Thomas Monjalon > > > --- > > > devtools/check-symbol-maps.sh | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/devtools/check-symbol-maps.sh b/devtools/check-symbol-maps.sh > > > index 8266fdf9ea..32e1fa5c8f 100755 > > > --- a/devtools/check-symbol-maps.sh > > > +++ b/devtools/check-symbol-maps.sh > > > @@ -53,7 +53,7 @@ if [ -n "$duplicate_symbols" ] ; then > > > ret=1 > > > fi > > > > > > -local_miss_maps=$(grep -L 'local: \*;' $@) > > > +local_miss_maps=$(grep -L 'local: \*;' $@ || true) > > reviewed-by Liang Ma > > > > I'm curious to know how can the CI passed with original patch..... > > You are suggesting I did not check the CI. > > The Intel check failed because of an apply issue, > so I was not able to see the compilation result: > http://mails.dpdk.org/archives/test-report/2022-March/267685.html > > Later in the day, the UNH CI failed for the good reason > but it was too late, the patch was applied: > http://mails.dpdk.org/archives/test-report/2022-March/267723.html > > That's what happens when I want to introduce a little additional check > at the last minute before a release candidate. No worry, I thought the CI has a bug. > >