From: Michael Baum <michaelba@nvidia.com>
To: <dev@dpdk.org>
Cc: Matan Azrad <matan@nvidia.com>,
Raslan Darawsheh <rasland@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>, <stable@dpdk.org>
Subject: [PATCH] net/mlx5: fix FD configuration for Rx interrupt
Date: Thu, 10 Mar 2022 15:19:23 +0200 [thread overview]
Message-ID: <20220310131923.1144368-1-michaelba@nvidia.com> (raw)
The mlx5_rx_intr_vec_enable() function allocates queue vector and fill
FD list for Rx interrupts.
The driver wrongly configured the FD with a non-blocking flag which
prevent waiting on this FD.
This patch removes O_NONBLOCK flag adding.
Fixes: 3c7d44af252a ("net/mlx5: support user space Rx interrupt event")
Cc: stable@dpdk.org
Signed-off-by: Michael Baum <michaelba@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
drivers/net/mlx5/mlx5_rxq.c | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)
diff --git a/drivers/net/mlx5/mlx5_rxq.c b/drivers/net/mlx5/mlx5_rxq.c
index f16795bac3..b38505b85c 100644
--- a/drivers/net/mlx5/mlx5_rxq.c
+++ b/drivers/net/mlx5/mlx5_rxq.c
@@ -1075,7 +1075,6 @@ mlx5_rx_intr_vec_enable(struct rte_eth_dev *dev)
/* This rxq obj must not be released in this function. */
struct mlx5_rxq_priv *rxq = mlx5_rxq_get(dev, i);
struct mlx5_rxq_obj *rxq_obj = rxq ? rxq->ctrl->obj : NULL;
- int rc;
/* Skip queues that cannot request interrupts. */
if (!rxq_obj || (!rxq_obj->ibv_channel &&
@@ -1097,23 +1096,10 @@ mlx5_rx_intr_vec_enable(struct rte_eth_dev *dev)
rte_errno = ENOMEM;
return -rte_errno;
}
- rc = mlx5_os_set_nonblock_channel_fd(rxq_obj->fd);
- if (rc < 0) {
- rte_errno = errno;
- DRV_LOG(ERR,
- "port %u failed to make Rx interrupt file"
- " descriptor %d non-blocking for queue index"
- " %d",
- dev->data->port_id, rxq_obj->fd, i);
- mlx5_rx_intr_vec_disable(dev);
- return -rte_errno;
- }
-
if (rte_intr_vec_list_index_set(intr_handle, i,
RTE_INTR_VEC_RXTX_OFFSET + count))
return -rte_errno;
- if (rte_intr_efds_index_set(intr_handle, count,
- rxq_obj->fd))
+ if (rte_intr_efds_index_set(intr_handle, count, rxq_obj->fd))
return -rte_errno;
count++;
}
--
2.25.1
next reply other threads:[~2022-03-10 13:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 13:19 Michael Baum [this message]
2022-03-10 15:12 ` David Marchand
2022-03-10 16:16 ` Thomas Monjalon
2022-03-10 17:04 ` Michael Baum
2022-03-14 9:31 ` David Marchand
2022-03-14 10:49 ` Matan Azrad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220310131923.1144368-1-michaelba@nvidia.com \
--to=michaelba@nvidia.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).