From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 98E65A00C2; Fri, 11 Mar 2022 18:13:59 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3302A40140; Fri, 11 Mar 2022 18:13:59 +0100 (CET) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id 9F08240042 for ; Fri, 11 Mar 2022 18:13:58 +0100 (CET) Received: by mail-pj1-f43.google.com with SMTP id lj8-20020a17090b344800b001bfaa46bca3so8517401pjb.2 for ; Fri, 11 Mar 2022 09:13:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qjRFbSvZ1JatO+ELnnxZ/pHx+KG922D2d8Ql68tVMl4=; b=SqFLTzB23+y33M5GP19rnhbb1IOXls1PmgoO1ur19FoVDpkC0AeyvEUTAP92lJivnl 3LiP4tJVpDmvxm1bd5lkXP79R/9ouo42Cxp7IUdoBpNjOX0i/uJ+2uDG2QhzOBzGhXO+ hyNNHJi2hkxMb1woQ9aXNH7ovBrGQZqTP5CNgm4SlP66WkA0LZaMZACnx9N7OsndrpEM WpPSLxs24a1sBXNhXXh2YvT1KuH7Tk+MsJlAa9aMWCoAVgR8InIsDof7iaZNuDycxaxY Qdxow+s1ksOXinG9k/+2eEUAmNsOwJBac6yL7QIxV9CPGgxXSPElXxkD2GhmMMjeB9Xr A+0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qjRFbSvZ1JatO+ELnnxZ/pHx+KG922D2d8Ql68tVMl4=; b=03Kiz8hw6jrTAf/UGknOkF+Mh0btAO2bWi7x+rVIzsl1Md7gNuJqynWwBTG3HUfZsI Rssp0xzvG3wtNfDbjEKS2DE/NozJl1gGyxbQ7TXEXkW0sgQm6QdXv8H2Am7kYl3Zzues 6dcZfRZ3Ul0Z8FZXBmv1oEpUj5LiynYZdJzv0cIbowbI7Zx1l0Smqt7m8ohjNkyuOUTa /y+FofKhvbV0UmyyllrTj+dqtSlL9Ww2su4++rv14jTusbODcBgq6M3301RHajAsJeDl ZFwz6EvIXsQkwZIZLF5YEO14Tcfc6RXH4gvVhvfGcPR75ehzlvtWReGNUf0cncLoM9HM oZ6g== X-Gm-Message-State: AOAM5304KSGA4DuefakEtj4sSNNG1GBlPOixZfhklTTmGBDvwnPP/Pwo OarYVaWrH9/ou5rDRZLJvF80Ew== X-Google-Smtp-Source: ABdhPJw7ATrZchSxr0t3b5Mpp0TOCW613SX6Em2S4UN6BmqwmnuSSuBSezc3HdLtAAUgoR1FgfELBg== X-Received: by 2002:a17:902:7296:b0:14b:4bc6:e81 with SMTP id d22-20020a170902729600b0014b4bc60e81mr11455094pll.132.1647018836736; Fri, 11 Mar 2022 09:13:56 -0800 (PST) Received: from hermes.local (204-195-112-199.wavecable.com. [204.195.112.199]) by smtp.gmail.com with ESMTPSA id j5-20020a17090a31c500b001bf37d6abe1sm14167838pjf.45.2022.03.11.09.13.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 11 Mar 2022 09:13:56 -0800 (PST) Date: Fri, 11 Mar 2022 09:13:53 -0800 From: Stephen Hemminger To: "Ajmera, Megha" Cc: "dev@dpdk.org" , "Mcnamara, John" , "Singh, Jasvinder" , "Dumitrescu, Cristian" , "Yigit, Ferruh" , "Thakur, Sham Singh" Subject: Re: [PATCH v1] sched: enable/disable TC OV at runtime Message-ID: <20220311091353.40568ccc@hermes.local> In-Reply-To: References: <20220310195426.4121953-1-megha.ajmera@intel.com> <20220310122325.2e928c7d@hermes.local> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, 11 Mar 2022 06:24:35 +0000 "Ajmera, Megha" wrote: > > > > > diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index > > > ec74bee939..1d05089d00 100644 > > > --- a/lib/sched/rte_sched.c > > > +++ b/lib/sched/rte_sched.c > > > @@ -155,6 +155,7 @@ struct rte_sched_subport { > > > uint64_t tc_credits[RTE_SCHED_TRAFFIC_CLASSES_PER_PIPE]; > > > > > > /* TC oversubscription */ > > > + uint8_t is_tc_ov_enabled; > > > uint64_t tc_ov_wm; > > > uint64_t tc_ov_wm_min; > > > uint64_t tc_ov_wm_max; > > > > Putting the field there creates a hole in the structure. > > Put it after tc_ov and fill an existing hole. > > > > This is pahole of current code, looks like this struct could use some work to be > > better packed and aligned. > > > > Thanks Stephen for pointing this out. I agree there is some work needed to pack this structure better. > Can we take this up in a separate patch in later release as it requires more performance test runs to see the impact ? > Please add new field in existing hole