From: Peng Zhang <peng.zhang@corigine.com>
To: dev@dpdk.org
Cc: heinrich.kuhn@corigine.com, Peng Zhang <peng.zhang@corigine.com>,
stable@dpdk.org, Chaoyong He <chaoyong.he@corigine.com>,
Louis Peens <louis.peens@corigine.com>
Subject: [PATCH v2] net/nfp: fix mtu settings
Date: Fri, 18 Mar 2022 13:38:19 +0200 [thread overview]
Message-ID: <20220318113819.885476-1-peng.zhang@corigine.com> (raw)
In-Reply-To: <20220317143917.499138-1-peng.zhang@corigine.com>
1.When the setting mtu is higher than flbufsz, the mtu doesn't work.
But it doesn't have any notice about this restrict.
2.add the min_mtu and max_mtu in the nfp_net_infos_get() to avoid
the setting mtu isn't in the range
This patch will add these restrict of nfp mtu.
Fixes: d4a27a3 ("nfp: add basic features")
Cc: stable@dpdk.org
Signed-off-by: Peng Zhang <peng.zhang@corigine.com>
Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Signed-off-by: Louis Peens <louis.peens@corigine.com>
---
v2:
* add the min_mtu and max_mtu in the nfp_net_infos_get()
---
drivers/net/nfp/nfp_common.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/net/nfp/nfp_common.c b/drivers/net/nfp/nfp_common.c
index f8978e803a..4e48e33a63 100644
--- a/drivers/net/nfp/nfp_common.c
+++ b/drivers/net/nfp/nfp_common.c
@@ -693,6 +693,8 @@ nfp_net_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
hw = NFP_NET_DEV_PRIVATE_TO_HW(dev->data->dev_private);
+ dev_info->max_mtu = (uint16_t)hw->max_mtu;
+ dev_info->min_mtu = RTE_ETHER_MIN_MTU;
dev_info->max_rx_queues = (uint16_t)hw->max_rx_queues;
dev_info->max_tx_queues = (uint16_t)hw->max_tx_queues;
dev_info->min_rx_bufsize = RTE_ETHER_MIN_MTU;
@@ -956,6 +958,13 @@ nfp_net_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
return -EBUSY;
}
+ /* the setting mtu is lower than flbufsz */
+ if (mtu > hw->flbufsz) {
+ PMD_DRV_LOG(ERR, "the setting mtu must be lower than current mbufsize of %d",
+ hw->flbufsz);
+ return -ERANGE;
+ }
+
/* writing to configuration space */
nn_cfg_writel(hw, NFP_NET_CFG_MTU, mtu);
--
2.27.0
next prev parent reply other threads:[~2022-03-18 11:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-17 14:39 [PATCH] net/nfp: add the restrict of setting the mtu Peng Zhang
2022-03-17 18:29 ` Stephen Hemminger
2022-03-18 11:38 ` Peng Zhang [this message]
2022-03-30 3:17 ` [PATCH v3] net/nfp: fix mtu settings Peng Zhang
2022-04-20 18:54 ` Ferruh Yigit
2022-04-21 0:55 ` Nole Zhang
2022-05-11 1:15 ` [PATCH v4] net/nfp: make sure MTU is never larger than mbufsize Peng Zhang
2022-05-19 7:08 ` Andrew Rybchenko
2022-03-18 11:21 [PATCH v2] net/nfp: fix mtu settings Peng Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220318113819.885476-1-peng.zhang@corigine.com \
--to=peng.zhang@corigine.com \
--cc=chaoyong.he@corigine.com \
--cc=dev@dpdk.org \
--cc=heinrich.kuhn@corigine.com \
--cc=louis.peens@corigine.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).