* [PATCH] net/bnxt: fix compatibility with some old firmwares
@ 2022-03-18 15:03 David Marchand
2022-03-29 23:21 ` Ajit Khaparde
0 siblings, 1 reply; 6+ messages in thread
From: David Marchand @ 2022-03-18 15:03 UTC (permalink / raw)
To: dev; +Cc: stable, Ajit Khaparde, Somnath Kotur, Randy Schacher, Kalesh AP
This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975.
Reported by Red Hat QE: with older firmware versions (at least versions
20.6.112.0 and 20.6.143.0), initialisation never succeeds following this
change.
Revert it for now, waiting for a more complete fix.
Fixes: 3972281f47b2 ("net/bnxt: fix device readiness check")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/bnxt/bnxt_hwrm.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
index b4aeec593e..bff73a9566 100644
--- a/drivers/net/bnxt/bnxt_hwrm.c
+++ b/drivers/net/bnxt/bnxt_hwrm.c
@@ -1244,11 +1244,6 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout)
else
HWRM_CHECK_RESULT();
- if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY) {
- rc = -EAGAIN;
- goto error;
- }
-
PMD_DRV_LOG(INFO, "%d.%d.%d:%d.%d.%d.%d\n",
resp->hwrm_intf_maj_8b, resp->hwrm_intf_min_8b,
resp->hwrm_intf_upd_8b, resp->hwrm_fw_maj_8b,
@@ -6149,10 +6144,6 @@ int bnxt_hwrm_poll_ver_get(struct bnxt *bp)
rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);
HWRM_CHECK_RESULT_SILENT();
-
- if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY)
- rc = -EAGAIN;
-
HWRM_UNLOCK();
return rc;
--
2.23.0
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] net/bnxt: fix compatibility with some old firmwares
2022-03-18 15:03 [PATCH] net/bnxt: fix compatibility with some old firmwares David Marchand
@ 2022-03-29 23:21 ` Ajit Khaparde
2022-05-17 7:18 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Ajit Khaparde @ 2022-03-29 23:21 UTC (permalink / raw)
To: David Marchand
Cc: dpdk-dev, dpdk stable, Somnath Kotur, Randy Schacher, Kalesh AP
[-- Attachment #1: Type: text/plain, Size: 1716 bytes --]
On Fri, Mar 18, 2022 at 8:03 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975.
>
> Reported by Red Hat QE: with older firmware versions (at least versions
> 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this
> change.
> Revert it for now, waiting for a more complete fix.
>
> Fixes: 3972281f47b2 ("net/bnxt: fix device readiness check")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Patch applied to dpdk-next-net-brcm. Thanks
> ---
> drivers/net/bnxt/bnxt_hwrm.c | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
> index b4aeec593e..bff73a9566 100644
> --- a/drivers/net/bnxt/bnxt_hwrm.c
> +++ b/drivers/net/bnxt/bnxt_hwrm.c
> @@ -1244,11 +1244,6 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout)
> else
> HWRM_CHECK_RESULT();
>
> - if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY) {
> - rc = -EAGAIN;
> - goto error;
> - }
> -
> PMD_DRV_LOG(INFO, "%d.%d.%d:%d.%d.%d.%d\n",
> resp->hwrm_intf_maj_8b, resp->hwrm_intf_min_8b,
> resp->hwrm_intf_upd_8b, resp->hwrm_fw_maj_8b,
> @@ -6149,10 +6144,6 @@ int bnxt_hwrm_poll_ver_get(struct bnxt *bp)
> rc = bnxt_hwrm_send_message(bp, &req, sizeof(req), BNXT_USE_CHIMP_MB);
>
> HWRM_CHECK_RESULT_SILENT();
> -
> - if (resp->flags & HWRM_VER_GET_OUTPUT_FLAGS_DEV_NOT_RDY)
> - rc = -EAGAIN;
> -
> HWRM_UNLOCK();
>
> return rc;
> --
> 2.23.0
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] net/bnxt: fix compatibility with some old firmwares
2022-03-29 23:21 ` Ajit Khaparde
@ 2022-05-17 7:18 ` Thomas Monjalon
2022-05-18 3:58 ` Ajit Khaparde
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2022-05-17 7:18 UTC (permalink / raw)
To: David Marchand, Ajit Khaparde
Cc: dev, dpdk stable, Somnath Kotur, Randy Schacher, Kalesh AP
30/03/2022 01:21, Ajit Khaparde:
> On Fri, Mar 18, 2022 at 8:03 AM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975.
> >
> > Reported by Red Hat QE: with older firmware versions (at least versions
> > 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this
> > change.
> > Revert it for now, waiting for a more complete fix.
> >
> > Fixes: 3972281f47b2 ("net/bnxt: fix device readiness check")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
> Patch applied to dpdk-next-net-brcm. Thanks
It seems this patch has been lost.
I don't find it in dpdk-next-net-brcm.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] net/bnxt: fix compatibility with some old firmwares
2022-05-17 7:18 ` Thomas Monjalon
@ 2022-05-18 3:58 ` Ajit Khaparde
2022-05-18 6:22 ` Thomas Monjalon
0 siblings, 1 reply; 6+ messages in thread
From: Ajit Khaparde @ 2022-05-18 3:58 UTC (permalink / raw)
To: Thomas Monjalon
Cc: David Marchand, dpdk-dev, dpdk stable, Somnath Kotur,
Randy Schacher, Kalesh AP
[-- Attachment #1: Type: text/plain, Size: 931 bytes --]
On Tue, May 17, 2022 at 12:18 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 30/03/2022 01:21, Ajit Khaparde:
> > On Fri, Mar 18, 2022 at 8:03 AM David Marchand
> > <david.marchand@redhat.com> wrote:
> > >
> > > This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975.
> > >
> > > Reported by Red Hat QE: with older firmware versions (at least versions
> > > 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this
> > > change.
> > > Revert it for now, waiting for a more complete fix.
> > >
> > > Fixes: 3972281f47b2 ("net/bnxt: fix device readiness check")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> >
> > Patch applied to dpdk-next-net-brcm. Thanks
>
> It seems this patch has been lost.
> I don't find it in dpdk-next-net-brcm.
Hmm.. Yes.
I pushed it again. Please check. Thanks
>
>
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] net/bnxt: fix compatibility with some old firmwares
2022-05-18 3:58 ` Ajit Khaparde
@ 2022-05-18 6:22 ` Thomas Monjalon
2022-05-23 0:46 ` Ajit Khaparde
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Monjalon @ 2022-05-18 6:22 UTC (permalink / raw)
To: Ajit Khaparde
Cc: David Marchand, dpdk-dev, dpdk stable, Somnath Kotur,
Randy Schacher, Kalesh AP
18/05/2022 05:58, Ajit Khaparde:
> On Tue, May 17, 2022 at 12:18 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > 30/03/2022 01:21, Ajit Khaparde:
> > > On Fri, Mar 18, 2022 at 8:03 AM David Marchand
> > > <david.marchand@redhat.com> wrote:
> > > >
> > > > This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975.
> > > >
> > > > Reported by Red Hat QE: with older firmware versions (at least versions
> > > > 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this
> > > > change.
> > > > Revert it for now, waiting for a more complete fix.
> > > >
> > > > Fixes: 3972281f47b2 ("net/bnxt: fix device readiness check")
> > > > Cc: stable@dpdk.org
> > > >
> > > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > >
> > > Patch applied to dpdk-next-net-brcm. Thanks
> >
> > It seems this patch has been lost.
> > I don't find it in dpdk-next-net-brcm.
> Hmm.. Yes.
> I pushed it again. Please check. Thanks
OK
Same issue with "net/bnxt: fix ulp parser to ignore segment offset "
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] net/bnxt: fix compatibility with some old firmwares
2022-05-18 6:22 ` Thomas Monjalon
@ 2022-05-23 0:46 ` Ajit Khaparde
0 siblings, 0 replies; 6+ messages in thread
From: Ajit Khaparde @ 2022-05-23 0:46 UTC (permalink / raw)
To: Thomas Monjalon
Cc: David Marchand, dpdk-dev, dpdk stable, Somnath Kotur,
Randy Schacher, Kalesh AP
[-- Attachment #1: Type: text/plain, Size: 1286 bytes --]
On Tue, May 17, 2022 at 11:22 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 18/05/2022 05:58, Ajit Khaparde:
> > On Tue, May 17, 2022 at 12:18 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > >
> > > 30/03/2022 01:21, Ajit Khaparde:
> > > > On Fri, Mar 18, 2022 at 8:03 AM David Marchand
> > > > <david.marchand@redhat.com> wrote:
> > > > >
> > > > > This reverts commit 3972281f47b2cc0cf844698885f0e6b4228c0975.
> > > > >
> > > > > Reported by Red Hat QE: with older firmware versions (at least versions
> > > > > 20.6.112.0 and 20.6.143.0), initialisation never succeeds following this
> > > > > change.
> > > > > Revert it for now, waiting for a more complete fix.
> > > > >
> > > > > Fixes: 3972281f47b2 ("net/bnxt: fix device readiness check")
> > > > > Cc: stable@dpdk.org
> > > > >
> > > > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > > >
> > > > Patch applied to dpdk-next-net-brcm. Thanks
> > >
> > > It seems this patch has been lost.
> > > I don't find it in dpdk-next-net-brcm.
> > Hmm.. Yes.
> > I pushed it again. Please check. Thanks
>
> OK
> Same issue with "net/bnxt: fix ulp parser to ignore segment offset "
Thanks Thomas.
Pushed again to dpdk-next-net-brcm. Please apply.
>
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-23 0:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-03-18 15:03 [PATCH] net/bnxt: fix compatibility with some old firmwares David Marchand
2022-03-29 23:21 ` Ajit Khaparde
2022-05-17 7:18 ` Thomas Monjalon
2022-05-18 3:58 ` Ajit Khaparde
2022-05-18 6:22 ` Thomas Monjalon
2022-05-23 0:46 ` Ajit Khaparde
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).