DPDK patches and discussions
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: dev@dpdk.org, anatoly.burakov@intel.com, stable@dpdk.org
Subject: Re: [PATCH] test/bpf: skip test if libpcap is unavailable
Date: Mon, 21 Mar 2022 09:15:39 -0700	[thread overview]
Message-ID: <20220321091539.720338b9@hermes.local> (raw)
In-Reply-To: <1647868407-4467-1-git-send-email-roretzla@linux.microsoft.com>

On Mon, 21 Mar 2022 06:13:27 -0700
Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:

> test_bpf_convert is being conditionally registered depending on the
> presence of RTE_HAS_LIBPCAP except the UT unconditionally lists it as a
> test to run.
> 
> when the UT runs test_bpf_convert test-dpdk can't find the registration
> and assumes the DPDK_TEST environment variable hasn't been defined
> resulting in test-dpdk dropping to interactive mode and subsequently
> waiting for the remainder of the UT fast-test timeout period before
> reporting the test as having timed out.
> 
> * unconditionally register test_bpf_convert
> * if ! RTE_HAS_LIBPCAP provide a stub test_bpf_convert that reports the
>   test is skipped similar to that done with the test_bpf test.
> 
> Fixes: 2eccf6afbea9 ("bpf: add function to convert classic BPF to DPDK BPF")
> Cc: stephen@networkplumber.org
> Cc: anatoly.burakov@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>

LGTM
Acked-by: Stephen Hemminger <stephen@networkplumber.org>

  parent reply	other threads:[~2022-03-21 16:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-21 13:13 Tyler Retzlaff
2022-03-21 14:42 ` Ananyev, Konstantin
2022-03-22  6:11   ` Tyler Retzlaff
2022-03-21 16:15 ` Stephen Hemminger [this message]
2022-03-22  7:12 ` [PATCH v2] " Tyler Retzlaff
2022-03-22 11:50   ` Ananyev, Konstantin
2022-04-26  6:38     ` Tyler Retzlaff
2022-04-26  7:41   ` David Marchand
2022-04-26  7:47     ` Tyler Retzlaff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220321091539.720338b9@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=roretzla@linux.microsoft.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).