From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,
Bruce Richardson <bruce.richardson@intel.com>,
Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
Dmitry Malloy <dmitrym@microsoft.com>,
Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [PATCH] eal: factorize lcore main loop
Date: Fri, 25 Mar 2022 09:38:07 -0700 [thread overview]
Message-ID: <20220325163807.GB11014@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> (raw)
In-Reply-To: <CAJFAV8wshumva3BTQEHvt1TxX+iTx0jK2fw_=B+E5doHWBPh-g@mail.gmail.com>
On Fri, Mar 25, 2022 at 04:09:50PM +0100, David Marchand wrote:
> On Fri, Mar 25, 2022 at 3:58 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > > But seeing how this code has been there from day 1, I would not
> > > > request a backport.
> > >
> > > this looks better to me it ends up being a bit less code and it solves
> > > the problem in a general fashion for platforms including windows.
> > >
> > > on windows the implementation does run the start_routine before assigning
> > > thread which was addressed with this patch. (still not merged)
> > > http://patchwork.dpdk.org/project/dpdk/list/?series=22094
> > >
> > > it's likely your patch will be merged before mine so when that happens
> > > i'll just quietly abandon mine. however if some desire exists for a
> > > backport the simpler patch i provided could be used.
> >
> > Your patch could be merged now that we start a new cycle.
> > What do you prefer? Is David's solution better?
> > In this case, should we reject your patch?
>
> We can merge Tyler fix right away because it is a real issue on
> Windows and it can be backported.
>
> My series can be rebased and merged later as a cleanup/unified
> solution for all OS.
sounds about right to me. no objection here.
>
>
> --
> David Marchand
next prev parent reply other threads:[~2022-03-25 16:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-23 9:30 David Marchand
2022-03-23 12:01 ` Morten Brørup
2022-03-24 8:31 ` Tyler Retzlaff
2022-03-24 14:44 ` David Marchand
2022-03-25 12:11 ` Tyler Retzlaff
2022-03-25 14:58 ` Thomas Monjalon
2022-03-25 15:09 ` David Marchand
2022-03-25 16:38 ` Tyler Retzlaff [this message]
2022-03-25 12:23 ` Tyler Retzlaff
2022-04-01 8:44 ` [PATCH v2 1/2] eal: cleanup lcore ID hand-over David Marchand
2022-04-01 8:44 ` [PATCH v2 2/2] eal: factorize lcore main loop David Marchand
2022-04-05 7:05 ` David Marchand
2022-04-05 16:34 ` [PATCH v3 1/2] eal: cleanup lcore ID hand-over David Marchand
2022-04-05 16:34 ` [PATCH v3 2/2] eal: factorize lcore main loop David Marchand
2022-04-14 11:48 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220325163807.GB11014@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net \
--to=roretzla@linux.microsoft.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dmitry.kozliuk@gmail.com \
--cc=dmitrym@microsoft.com \
--cc=navasile@linux.microsoft.com \
--cc=pallavi.kadam@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).