From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 77E3FA00C4;
	Fri, 25 Mar 2022 17:38:10 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 24B4140687;
	Fri, 25 Mar 2022 17:38:10 +0100 (CET)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id B882140140
 for <dev@dpdk.org>; Fri, 25 Mar 2022 17:38:08 +0100 (CET)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id EC61120DECE8; Fri, 25 Mar 2022 09:38:07 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com EC61120DECE8
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1648226287;
 bh=sLywZV+37NfrMsLJFJLHVxaoGx90e/6B9n7UWH4skeM=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=h9vD5FfN+vXUXsh+ELtq8Yb8MFNc5qET0GiA0gbFdzCLFwdwkt4I/vKLKUPMZ7zzy
 vDx1FDSfBxTafxuQ7AS3B4rdiPCBMATC2wCJZfBbz46b1Q4mg04xQLCGblcVzSnRIK
 t4pHUC/PFNqR1d9myLhJGho4Ivb9WggtY9osG9bU=
Date: Fri, 25 Mar 2022 09:38:07 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>,
 Bruce Richardson <bruce.richardson@intel.com>,
 Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>,
 Narcisa Ana Maria Vasile <navasile@linux.microsoft.com>,
 Dmitry Malloy <dmitrym@microsoft.com>,
 Pallavi Kadam <pallavi.kadam@intel.com>
Subject: Re: [PATCH] eal: factorize lcore main loop
Message-ID: <20220325163807.GB11014@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <20220323093001.20618-1-david.marchand@redhat.com>
 <CAJFAV8w19r0gkawL6q3X4--LVpcYE=Jv7-t88dW=hRB-sburEw@mail.gmail.com>
 <20220325121126.GA6378@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <2027001.KlZ2vcFHjT@thomas>
 <CAJFAV8wshumva3BTQEHvt1TxX+iTx0jK2fw_=B+E5doHWBPh-g@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAJFAV8wshumva3BTQEHvt1TxX+iTx0jK2fw_=B+E5doHWBPh-g@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Fri, Mar 25, 2022 at 04:09:50PM +0100, David Marchand wrote:
> On Fri, Mar 25, 2022 at 3:58 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > > But seeing how this code has been there from day 1, I would not
> > > > request a backport.
> > >
> > > this looks better to me it ends up being a bit less code and it solves
> > > the problem in a general fashion for platforms including windows.
> > >
> > > on windows the implementation does run the start_routine before assigning
> > > thread which was addressed with this patch. (still not merged)
> > > http://patchwork.dpdk.org/project/dpdk/list/?series=22094
> > >
> > > it's likely your patch will be merged before mine so when that happens
> > > i'll just quietly abandon mine.  however if some desire exists for a
> > > backport the simpler patch i provided could be used.
> >
> > Your patch could be merged now that we start a new cycle.
> > What do you prefer? Is David's solution better?
> > In this case, should we reject your patch?
> 
> We can merge Tyler fix right away because it is a real issue on
> Windows and it can be backported.
> 
> My series can be rebased and merged later as a cleanup/unified
> solution for all OS.

sounds about right to me. no objection here.

> 
> 
> -- 
> David Marchand