From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 3CC8AA04FD;
Tue, 29 Mar 2022 00:51:18 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id E9C5F40691;
Tue, 29 Mar 2022 00:51:17 +0200 (CEST)
Received: from mail-lf1-f48.google.com (mail-lf1-f48.google.com
[209.85.167.48]) by mails.dpdk.org (Postfix) with ESMTP id 12AD14068E
for <dev@dpdk.org>; Tue, 29 Mar 2022 00:51:17 +0200 (CEST)
Received: by mail-lf1-f48.google.com with SMTP id k21so27314110lfe.4
for <dev@dpdk.org>; Mon, 28 Mar 2022 15:51:17 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=date:from:to:cc:subject:message-id:in-reply-to:references
:mime-version:content-transfer-encoding;
bh=4OXZdWE4ey8rEPS9ZA6wT6lZPZqm/BeNazmUoFwTTsI=;
b=G9XLskSdPvI0QGK/F0N+EQem8D+FwzGu1TQvynSKf5zwXl36GO9j4bDmrGlYvRGdaL
0R1l+XSG0RFL+x7MDLo2QQdVRoHt5NVmAk+GloMShRJ0Ph/u06pRNm/pMYqYl9OvtHn+
ZvF2ZOv/wImISDiaCtL+uBGKg7La0WTJkh7Zx1daHBIUJPJ40GDTPc1hehV9vqk0sWWC
MTgtN+w+qE7T9mqCrom5wt8LVcz7gpMmdHqfpb5IgHU5tJMU0adeVsny/UZCKpip9SGr
oS9adOwIBXpulB3x+HKsTx3kFgswi59MiYdlQizYBMcsnZAnDyMGYm1MQeQHjrlfFoVW
oe6Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to
:references:mime-version:content-transfer-encoding;
bh=4OXZdWE4ey8rEPS9ZA6wT6lZPZqm/BeNazmUoFwTTsI=;
b=Qe5ByMPSzlj2yDUfv9ayvGF3pGFBs4dnE+mS5BHDCCpnqrFqGKKhJtyRx3bZeRgFI7
ok8j1D02aPDTRB/lLz56j/DOZxeYeAgv6RQ1jQpJohYufrfEDShYVGR/wzWsfTdN1/yK
jlr24daqaDPegW+nqvKIHfaTd8kI69Ue9OOTmnbzdr3rQLzu4eoCSa1OF/6SbFkhCjJH
mIiyPh6EnAaSGVKEx4zFPYodX3p7m0TjhefikxJYUxV+IzvgyxG/2owKalWc/CItSVDR
6YteeePW/ysISYGFxp/Tp+JIQ2Gl0cXKeFEE0JbSQthCIxlGB3QESs2LO+dTgmTAy4rV
H49Q==
X-Gm-Message-State: AOAM532Ht7GyLU5SlM7H8IdTxim+oSHc6X1ZFxC8OdfzZi/4/mWA9xrY
FdzVxC9doTMA9pqNi25gGAU=
X-Google-Smtp-Source: ABdhPJxrJ7AsUSYTYMQ1WcxqDudWUw7mW9iPN2GEVEv9ho2stD0Yp7dmr+PQaJLDg8KapXNSlLm8xQ==
X-Received: by 2002:a05:6512:2244:b0:44a:5fab:5ac4 with SMTP id
i4-20020a056512224400b0044a5fab5ac4mr19780748lfu.665.1648507876390;
Mon, 28 Mar 2022 15:51:16 -0700 (PDT)
Received: from sovereign (broadband-37-110-65-23.ip.moscow.rt.ru.
[37.110.65.23]) by smtp.gmail.com with ESMTPSA id
br38-20020a056512402600b0044a70a9494bsm1320322lfb.67.2022.03.28.15.51.15
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 28 Mar 2022 15:51:15 -0700 (PDT)
Date: Tue, 29 Mar 2022 01:51:14 +0300
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
To: "Varghese, Vipin" <Vipin.Varghese@amd.com>
Cc: Thomas Monjalon <thomas@monjalon.net>, "david.marchand@redhat.com"
<david.marchand@redhat.com>, "Tummala, Sivaprasad"
<Sivaprasad.Tummala@amd.com>, "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] meson: update doc logic for Windows
Message-ID: <20220329015114.04aedb30@sovereign>
In-Reply-To: <MN2PR12MB308520F6E8614AD15810F1D0821D9@MN2PR12MB3085.namprd12.prod.outlook.com>
References: <20220326025936.487626-1-vipin.varghese@amd.com>
<2037084.bB369e8A3T@thomas>
<MN2PR12MB3085A3D0DFEDBE2DBFD9AC78821D9@MN2PR12MB3085.namprd12.prod.outlook.com>
<20220328123438.0f8bb44e@sovereign>
<MN2PR12MB308520F6E8614AD15810F1D0821D9@MN2PR12MB3085.namprd12.prod.outlook.com>
X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
2022-03-28 12:29 (UTC+0000), Varghese, Vipin:
[...]
> > We did get error from `doc/meson` stating ` echo command not available
> > on windows` for both cmd and powershell for the line ```
> > run_target('doc', command: [echo, message, doc_target_names],
> > depends: doc_targets)
> > ```
>
> This line never searches for "echo" command, e8c90926bdde ("doc: fix build on Windows with Meson 0.58") introduced "echo" variable precisely to avoid this.
> Can you give the full log?
>
> > > Steps to reproduce the error:
> > > - Install dependencies doxygen & sphinix build on Windwos server 2019.
> > > - Build DPDK with option enable_docs=true for API or User Guide.
> > >
> > > This produces error
> > > ```
> > > FAILED: doc/api/examples.dox
> > > sh -e dpdk/doc/api/generate_examples.sh dpdk/examples
> > > doc/api/examples.dox ```
Thanks for confirming that the "echo" issue did not reappear.
[...]
> Are you recommending
>
> Windows libraries and binaries should be cross build from linux (where all dependencies and shell script works)?
>
> Or
>
> let us enhance the check for windows native build, if yes for option `-Denable_docs=true, we can stop the build for docs`.
>
> If the latter is suggestion I will share v2 patch to check the same.
I recommend enhancing the Windows native build
by enabling full-fledged docs generation :)
I'm reluctant to accept this patch, even corrected,
because it effectively works against better Windows support:
- it makes less meson code reachable on Windows,
allowing it to accumulate incompatible changes;
- it treats Windows as special,
while we want it to be a platform supported on par with the others.
That being said, the latter option is acceptable for sure,
because it fixes a build failure in certain configuration.