From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 89A89A0508;
	Tue, 29 Mar 2022 14:18:40 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 06D2541151;
	Tue, 29 Mar 2022 14:18:40 +0200 (CEST)
Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182])
 by mails.dpdk.org (Postfix) with ESMTP id AD01240691
 for <dev@dpdk.org>; Tue, 29 Mar 2022 14:18:38 +0200 (CEST)
Received: by linux.microsoft.com (Postfix, from userid 1086)
 id 5B61320DECF5; Tue, 29 Mar 2022 05:10:38 -0700 (PDT)
DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5B61320DECF5
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;
 s=default; t=1648555838;
 bh=JVjzD2gRNhd2QvFii0clbbtGpkm9OFWFBZzwJ2BHlFw=;
 h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
 b=VS4kFjzlz2iK4QWhAXiOUonc8WaY4rFnB1h3T6MVoteGpqDO8C+bAQBebAs3daiaN
 R0v6HsSVnWsAFQ5zOHwvLArItC2c/RBagqMWpQaPfaL/95VJhSG2vLiEPmQwXtQj1R
 SDw4r4RENT1zKIWwFsdeVQMoLTg2zhPQqbYIo4zk=
Date: Tue, 29 Mar 2022 05:10:38 -0700
From: Tyler Retzlaff <roretzla@linux.microsoft.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org, dmitry.kozliuk@gmail.com, gakhil@marvell.com,
 roy.fan.zhang@intel.com, david.marchand@redhat.com
Subject: Re: [PATCH 2/2] test: enable most driver tests on Windows
Message-ID: <20220329121038.GA2497@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
References: <1648544551-21324-1-git-send-email-roretzla@linux.microsoft.com>
 <1921305.8hb0ThOEGa@thomas>
 <20220329093242.GA21442@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
 <1842064.eGJsNajkDb@thomas>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1842064.eGJsNajkDb@thomas>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Tue, Mar 29, 2022 at 01:29:55PM +0200, Thomas Monjalon wrote:
> 29/03/2022 11:32, Tyler Retzlaff:
> > On Tue, Mar 29, 2022 at 11:12:21AM +0200, Thomas Monjalon wrote:
> > > 29/03/2022 11:02, Tyler Retzlaff:
> > > > enable most of the driver tests to run on windows, most tests will be
> > > > skipped since the drivers themselves are not available on windows.
> > > [...]
> > > >  if not is_windows
> > > >      driver_test_names += [
> > > > -            'cryptodev_aesni_mb_autotest',
> > > > -            'cryptodev_aesni_gcm_autotest',
> > > > -            'cryptodev_cn9k_autotest',
> > > > -            'cryptodev_cn10k_autotest',
> > > > -            'cryptodev_dpaa_sec_autotest',
> > > > -            'cryptodev_dpaa2_sec_autotest',
> > > > -            'cryptodev_null_autotest',
> > > > -            'cryptodev_openssl_autotest',
> > > >              'cryptodev_openssl_asym_autotest',
> > > > -            'cryptodev_qat_autotest',
> > > > -            'cryptodev_sw_armv8_autotest',
> > > > -            'cryptodev_sw_kasumi_autotest',
> > > > -            'cryptodev_sw_mvsam_autotest',
> > > > -            'cryptodev_sw_snow3g_autotest',
> > > > -            'cryptodev_sw_zuc_autotest',
> > > > -            'dmadev_autotest',
> > > >              'eventdev_selftest_octeontx',
> > > >              'eventdev_selftest_sw',
> > > > -            'rawdev_autotest',
> > > >      ]
> > > 
> > > Please could you mention the reason for keeping few tests 
> > > in the conditional list?
> > 
> > i indicated in the cover for the series.
> > 
> > * remaining driver tests require further investigation and will not be
> >   addressed in this series.
> 
> Does it mean you did not try to run these tests?
> Or did you see some issues to enable them?

cryptodev_openssl_asym_autotest
  test fails because it does not bother checking to see if required
  driver is available ias the other cryptodev tests do.

eventdev_selftest_octeontx, eventdev_selftest_sw
  because it has a dependency on eventdev library which doesn't build
  on windows.

the dump_xxx tests were not evaluated, i did not try to build them or
run them.

> 
> > i did not mention the dump tests but the same applies.
> 
> Is there a blocker for dump or just a need for test?
> 
> > or are you asking for the above to be stated in the commit message?
> 
> I want to understand the exact status.
> 
> 
> > > Listing the remaining ones:
> > > 	- cryptodev_openssl_asym_autotest
> > > 	- eventdev_selftest_octeontx
> > > 	- eventdev_selftest_sw
> > > 
> > > There are also the dump tests:
> > > 	- dump_struct_sizes
> > > 	- dump_mempool
> > > 	- dump_malloc_stats
> > > 	- dump_devargs
> > > 	- dump_log_types
> > > 	- dump_ring
> > > 	- dump_physmem
> > > 	- dump_memzone
> > > 
> > 
> > as above they will have to be investigated separately.
> 
>