From: Kevin Laatz <kevin.laatz@intel.com>
To: dev@dpdk.org
Cc: bruce.richardson@intel.com, Kevin Laatz <kevin.laatz@intel.com>
Subject: [PATCH v3] dma/idxd: add generic option for queue config
Date: Fri, 1 Apr 2022 11:35:00 +0100 [thread overview]
Message-ID: <20220401103500.697597-1-kevin.laatz@intel.com> (raw)
In-Reply-To: <20220331172112.575972-1-kevin.laatz@intel.com>
The device config script currently uses some defaults to configure
devices in a generic way.
With the addition of this option, users have more control over how
queues are configured.
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
---
drivers/dma/idxd/dpdk_idxd_cfg.py | 34 +++++++++++++++++++++----------
1 file changed, 23 insertions(+), 11 deletions(-)
diff --git a/drivers/dma/idxd/dpdk_idxd_cfg.py b/drivers/dma/idxd/dpdk_idxd_cfg.py
index 3f5d5ee752..77c473b240 100755
--- a/drivers/dma/idxd/dpdk_idxd_cfg.py
+++ b/drivers/dma/idxd/dpdk_idxd_cfg.py
@@ -63,7 +63,15 @@ def get_dsa_id(pci):
sys.exit(f"Could not get device ID for device {pci}")
-def configure_dsa(dsa_id, queues, prefix):
+def parse_wq_opts(wq_opts):
+ "Parse user-specified queue configuration, creating a dict of options"
+ try:
+ return {o.split('=')[0]: o.split('=')[1] for o in wq_opts}
+ except ValueError:
+ sys.exit("Invalid --wq-option format, use format 'option=value'")
+
+
+def configure_dsa(dsa_id, args):
"Configure the DSA instance with appropriate number of queues"
dsa_dir = SysfsDir(f"/sys/bus/dsa/devices/dsa{dsa_id}")
@@ -72,8 +80,8 @@ def configure_dsa(dsa_id, queues, prefix):
max_queues = dsa_dir.read_int("max_work_queues")
max_work_queues_size = dsa_dir.read_int("max_work_queues_size")
- nb_queues = min(queues, max_queues)
- if queues > nb_queues:
+ nb_queues = min(args.q, max_queues)
+ if args.q > nb_queues:
print(f"Setting number of queues to max supported value: {max_queues}")
# we want one engine per group, and no more engines than queues
@@ -83,14 +91,16 @@ def configure_dsa(dsa_id, queues, prefix):
# configure each queue
for q in range(nb_queues):
+ wqcfg = {"group_id": q % nb_groups,
+ "type": "user",
+ "mode": "dedicated",
+ "name": f"{args.prefix}_wq{dsa_id}.{q}",
+ "priority": 1,
+ "max_batch_size": 1024,
+ "size": int(max_work_queues_size / nb_queues)}
+ wqcfg.update(parse_wq_opts(args.wq_option))
wq_dir = SysfsDir(os.path.join(dsa_dir.path, f"wq{dsa_id}.{q}"))
- wq_dir.write_values({"group_id": q % nb_groups,
- "type": "user",
- "mode": "dedicated",
- "name": f"{prefix}_wq{dsa_id}.{q}",
- "priority": 1,
- "max_batch_size": 1024,
- "size": int(max_work_queues_size / nb_queues)})
+ wq_dir.write_values(wqcfg)
# enable device and then queues
idxd_dir = SysfsDir(get_drv_dir("idxd"))
@@ -112,6 +122,8 @@ def main(args):
arg_p.add_argument('--name-prefix', metavar='prefix', dest='prefix',
default="dpdk",
help="Prefix for workqueue name to mark for DPDK use [default: 'dpdk']")
+ arg_p.add_argument('--wq-option', action='append',
+ help="Provide additional config option for queues (format 'x=y')")
arg_p.add_argument('--reset', action='store_true',
help="Reset DSA device and its queues")
parsed_args = arg_p.parse_args(args[1:])
@@ -121,7 +133,7 @@ def main(args):
if parsed_args.reset:
reset_device(dsa_id)
else:
- configure_dsa(dsa_id, parsed_args.q, parsed_args.prefix)
+ configure_dsa(dsa_id, parsed_args)
if __name__ == "__main__":
--
2.31.1
next prev parent reply other threads:[~2022-04-01 10:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-30 15:07 [PATCH] " Kevin Laatz
2022-03-31 14:57 ` Bruce Richardson
2022-03-31 15:47 ` Kevin Laatz
2022-03-31 17:21 ` [PATCH v2] " Kevin Laatz
2022-04-01 9:08 ` Bruce Richardson
2022-04-01 10:35 ` Kevin Laatz [this message]
2022-04-01 10:51 ` [PATCH v3] " Bruce Richardson
2022-06-07 10:47 ` Thomas Monjalon
2022-04-04 9:58 ` Pai G, Sunil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220401103500.697597-1-kevin.laatz@intel.com \
--to=kevin.laatz@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).