From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B7A05A04FD; Mon, 4 Apr 2022 08:21:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 668B240698; Mon, 4 Apr 2022 08:21:15 +0200 (CEST) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id 8AF664068C for ; Mon, 4 Apr 2022 08:21:14 +0200 (CEST) Received: by mail-pj1-f42.google.com with SMTP id kw18so1597171pjb.5 for ; Sun, 03 Apr 2022 23:21:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PUqBjK4HGSpylnlhquBmhbMXePnaNl9Y1rybhJ/3A7I=; b=C0tczuQdvPLGXB0OQeZ/I8pHl7VdG4q9bo3W6aSKttg5mJyIcMXkBsV0wjbptrJylZ L4g21Jmvfd27zl6tqd0zZK/7JfP/K17CH8jaNChyHG7yPI24I0EJz3w+PQlvTs1FJxPP IWTNsxmNS+blZ4EA+RozNnBOkBsdTSUXaLtXWG+KjFg+G2uY7yPAHYYkyDxVc6/RERPy 1464uqmXSyPwOFBd3c8qM+nhtGeur78bmd3wMnP0Ekd8JdSHLS2z7LmZdnGFlGyCZfSh P7yYEsEPbqDTmtUGkHdDksNtKgCIL9J5tJWMZPfMVI+AFUmGeyDHBKh/ZcxU51yuydlH LRuw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PUqBjK4HGSpylnlhquBmhbMXePnaNl9Y1rybhJ/3A7I=; b=pz6mWuRd/ZmPZ9fYARvNzSJPVGI87ZKdTagiNqsDv7j+cQlCrXg/d6b0B3Sybr3GPQ AruHxkSqE0DJGWnLE1LM4bVzFWbfeTY1ajejjdnWvEjOEfdBHIJIaD00BLiwdfAewDN1 bPIxfMO9IQkpWtR+FrGGHB6YfGnV5kCrl8+r14V7UPgD1YwYxwmqaL7OvPVSpi85xW4Z Xwk8Ov+uNXh/XxOR92N+iEli74cSC6u/YXAqXf9FrEniauvGThbOnR+IPLI6XUT/WFUe 7WXkxDrkuyrYxD4BDfqJkSrHISMhkSGdbEACSN6gMxiBWY47c0HbOYjEu9BNW4s3YlC3 eQUg== X-Gm-Message-State: AOAM531Nc7WZjmSbWiIRcaRuLD4yGD5pK6O8S26REdCmzD64keCugfZ+ m3LC6ssu+W+FZH4TWmancPtdaQ== X-Google-Smtp-Source: ABdhPJwDE6MYPfxUWDcuVuuxxhLyYQYi3gubwlN64YNsR5m7kTH856HUmtVekYsI4tynOooUTG5CEw== X-Received: by 2002:a17:902:82c8:b0:156:8918:8db5 with SMTP id u8-20020a17090282c800b0015689188db5mr7877744plz.124.1649053273680; Sun, 03 Apr 2022 23:21:13 -0700 (PDT) Received: from shemminger-XPS-13-9360 (hirgnt26.hicv.net. [205.172.16.196]) by smtp.gmail.com with ESMTPSA id w13-20020a17090a5e0d00b001c7d4099670sm9263822pjf.28.2022.04.03.23.21.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 03 Apr 2022 23:21:13 -0700 (PDT) Date: Sun, 3 Apr 2022 20:21:05 -1000 From: Stephen Hemminger To: David Marchand Cc: dev@dpdk.org, maxime.coquelin@redhat.com, chenbo.xia@intel.com, jiayu.hu@intel.com, yuanx.wang@intel.com, xuan.ding@intel.com, Ruifeng Wang , Jan Viktorin , David Christensen , Bruce Richardson , Konstantin Ananyev Subject: Re: [RFC PATCH v2 2/9] eal: annotate spinlock and rwlock Message-ID: <20220403202105.6a90024b@shemminger-XPS-13-9360> In-Reply-To: <20220330134956.18927-3-david.marchand@redhat.com> References: <20220328121758.26632-1-david.marchand@redhat.com> <20220330134956.18927-1-david.marchand@redhat.com> <20220330134956.18927-3-david.marchand@redhat.com> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, 30 Mar 2022 15:49:49 +0200 David Marchand wrote: > +#ifdef RTE_ANNOTATE_LOCKS > + > +#define RTE_ANNOTATED_LOCK \ > + __attribute__((lockable)) > + > +#define RTE_GUARDED_BY(...) \ > + __attribute__((guarded_by(__VA_ARGS__))) > +#define RTE_GUARDED_VAR \ > + __attribute__((guarded_var)) Could we use attributes that match the existing syntax and lower case. That is what was done for hot/cold and format attributes. #define __rte_lockable